mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-27 17:24:06 +00:00
2e93f2c92f
Currently, deriving on packed structs has some non-trivial limitations,
related to the fact that taking references on unaligned fields is UB.
The current approach to field accesses in derived code:
- Normal case: `&self.0`
- In a packed struct that derives `Copy`: `&{self.0}`
- In a packed struct that doesn't derive `Copy`: `&self.0`
Plus, we disallow deriving any builtin traits other than `Default` for any
packed generic type, because it's possible that there might be
misaligned fields. This is a fairly broad restriction.
Plus, we disallow deriving any builtin traits other than `Default` for most
packed types that don't derive `Copy`. (The exceptions are those where the
alignments inherently satisfy the packing, e.g. in a type with
`repr(packed(N))` where all the fields have alignments of `N` or less
anyway. Such types are pretty strange, because the `packed` attribute is
not having any effect.)
This commit introduces a new, simpler approach to field accesses:
- Normal case: `&self.0`
- In a packed struct: `&{self.0}`
In the latter case, this requires that all fields impl `Copy`, which is
a new restriction. This means that the following example compiles under
the old approach and doesn't compile under the new approach.
```
#[derive(Debug)]
struct NonCopy(u8);
#[derive(Debug)
#[repr(packed)]
struct MyType(NonCopy);
```
(Note that the old approach's support for cases like this was brittle.
Changing the `u8` to a `u16` would be enough to stop it working. So not
much capability is lost here.)
However, the other constraints from the old rules are removed. We can now
derive builtin traits for packed generic structs like this:
```
trait Trait { type A; }
#[derive(Hash)]
#[repr(packed)]
pub struct Foo<T: Trait>(T, T::A);
```
To allow this, we add a `T: Copy` bound in the derived impl and a `T::A:
Copy` bound in where clauses. So `T` and `T::A` must impl `Copy`.
We can now also derive builtin traits for packed structs that don't derive
`Copy`, so long as the fields impl `Copy`:
```
#[derive(Hash)]
#[repr(packed)]
pub struct Foo(u32);
```
This includes types that hand-impl `Copy` rather than deriving it, such as the
following, that show up in winapi-0.2:
```
#[derive(Clone)]
#[repr(packed)]
struct MyType(i32);
impl Copy for MyType {}
```
The new approach is simpler to understand and implement, and it avoids
the need for the `unsafe_derive_on_repr_packed` check.
One exception is required for backwards-compatibility: we allow `[u8]`
fields for now. There is a new lint for this,
`byte_slice_in_packed_struct_with_derive`.
64 lines
3.2 KiB
Plaintext
64 lines
3.2 KiB
Plaintext
warning: byte slice in a packed struct that derives a built-in trait
|
|
--> $DIR/deriving-all-codegen.rs:80:24
|
|
|
|
|
LL | #[derive(Debug, Hash)]
|
|
| ----- in this derive macro expansion
|
|
LL | #[repr(packed)]
|
|
LL | struct PackedUnsizedU8([u8]);
|
|
| ^^^^
|
|
|
|
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
|
= note: for more information, see issue #107457 <https://github.com/rust-lang/rust/issues/107457>
|
|
= help: consider implementing the trait by hand, or remove the `packed` attribute
|
|
= note: `#[warn(byte_slice_in_packed_struct_with_derive)]` on by default
|
|
= note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
warning: byte slice in a packed struct that derives a built-in trait
|
|
--> $DIR/deriving-all-codegen.rs:80:24
|
|
|
|
|
LL | #[derive(Debug, Hash)]
|
|
| ---- in this derive macro expansion
|
|
LL | #[repr(packed)]
|
|
LL | struct PackedUnsizedU8([u8]);
|
|
| ^^^^
|
|
|
|
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
|
= note: for more information, see issue #107457 <https://github.com/rust-lang/rust/issues/107457>
|
|
= help: consider implementing the trait by hand, or remove the `packed` attribute
|
|
= note: this warning originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
warning: 2 warnings emitted
|
|
|
|
Future incompatibility report: Future breakage diagnostic:
|
|
warning: byte slice in a packed struct that derives a built-in trait
|
|
--> $DIR/deriving-all-codegen.rs:80:24
|
|
|
|
|
LL | #[derive(Debug, Hash)]
|
|
| ----- in this derive macro expansion
|
|
LL | #[repr(packed)]
|
|
LL | struct PackedUnsizedU8([u8]);
|
|
| ^^^^
|
|
|
|
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
|
= note: for more information, see issue #107457 <https://github.com/rust-lang/rust/issues/107457>
|
|
= help: consider implementing the trait by hand, or remove the `packed` attribute
|
|
= note: `#[warn(byte_slice_in_packed_struct_with_derive)]` on by default
|
|
= note: this warning originates in the derive macro `Debug` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|
|
Future breakage diagnostic:
|
|
warning: byte slice in a packed struct that derives a built-in trait
|
|
--> $DIR/deriving-all-codegen.rs:80:24
|
|
|
|
|
LL | #[derive(Debug, Hash)]
|
|
| ---- in this derive macro expansion
|
|
LL | #[repr(packed)]
|
|
LL | struct PackedUnsizedU8([u8]);
|
|
| ^^^^
|
|
|
|
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
|
|
= note: for more information, see issue #107457 <https://github.com/rust-lang/rust/issues/107457>
|
|
= help: consider implementing the trait by hand, or remove the `packed` attribute
|
|
= note: `#[warn(byte_slice_in_packed_struct_with_derive)]` on by default
|
|
= note: this warning originates in the derive macro `Hash` (in Nightly builds, run with -Z macro-backtrace for more info)
|
|
|