mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-01 15:01:51 +00:00
78d29ad8d6
Sometimes move errors are because of a misplaced `continue`, but we didn't
surface that anywhere. Now when there are more than one set of nested loops
we show them out and point at the `continue` and `break` expressions within
that might need to go elsewhere.
```
error[E0382]: use of moved value: `foo`
--> $DIR/nested-loop-moved-value-wrong-continue.rs:46:18
|
LL | for foo in foos {
| ---
| |
| this reinitialization might get skipped
| move occurs because `foo` has type `String`, which does not implement the `Copy` trait
...
LL | for bar in &bars {
| ---------------- inside of this loop
...
LL | baz.push(foo);
| --- value moved here, in previous iteration of loop
...
LL | qux.push(foo);
| ^^^ value used here after move
|
note: verify that your loop breaking logic is correct
--> $DIR/nested-loop-moved-value-wrong-continue.rs:41:17
|
LL | for foo in foos {
| ---------------
...
LL | for bar in &bars {
| ----------------
...
LL | continue;
| ^^^^^^^^ this `continue` advances the loop at line 33
help: consider moving the expression out of the loop so it is only moved once
|
LL ~ let mut value = baz.push(foo);
LL ~ for bar in &bars {
LL |
...
LL | if foo == *bar {
LL ~ value;
|
help: consider cloning the value if the performance cost is acceptable
|
LL | baz.push(foo.clone());
| ++++++++
```
Fix #92531.
37 lines
679 B
Rust
37 lines
679 B
Rust
fn takes_fn(f: impl Fn()) {
|
|
loop {
|
|
takes_fnonce(f);
|
|
//~^ ERROR use of moved value
|
|
//~| HELP consider borrowing
|
|
}
|
|
}
|
|
|
|
fn takes_fn_mut(m: impl FnMut()) {
|
|
if maybe() {
|
|
takes_fnonce(m);
|
|
//~^ HELP consider mutably borrowing
|
|
}
|
|
takes_fnonce(m);
|
|
//~^ ERROR use of moved value
|
|
}
|
|
|
|
fn has_closure() {
|
|
let mut x = 0;
|
|
let mut closure = || {
|
|
x += 1;
|
|
};
|
|
takes_fnonce(closure);
|
|
//~^ HELP consider mutably borrowing
|
|
closure();
|
|
//~^ ERROR borrow of moved value
|
|
}
|
|
|
|
fn maybe() -> bool {
|
|
false
|
|
}
|
|
|
|
// Could also be Fn[Mut], here it doesn't matter
|
|
fn takes_fnonce(_: impl FnOnce()) {}
|
|
|
|
fn main() {}
|