mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-11 16:15:03 +00:00
a1cf2d334d
instead of `find()` follows by `is_some()` on strings Update clippy_lints/src/find_is_some_on_strs.rs Co-authored-by: Takayuki Nakata <f.seasons017@gmail.com> Update clippy_lints/src/methods/mod.rs Co-authored-by: Philipp Krones <hello@philkrones.com>
202 lines
4.7 KiB
Rust
202 lines
4.7 KiB
Rust
// aux-build:option_helpers.rs
|
||
// edition:2018
|
||
|
||
#![warn(clippy::all, clippy::pedantic)]
|
||
#![allow(
|
||
clippy::blacklisted_name,
|
||
clippy::default_trait_access,
|
||
clippy::missing_docs_in_private_items,
|
||
clippy::missing_safety_doc,
|
||
clippy::non_ascii_literal,
|
||
clippy::new_without_default,
|
||
clippy::needless_pass_by_value,
|
||
clippy::needless_lifetimes,
|
||
clippy::print_stdout,
|
||
clippy::must_use_candidate,
|
||
clippy::use_self,
|
||
clippy::useless_format,
|
||
clippy::wrong_self_convention,
|
||
clippy::unused_self,
|
||
unused
|
||
)]
|
||
|
||
#[macro_use]
|
||
extern crate option_helpers;
|
||
|
||
use std::collections::BTreeMap;
|
||
use std::collections::HashMap;
|
||
use std::collections::HashSet;
|
||
use std::collections::VecDeque;
|
||
use std::iter::FromIterator;
|
||
use std::ops::Mul;
|
||
use std::rc::{self, Rc};
|
||
use std::sync::{self, Arc};
|
||
|
||
use option_helpers::IteratorFalsePositives;
|
||
|
||
struct Lt<'a> {
|
||
foo: &'a u32,
|
||
}
|
||
|
||
impl<'a> Lt<'a> {
|
||
// The lifetime is different, but that’s irrelevant; see issue #734.
|
||
#[allow(clippy::needless_lifetimes)]
|
||
pub fn new<'b>(s: &'b str) -> Lt<'b> {
|
||
unimplemented!()
|
||
}
|
||
}
|
||
|
||
struct Lt2<'a> {
|
||
foo: &'a u32,
|
||
}
|
||
|
||
impl<'a> Lt2<'a> {
|
||
// The lifetime is different, but that’s irrelevant; see issue #734.
|
||
pub fn new(s: &str) -> Lt2 {
|
||
unimplemented!()
|
||
}
|
||
}
|
||
|
||
struct Lt3<'a> {
|
||
foo: &'a u32,
|
||
}
|
||
|
||
impl<'a> Lt3<'a> {
|
||
// The lifetime is different, but that’s irrelevant; see issue #734.
|
||
pub fn new() -> Lt3<'static> {
|
||
unimplemented!()
|
||
}
|
||
}
|
||
|
||
#[derive(Clone, Copy)]
|
||
struct U;
|
||
|
||
impl U {
|
||
fn new() -> Self {
|
||
U
|
||
}
|
||
// Ok because `U` is `Copy`.
|
||
fn to_something(self) -> u32 {
|
||
0
|
||
}
|
||
}
|
||
|
||
struct V<T> {
|
||
_dummy: T,
|
||
}
|
||
|
||
impl<T> V<T> {
|
||
fn new() -> Option<V<T>> {
|
||
None
|
||
}
|
||
}
|
||
|
||
struct AsyncNew;
|
||
|
||
impl AsyncNew {
|
||
async fn new() -> Option<Self> {
|
||
None
|
||
}
|
||
}
|
||
|
||
struct BadNew;
|
||
|
||
impl BadNew {
|
||
fn new() -> i32 {
|
||
0
|
||
}
|
||
}
|
||
|
||
struct T;
|
||
|
||
impl Mul<T> for T {
|
||
type Output = T;
|
||
// No error, obviously.
|
||
fn mul(self, other: T) -> T {
|
||
self
|
||
}
|
||
}
|
||
|
||
/// Checks implementation of `FILTER_NEXT` lint.
|
||
#[rustfmt::skip]
|
||
fn filter_next() {
|
||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||
|
||
// Multi-line case.
|
||
let _ = v.iter().filter(|&x| {
|
||
*x < 0
|
||
}
|
||
).next();
|
||
|
||
// Check that we don't lint if the caller is not an `Iterator`.
|
||
let foo = IteratorFalsePositives { foo: 0 };
|
||
let _ = foo.filter().next();
|
||
}
|
||
|
||
/// Checks implementation of `SEARCH_IS_SOME` lint.
|
||
#[rustfmt::skip]
|
||
fn search_is_some() {
|
||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||
let y = &&42;
|
||
|
||
// Check `find().is_some()`, single-line case.
|
||
let _ = v.iter().find(|&x| *x < 0).is_some();
|
||
let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
|
||
let _ = (0..1).find(|x| *x == 0).is_some();
|
||
let _ = v.iter().find(|x| **x == 0).is_some();
|
||
|
||
// Check `find().is_some()`, multi-line case.
|
||
let _ = v.iter().find(|&x| {
|
||
*x < 0
|
||
}
|
||
).is_some();
|
||
|
||
// Check `position().is_some()`, single-line case.
|
||
let _ = v.iter().position(|&x| x < 0).is_some();
|
||
|
||
// Check `position().is_some()`, multi-line case.
|
||
let _ = v.iter().position(|&x| {
|
||
x < 0
|
||
}
|
||
).is_some();
|
||
|
||
// Check `rposition().is_some()`, single-line case.
|
||
let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||
|
||
// Check `rposition().is_some()`, multi-line case.
|
||
let _ = v.iter().rposition(|&x| {
|
||
x < 0
|
||
}
|
||
).is_some();
|
||
|
||
let s1 = String::from("hello world");
|
||
let s2 = String::from("world");
|
||
// Check caller `find()` is a &`static str case
|
||
let _ = "hello world".find("world").is_some();
|
||
let _ = "hello world".find(&s2).is_some();
|
||
let _ = "hello world".find(&s2[2..]).is_some();
|
||
// Check caller of `find()` is a String case
|
||
let _ = s1.find("world").is_some();
|
||
let _ = s1.find(&s2).is_some();
|
||
let _ = s1.find(&s2[2..]).is_some();
|
||
// Check caller of `find()` is a slice of String case
|
||
let _ = s1[2..].find("world").is_some();
|
||
let _ = s1[2..].find(&s2).is_some();
|
||
let _ = s1[2..].find(&s2[2..]).is_some();
|
||
|
||
// Check that we don't lint if `find()` is called with
|
||
// Pattern that is not a string
|
||
let _ = s1.find(|c: char| c == 'o' || c == 'l').is_some();
|
||
|
||
// Check that we don't lint if the caller is not an `Iterator` or string
|
||
let foo = IteratorFalsePositives { foo: 0 };
|
||
let _ = foo.find().is_some();
|
||
let _ = foo.position().is_some();
|
||
let _ = foo.rposition().is_some();
|
||
}
|
||
|
||
fn main() {
|
||
filter_next();
|
||
search_is_some();
|
||
}
|