rust/compiler
Matthias Krüger 97bacad9c2
Rollup merge of #114256 - Urgau:fix-issue-114180, r=WaffleLapkin
Fix invalid suggestion for mismatched types in closure arguments

This PR fixes the invalid suggestion for mismatched types in closure arguments.

The invalid suggestion came from a wrongly created span in the parser for closure arguments that don't have a type specified. Specifically, the span in this case was the last token span, but in the case of tuples, the span represented the last parenthesis instead of the whole tuple, which is fixed by taking the more accurate span of the pattern.

There is one unfortunate downside of this fix, it worsens even more the diagnostic for mismatched types in closure args without an explicit type. This happens because there is no correct span for implied inferred type. I tried also fixing this but it's a rabbit hole.

Fixes https://github.com/rust-lang/rust/issues/114180
2023-07-30 20:36:35 +02:00
..
rustc inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_abi inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_arena Extend unused_must_use to cover block exprs 2023-06-15 17:59:13 +08:00
rustc_ast Parse generic const items 2023-07-28 22:21:33 +02:00
rustc_ast_lowering Lower generic const items to HIR 2023-07-28 22:21:40 +02:00
rustc_ast_passes inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_ast_pretty Parse generic const items 2023-07-28 22:21:33 +02:00
rustc_attr Add infrastructure #[rustc_confusables] attribute to allow targeted 2023-07-16 19:22:03 +08:00
rustc_baked_icu_data
rustc_borrowck Remove constness from ParamEnv 2023-07-27 15:50:42 +00:00
rustc_builtin_macros inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_codegen_cranelift Merge commit '1eded3619d0e55d57521a259bf27a03906fdfad0' into sync_cg_clif-2023-07-22 2023-07-22 13:32:34 +00:00
rustc_codegen_gcc Auto merge of #113877 - JhonnyBillM:reuse-codegen-ssa-monomorphization-errors-in-gcc, r=davidtwco 2023-07-24 11:29:59 +00:00
rustc_codegen_llvm inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_codegen_ssa inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_const_eval Rollup merge of #113773 - compiler-errors:err-layout-bail, r=cjgillot 2023-07-29 06:13:05 +02:00
rustc_data_structures [rustc][data_structures] Simplify binary_search_slice. 2023-07-29 07:22:56 -07:00
rustc_driver Update rustix 2023-07-03 07:20:51 +00:00
rustc_driver_impl Use a builder instead of boolean/option arguments 2023-07-25 13:51:15 +00:00
rustc_error_codes error/E0691: include alignment in error message 2023-07-21 11:04:16 +02:00
rustc_error_messages inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_errors Rollup merge of #114068 - matthiaskrgr:fmt_args_rustc_1, r=WaffleLapkin 2023-07-30 14:25:09 +02:00
rustc_expand inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_feature Mark lazy_type_alias as incomplete 2023-07-29 19:47:15 +00:00
rustc_fluent_macro Fix diagnostics with errors 2023-05-26 10:44:18 +00:00
rustc_fs_util
rustc_graphviz
rustc_hir Lower generic const items to HIR 2023-07-28 22:21:40 +02:00
rustc_hir_analysis Mark map_or as #[must_use] 2023-07-30 10:22:23 +00:00
rustc_hir_pretty Lower generic const items to HIR 2023-07-28 22:21:40 +02:00
rustc_hir_typeck Rollup merge of #114256 - Urgau:fix-issue-114180, r=WaffleLapkin 2023-07-30 20:36:35 +02:00
rustc_incremental inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_index Re-format let-else per rustfmt update 2023-07-12 21:49:27 -04:00
rustc_infer inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_interface replace atty crate with std's isTerminal 2023-07-26 18:09:50 +03:00
rustc_lexer Auto merge of #113476 - fee1-dead-contrib:c-str-lit, r=petrochenkov 2023-07-25 12:04:34 +00:00
rustc_lint Auto merge of #113422 - Urgau:cast_ref_to_mut-pre-beta, r=Nilstrieb 2023-07-29 07:48:44 +00:00
rustc_lint_defs fix(resolve): update the ambiguity glob binding as warning recursively 2023-07-29 00:19:50 +08:00
rustc_llvm Update the minimum external LLVM to 15 2023-07-27 14:07:08 -07:00
rustc_log inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_macros inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_metadata inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_middle Rollup merge of #114068 - matthiaskrgr:fmt_args_rustc_1, r=WaffleLapkin 2023-07-30 14:25:09 +02:00
rustc_mir_build Lower generic const items to HIR 2023-07-28 22:21:40 +02:00
rustc_mir_dataflow inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_mir_transform inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_monomorphize Rollup merge of #113872 - nnethercote:tweak-cgu-sorting, r=pnkfelix 2023-07-27 06:04:12 +02:00
rustc_parse Rollup merge of #114256 - Urgau:fix-issue-114180, r=WaffleLapkin 2023-07-30 20:36:35 +02:00
rustc_parse_format Fix unit tests 2023-07-19 16:37:09 +00:00
rustc_passes Lower generic const items to HIR 2023-07-28 22:21:40 +02:00
rustc_plugin_impl
rustc_privacy Weaken unnameable_types lint 2023-07-30 14:02:21 +03:00
rustc_query_impl fix couple of clippy findings: 2023-07-23 10:50:14 +02:00
rustc_query_system inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_resolve inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_serialize Upgrade to indexmap 2.0.0 2023-07-03 13:51:54 -07:00
rustc_session inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00
rustc_smir inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_span Auto merge of #114156 - calebzulawski:simd-bswap, r=compiler-errors 2023-07-29 18:51:45 +00:00
rustc_symbol_mangling Auto merge of #113708 - rcvalle:rust-cfi-fix-100778, r=compiler-errors 2023-07-27 02:48:38 +00:00
rustc_target Auto merge of #113411 - unikraft:unikraft, r=wesleywiser 2023-07-25 03:41:56 +00:00
rustc_trait_selection inline format!() args up to and including rustc_codegen_llvm 2023-07-30 14:22:50 +02:00
rustc_traits refactor(rustc_middle): Substs -> GenericArg 2023-07-14 13:27:35 +01:00
rustc_transmute Don't attempt to compute layout of type referencing error 2023-07-27 18:24:08 +00:00
rustc_ty_utils some nits, bless test 2023-07-29 21:29:03 +00:00
rustc_type_ir inline format!() args up to and including rustc_middle 2023-07-30 13:18:33 +02:00