nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 16:54:01 +00:00
Code Issues Packages Projects Releases Wiki Activity
9480314416
rust/compiler/rustc_codegen_ssa
History
bors f206533fd4 Auto merge of #105605 - inquisitivecrystal:attr-validation, r=cjgillot 
Don't perform invalid checks in `codegen_attrs`

The attributes `#[track_caller]` and `#[cmse_nonsecure_entry]` are only valid on functions. When validating one of these attributes, codegen_attrs previously called `fn_sig`, [which can only be used on functions](https://github.com/rust-lang/rust/pull/105201), on the item the attribute was attached to, assuming that the item was a function without checking. This led to [ICEs in situations where the attribute was incorrectly used on non-functions](https://github.com/rust-lang/rust/issues/105594).

With this change, we skip calling `fn_sig` if the item the attribute is attached to must be a function but isn't, because `check_attr` will reject such cases without codegen_attrs's intervention.

As a side note, some of the attributes in codegen_attrs are only valid on functions, but that property isn't actually checked. I'm planning to fix that in a follow up PR since it's a behavior change that will need to be validated rather than an obvious bugfix. Thankfully, all the attributes like that I've found so far are unstable.

Fixes #105594.

r? `@cjgillot`
2022-12-26 09:06:51 +00:00
..
src Auto merge of #105605 - inquisitivecrystal:attr-validation, r=cjgillot 2022-12-26 09:06:51 +00:00
Cargo.toml Rewrite LLVM's archive writer in Rust 2022-11-26 19:35:32 +00:00
README.md mv compiler to compiler/ 2020-08-30 18:45:07 +03:00

README.md

Please read the rustc-dev-guide chapter on Backend Agnostic Codegen.