Matthias Krüger 54bd3a7b8d Rollup merge of #127301 - estebank:fix-suggestions, r=Urgau ... Tweak some structured suggestions to be more verbose and accurate Addressing some issues I found while working on #127282. ``` error: this URL is not a hyperlink --> $DIR/auxiliary/include-str-bare-urls.md:1:11 | LL | HEADS UP! https://example.com MUST SHOW UP IN THE STDERR FILE! | ^^^^^^^^^^^^^^^^^^^ | = note: bare URLs are not automatically turned into clickable links note: the lint level is defined here --> $DIR/include-str-bare-urls.rs:14:9 | LL | #![deny(rustdoc::bare_urls)] | ^^^^^^^^^^^^^^^^^^ help: use an automatic link instead | LL | HEADS UP! <https://example.com> MUST SHOW UP IN THE STDERR FILE! | + + ``` ``` error[E0384]: cannot assign twice to immutable variable `v` --> $DIR/assign-imm-local-twice.rs:7:5 | LL | v = 1; | ----- first assignment to `v` LL | println!("v={}", v); LL | v = 2; | ^^^^^ cannot assign twice to immutable variable | help: consider making this binding mutable | LL | let mut v: isize; | +++ ``` ``` error[E0393]: the type parameter `Rhs` must be explicitly specified --> $DIR/issue-22560.rs:9:23 | LL | trait Sub<Rhs=Self> { | ------------------- type parameter `Rhs` must be specified for this ... LL | type Test = dyn Add + Sub; | ^^^ | = note: because of the default `Self` reference, type parameters must be specified on object types help: set the type parameter to the desired type | LL | type Test = dyn Add + Sub<Rhs>; | +++++ ``` ``` error[E0596]: cannot borrow `v` as mutable, as it is not declared as mutable --> $DIR/issue-33819.rs:4:34 | LL | Some(ref v) => { let a = &mut v; }, | ^^^^^^ cannot borrow as mutable | help: try removing `&mut` here | LL - Some(ref v) => { let a = &mut v; }, LL + Some(ref v) => { let a = v; }, | ``` ``` help: remove the invocation before committing it to a version control system | LL - dbg!(); | ``` ``` error[E0308]: mismatched types --> $DIR/issue-39974.rs:1:21 | LL | const LENGTH: f64 = 2; | ^ expected `f64`, found integer | help: use a float literal | LL | const LENGTH: f64 = 2.0; | ++ ``` ``` error[E0529]: expected an array or slice, found `Vec<i32>` --> $DIR/match-ergonomics.rs:8:9 | LL | [&v] => {}, | ^^^^ pattern cannot match with input type `Vec<i32>` | help: consider slicing here | LL | match x[..] { | ++++ ``` ``` error[E0609]: no field `0` on type `[u32; 1]` --> $DIR/parenthesized-deref-suggestion.rs:10:21 | LL | (x as [u32; 1]).0; | ^ unknown field | help: instead of using tuple indexing, use array indexing | LL | (x as [u32; 1])[0]; | ~ + ```		2024-07-04 18:16:24 +02:00
..
argfile	compiletest: add enable-by-default check-cfg	2024-05-04 11:30:38 +02:00
auxiliary	Rollup merge of #123574 - notriddle:notriddle/issue-d, r=fmease	2024-04-16 15:19:12 +02:00
coverage	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
doctest	Switch back non_local_definitions lint to allow-by-default	2024-06-27 08:05:07 +02:00
error-in-impl-trait	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
generate-link-to-definition	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
intra-doc	rustdoc: point at span in include_str!-ed md file	2024-03-29 13:31:35 -07:00
issues	Auto merge of #124577 - GuillaumeGomez:stabilize-custom_code_classes_in_docs, r=rustdoc	2024-06-01 10:18:01 +00:00
lints	Adjust rustdoc automatic link suggestion	2024-07-04 00:40:04 +00:00
scrape-examples	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
suggestions	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
synthetic-auto-trait-impls	Rollup merge of #123375 - fmease:rustdoc-sati-re-hotfix, r=GuillaumeGomez	2024-04-02 21:22:04 +02:00
ambiguous-inherent-assoc-ty.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
apit-46976.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
bounded-hr-lifetime.rs	Simple modification of diagnostic information	2023-12-21 10:17:11 +08:00
bounded-hr-lifetime.stderr	Simple modification of diagnostic information	2023-12-21 10:17:11 +08:00
check-cfg.rs	Stabilize checking of cfgs at compile-time: --check-cfg option	2024-04-15 21:49:55 +02:00
check-cfg.stderr	Move --check-cfg documentation to stable books	2024-04-15 21:49:56 +02:00
check-doc-alias-attr-location.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
check-doc-alias-attr-location.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
check-doc-alias-attr.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
check-doc-alias-attr.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
circular-intra-doc-link-48414.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
const_arg_in_type_position.rs	rustdoc: run more HIR validation to mirror rustc	2023-03-30 14:55:03 +02:00
const_arg_in_type_position.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
const-evalutation-ice.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
const-evalutation-ice.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
crate-reference-in-block-module.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
crate-reference-in-block-module.stderr	rustdoc: Don't crash on crate references in blocks	2023-03-10 17:49:13 +01:00
custom_code_classes_in_docs-warning3.rs	Stabilize custom_code_classes_in_docs feature	2024-05-01 16:45:27 +02:00
custom_code_classes_in_docs-warning3.stderr	Stabilize custom_code_classes_in_docs feature	2024-05-01 16:45:27 +02:00
deprecated-attrs.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
deprecated-attrs.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
deref-generic.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
diagnostic-width.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
diagnostic-width.stderr	Adjust rustdoc automatic link suggestion	2024-07-04 00:40:04 +00:00
disambiguator-endswith-named-suffix.rs	add test for #126986	2024-06-28 08:01:07 +08:00
disambiguator-endswith-named-suffix.stderr	add test for #126986	2024-06-28 08:01:07 +08:00
disambiguator-macro-endswith-exclamatory.rs	add test for #126986	2024-06-28 08:01:07 +08:00
disambiguator-macro-endswith-exclamatory.stderr	add test for #126986	2024-06-28 08:01:07 +08:00
doc-alias-assoc-const.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-alias-assoc-const.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
doc-alias-crate-level.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-alias-crate-level.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-alias-same-name.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-alias-same-name.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
doc-cfg.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-cfg.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
doc-include-suggestion.rs	Update ui tests	2024-02-29 14:43:43 +01:00
doc-include-suggestion.stderr	Update ui tests	2024-02-29 14:43:43 +01:00
feature-gate-doc_cfg_hide.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
feature-gate-doc_cfg_hide.stderr	Bless tests	2024-01-13 12:46:58 -05:00
hidden-trait-method-34423.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ice-assoc-const-for-primitive-31808.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ice-blanket-impl-52873.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ice-blanket-impl-56701.rs	Move ice tests to rustdoc-ui	2024-04-15 15:11:49 -07:00
ice-blanket-impl-119792.rs	Add a regression test for a former blanket impl synthesis ICE	2024-06-03 03:50:15 +02:00
ice-blanket-impl-selection-55001.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ice-bug-report-url.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ice-bug-report-url.stderr	tests: bless ui and rustdoc-ui tests for ICE messages	2024-04-09 13:58:52 +00:00
ice-cross-crate-opaque-assoc-type-73061.rs	Move ice tests to rustdoc-ui	2024-04-15 15:11:49 -07:00
ignore-block-help.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
ignore-block-help.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
impl-fn-nesting.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
impl-fn-nesting.stderr	Make configure_and_expand "infalllible" by just aborting the compilation if it fails instead of bubbling out an error	2023-02-20 15:28:59 +00:00
include-str-bare-urls.rs	rustdoc: point at span in include_str!-ed md file	2024-03-29 13:31:35 -07:00
include-str-bare-urls.stderr	Adjust rustdoc automatic link suggestion	2024-07-04 00:40:04 +00:00
infinite-recursive-type.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
infinite-recursive-type.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
inherent-assoc-consts-36031.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
invalid_associated_const.rs	Rename HIR TypeBinding to AssocItemConstraint and related cleanup	2024-05-30 22:52:33 +02:00
invalid_associated_const.stderr	Rename HIR TypeBinding to AssocItemConstraint and related cleanup	2024-05-30 22:52:33 +02:00
invalid_const_in_lifetime_position.rs	Accept less invalid Rust in rustdoc	2023-10-31 13:58:03 +00:00
invalid_const_in_lifetime_position.stderr	Accept less invalid Rust in rustdoc	2023-10-31 13:58:03 +00:00
invalid_infered_static_and_const.rs	rustdoc: run more HIR validation to mirror rustc	2023-03-30 14:55:03 +02:00
invalid_infered_static_and_const.stderr	rustdoc: run more HIR validation to mirror rustc	2023-03-30 14:55:03 +02:00
invalid-cfg.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
invalid-cfg.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
invalid-keyword.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
invalid-keyword.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
invalid-redundant-explicit-link.rs	Add regression test for #123158	2024-03-28 11:09:08 +01:00
invalid-syntax.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
invalid-syntax.stderr	rustdoc: point at span in include_str!-ed md file	2024-03-29 13:31:35 -07:00
invalid-theme-name.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
invalid-theme-name.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
issue-102467.rs	Rename HIR TypeBinding to AssocItemConstraint and related cleanup	2024-05-30 22:52:33 +02:00
issue-102467.stderr	Rename HIR TypeBinding to AssocItemConstraint and related cleanup	2024-05-30 22:52:33 +02:00
issue-110629-private-type-cycle-dyn.rs	rustdoc: catch and don't blow up on impl Trait cycles	2023-04-29 16:53:02 -07:00
issue-110629-private-type-cycle-dyn.stderr	Merge collect_mod_item_types query into check_well_formed	2024-03-07 14:26:31 +00:00
issue-110629-private-type-cycle.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
macro-docs.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
macro-docs.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
macro-docs.stdout	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
mismatched_arg_count.rs	rustdoc: remove excess from rustdoc test	2023-03-30 14:55:03 +02:00
mismatched_arg_count.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
nested-extern-crate-46271.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
nested-macro-rules-47639.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
normalize-cycle.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
normalize-in-inlined-type-alias.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
normalize-overflow.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
not-wf-ambiguous-normalization.rs	Merge check_mod_impl_wf and check_mod_type_wf	2024-03-07 06:27:09 +00:00
not-wf-ambiguous-normalization.stderr	Merge check_mod_impl_wf and check_mod_type_wf	2024-03-07 06:27:09 +00:00
output-format-html-stable.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
proc_macro_bug.rs	Test rustdoc encountering proc_macro_derive in a non-proc-macro crate	2023-02-23 09:00:33 +00:00
proc_macro_bug.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
pub-use-primitive-document-private-items-95633.rs	Move tests into appropriate subdirectories	2024-05-21 21:21:26 -07:00
range-pattern.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
recursive-deref-ice.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
redundant-explicit-links-123677.rs	rustdoc: check redundant explicit links with correct itemid	2024-04-13 19:32:39 -07:00
remap-path-prefix-failed-doctest-output.rs	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
remap-path-prefix-failed-doctest-output.stdout	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
remap-path-prefix-invalid-doctest.rs	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
remap-path-prefix-invalid-doctest.stdout	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
remap-path-prefix-passed-doctest-output.rs	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
remap-path-prefix-passed-doctest-output.stdout	rustdoc: Add support for --remap-path-prefix	2024-06-09 10:34:54 -07:00
rustc-check-passes.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
rustc-check-passes.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
search-index-generics-recursion-bug-issue-59502.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
super-glob-40936.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
track-diagnostics.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
track-diagnostics.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
tuple-variadic-check.rs	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
tuple-variadic-check.stderr	Bless rustdoc-ui tests	2023-11-24 19:15:52 +01:00
unable-fulfill-trait.rs	Stop proving outlives constraints on regions we already reported errors on	2024-05-29 09:27:07 +00:00
unable-fulfill-trait.stderr	Stop proving outlives constraints on regions we already reported errors on	2024-05-29 09:27:07 +00:00
unescaped_backticks.rs	Rename HandlerInner::delay_span_bug as HandlerInner::span_delayed_bug.	2023-12-02 09:01:19 +11:00
unescaped_backticks.stderr	rustdoc: point at span in include_str!-ed md file	2024-03-29 13:31:35 -07:00
unportable-markdown.rs	rustdoc: add usable lint for pulldown-cmark-0.11 parsing changes	2024-07-01 07:21:02 -07:00
unportable-markdown.stderr	rustdoc: add usable lint for pulldown-cmark-0.11 parsing changes	2024-07-01 07:21:02 -07:00
unused-extern-crate.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
use_both_out_dir_and_output_options.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00
use_both_out_dir_and_output_options.stderr	Move /src/test to /tests	2023-01-11 09:32:08 +00:00
wasm-safe.rs	[AUTO_GENERATED] Migrate compiletest to use ui_test-style //@ directives	2024-02-22 16:04:04 +00:00