mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-20 11:37:32 +00:00

`MacArgs` is an enum with three variants: `Empty`, `Delimited`, and `Eq`. It's used in two ways: - For representing attribute macro arguments (e.g. in `AttrItem`), where all three variants are used. - For representing function-like macros (e.g. in `MacCall` and `MacroDef`), where only the `Delimited` variant is used. In other words, `MacArgs` is used in two quite different places due to them having partial overlap. I find this makes the code hard to read. It also leads to various unreachable code paths, and allows invalid values (such as accidentally using `MacArgs::Empty` in a `MacCall`). This commit splits `MacArgs` in two: - `DelimArgs` is a new struct just for the "delimited arguments" case. It is now used in `MacCall` and `MacroDef`. - `AttrArgs` is a renaming of the old `MacArgs` enum for the attribute macro case. Its `Delimited` variant now contains a `DelimArgs`. Various other related things are renamed as well. These changes make the code clearer, avoids several unreachable paths, and disallows the invalid values.
179 lines
5.8 KiB
Rust
179 lines
5.8 KiB
Rust
mod context;
|
|
|
|
use crate::edition_panic::use_panic_2021;
|
|
use rustc_ast::ptr::P;
|
|
use rustc_ast::token;
|
|
use rustc_ast::tokenstream::{DelimSpan, TokenStream};
|
|
use rustc_ast::{DelimArgs, Expr, ExprKind, MacCall, MacDelimiter, Path, PathSegment, UnOp};
|
|
use rustc_ast_pretty::pprust;
|
|
use rustc_errors::{Applicability, PResult};
|
|
use rustc_expand::base::{DummyResult, ExtCtxt, MacEager, MacResult};
|
|
use rustc_parse::parser::Parser;
|
|
use rustc_span::symbol::{sym, Ident, Symbol};
|
|
use rustc_span::{Span, DUMMY_SP};
|
|
|
|
pub fn expand_assert<'cx>(
|
|
cx: &'cx mut ExtCtxt<'_>,
|
|
span: Span,
|
|
tts: TokenStream,
|
|
) -> Box<dyn MacResult + 'cx> {
|
|
let Assert { cond_expr, custom_message } = match parse_assert(cx, span, tts) {
|
|
Ok(assert) => assert,
|
|
Err(mut err) => {
|
|
err.emit();
|
|
return DummyResult::any(span);
|
|
}
|
|
};
|
|
|
|
// `core::panic` and `std::panic` are different macros, so we use call-site
|
|
// context to pick up whichever is currently in scope.
|
|
let call_site_span = cx.with_call_site_ctxt(span);
|
|
|
|
let panic_path = || {
|
|
if use_panic_2021(span) {
|
|
// On edition 2021, we always call `$crate::panic::panic_2021!()`.
|
|
Path {
|
|
span: call_site_span,
|
|
segments: cx
|
|
.std_path(&[sym::panic, sym::panic_2021])
|
|
.into_iter()
|
|
.map(|ident| PathSegment::from_ident(ident))
|
|
.collect(),
|
|
tokens: None,
|
|
}
|
|
} else {
|
|
// Before edition 2021, we call `panic!()` unqualified,
|
|
// such that it calls either `std::panic!()` or `core::panic!()`.
|
|
Path::from_ident(Ident::new(sym::panic, call_site_span))
|
|
}
|
|
};
|
|
|
|
// Simply uses the user provided message instead of generating custom outputs
|
|
let expr = if let Some(tokens) = custom_message {
|
|
let then = cx.expr(
|
|
call_site_span,
|
|
ExprKind::MacCall(P(MacCall {
|
|
path: panic_path(),
|
|
args: P(DelimArgs {
|
|
dspan: DelimSpan::from_single(call_site_span),
|
|
delim: MacDelimiter::Parenthesis,
|
|
tokens,
|
|
}),
|
|
prior_type_ascription: None,
|
|
})),
|
|
);
|
|
expr_if_not(cx, call_site_span, cond_expr, then, None)
|
|
}
|
|
// If `generic_assert` is enabled, generates rich captured outputs
|
|
//
|
|
// FIXME(c410-f3r) See https://github.com/rust-lang/rust/issues/96949
|
|
else if let Some(features) = cx.ecfg.features && features.generic_assert {
|
|
context::Context::new(cx, call_site_span).build(cond_expr, panic_path())
|
|
}
|
|
// If `generic_assert` is not enabled, only outputs a literal "assertion failed: ..."
|
|
// string
|
|
else {
|
|
// Pass our own message directly to $crate::panicking::panic(),
|
|
// because it might contain `{` and `}` that should always be
|
|
// passed literally.
|
|
let then = cx.expr_call_global(
|
|
call_site_span,
|
|
cx.std_path(&[sym::panicking, sym::panic]),
|
|
vec![cx.expr_str(
|
|
DUMMY_SP,
|
|
Symbol::intern(&format!(
|
|
"assertion failed: {}",
|
|
pprust::expr_to_string(&cond_expr).escape_debug()
|
|
)),
|
|
)],
|
|
);
|
|
expr_if_not(cx, call_site_span, cond_expr, then, None)
|
|
};
|
|
|
|
MacEager::expr(expr)
|
|
}
|
|
|
|
struct Assert {
|
|
cond_expr: P<Expr>,
|
|
custom_message: Option<TokenStream>,
|
|
}
|
|
|
|
// if !{ ... } { ... } else { ... }
|
|
fn expr_if_not(
|
|
cx: &ExtCtxt<'_>,
|
|
span: Span,
|
|
cond: P<Expr>,
|
|
then: P<Expr>,
|
|
els: Option<P<Expr>>,
|
|
) -> P<Expr> {
|
|
cx.expr_if(span, cx.expr(span, ExprKind::Unary(UnOp::Not, cond)), then, els)
|
|
}
|
|
|
|
fn parse_assert<'a>(cx: &mut ExtCtxt<'a>, sp: Span, stream: TokenStream) -> PResult<'a, Assert> {
|
|
let mut parser = cx.new_parser_from_tts(stream);
|
|
|
|
if parser.token == token::Eof {
|
|
let mut err = cx.struct_span_err(sp, "macro requires a boolean expression as an argument");
|
|
err.span_label(sp, "boolean expression required");
|
|
return Err(err);
|
|
}
|
|
|
|
let cond_expr = parser.parse_expr()?;
|
|
|
|
// Some crates use the `assert!` macro in the following form (note extra semicolon):
|
|
//
|
|
// assert!(
|
|
// my_function();
|
|
// );
|
|
//
|
|
// Emit an error about semicolon and suggest removing it.
|
|
if parser.token == token::Semi {
|
|
let mut err = cx.struct_span_err(sp, "macro requires an expression as an argument");
|
|
err.span_suggestion(
|
|
parser.token.span,
|
|
"try removing semicolon",
|
|
"",
|
|
Applicability::MaybeIncorrect,
|
|
);
|
|
err.emit();
|
|
|
|
parser.bump();
|
|
}
|
|
|
|
// Some crates use the `assert!` macro in the following form (note missing comma before
|
|
// message):
|
|
//
|
|
// assert!(true "error message");
|
|
//
|
|
// Emit an error and suggest inserting a comma.
|
|
let custom_message =
|
|
if let token::Literal(token::Lit { kind: token::Str, .. }) = parser.token.kind {
|
|
let mut err = cx.struct_span_err(parser.token.span, "unexpected string literal");
|
|
let comma_span = parser.prev_token.span.shrink_to_hi();
|
|
err.span_suggestion_short(
|
|
comma_span,
|
|
"try adding a comma",
|
|
", ",
|
|
Applicability::MaybeIncorrect,
|
|
);
|
|
err.emit();
|
|
|
|
parse_custom_message(&mut parser)
|
|
} else if parser.eat(&token::Comma) {
|
|
parse_custom_message(&mut parser)
|
|
} else {
|
|
None
|
|
};
|
|
|
|
if parser.token != token::Eof {
|
|
return parser.unexpected();
|
|
}
|
|
|
|
Ok(Assert { cond_expr, custom_message })
|
|
}
|
|
|
|
fn parse_custom_message(parser: &mut Parser<'_>) -> Option<TokenStream> {
|
|
let ts = parser.parse_tokens();
|
|
if !ts.is_empty() { Some(ts) } else { None }
|
|
}
|