mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-01 20:47:36 +00:00

safe transmute: use `Assume` struct to provide analysis options This task was left as a TODO in #92268; resolving it brings [`BikeshedIntrinsicFrom`](https://doc.rust-lang.org/nightly/core/mem/trait.BikeshedIntrinsicFrom.html) more in line with the API defined in [MCP411](https://github.com/rust-lang/compiler-team/issues/411). **Before:** ```rust pub unsafe trait BikeshedIntrinsicFrom< Src, Context, const ASSUME_ALIGNMENT: bool, const ASSUME_LIFETIMES: bool, const ASSUME_VALIDITY: bool, const ASSUME_VISIBILITY: bool, > where Src: ?Sized, {} ``` **After:** ```rust pub unsafe trait BikeshedIntrinsicFrom<Src, Context, const ASSUME: Assume = { Assume::NOTHING }> where Src: ?Sized, {} ``` `Assume::visibility` has also been renamed to `Assume::safety`, as library safety invariants are what's actually being assumed; visibility is just the mechanism by which it is currently checked (and that may change). r? `@oli-obk` --- Related: - https://github.com/rust-lang/compiler-team/issues/411 - https://github.com/rust-lang/rust/issues/99571
321 lines
12 KiB
Rust
321 lines
12 KiB
Rust
use crate::Map;
|
|
use crate::{Answer, Reason};
|
|
|
|
#[cfg(test)]
|
|
mod tests;
|
|
|
|
mod query_context;
|
|
use query_context::QueryContext;
|
|
|
|
use crate::layout::{self, dfa, Byte, Dfa, Nfa, Tree, Uninhabited};
|
|
pub(crate) struct MaybeTransmutableQuery<L, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
src: L,
|
|
dst: L,
|
|
scope: <C as QueryContext>::Scope,
|
|
assume: crate::Assume,
|
|
context: C,
|
|
}
|
|
|
|
impl<L, C> MaybeTransmutableQuery<L, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
pub(crate) fn new(
|
|
src: L,
|
|
dst: L,
|
|
scope: <C as QueryContext>::Scope,
|
|
assume: crate::Assume,
|
|
context: C,
|
|
) -> Self {
|
|
Self { src, dst, scope, assume, context }
|
|
}
|
|
|
|
pub(crate) fn map_layouts<F, M>(
|
|
self,
|
|
f: F,
|
|
) -> Result<MaybeTransmutableQuery<M, C>, Answer<<C as QueryContext>::Ref>>
|
|
where
|
|
F: FnOnce(
|
|
L,
|
|
L,
|
|
<C as QueryContext>::Scope,
|
|
&C,
|
|
) -> Result<(M, M), Answer<<C as QueryContext>::Ref>>,
|
|
{
|
|
let Self { src, dst, scope, assume, context } = self;
|
|
|
|
let (src, dst) = f(src, dst, scope, &context)?;
|
|
|
|
Ok(MaybeTransmutableQuery { src, dst, scope, assume, context })
|
|
}
|
|
}
|
|
|
|
#[cfg(feature = "rustc")]
|
|
mod rustc {
|
|
use super::*;
|
|
use crate::layout::tree::Err;
|
|
|
|
use rustc_middle::ty::Ty;
|
|
use rustc_middle::ty::TyCtxt;
|
|
|
|
impl<'tcx> MaybeTransmutableQuery<Ty<'tcx>, TyCtxt<'tcx>> {
|
|
/// This method begins by converting `src` and `dst` from `Ty`s to `Tree`s,
|
|
/// then computes an answer using those trees.
|
|
#[instrument(level = "debug", skip(self), fields(src = ?self.src, dst = ?self.dst))]
|
|
pub fn answer(self) -> Answer<<TyCtxt<'tcx> as QueryContext>::Ref> {
|
|
let query_or_answer = self.map_layouts(|src, dst, scope, &context| {
|
|
// Convert `src` and `dst` from their rustc representations, to `Tree`-based
|
|
// representations. If these conversions fail, conclude that the transmutation is
|
|
// unacceptable; the layouts of both the source and destination types must be
|
|
// well-defined.
|
|
let src = Tree::from_ty(src, context).map_err(|err| match err {
|
|
// Answer `Yes` here, because "Unknown Type" will already be reported by
|
|
// rustc. No need to spam the user with more errors.
|
|
Err::Unknown => Answer::Yes,
|
|
Err::Unspecified => Answer::No(Reason::SrcIsUnspecified),
|
|
})?;
|
|
|
|
let dst = Tree::from_ty(dst, context).map_err(|err| match err {
|
|
Err::Unknown => Answer::Yes,
|
|
Err::Unspecified => Answer::No(Reason::DstIsUnspecified),
|
|
})?;
|
|
|
|
Ok((src, dst))
|
|
});
|
|
|
|
match query_or_answer {
|
|
Ok(query) => query.answer(),
|
|
Err(answer) => answer,
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<C> MaybeTransmutableQuery<Tree<<C as QueryContext>::Def, <C as QueryContext>::Ref>, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
/// Answers whether a `Tree` is transmutable into another `Tree`.
|
|
///
|
|
/// This method begins by de-def'ing `src` and `dst`, and prunes private paths from `dst`,
|
|
/// then converts `src` and `dst` to `Nfa`s, and computes an answer using those NFAs.
|
|
#[inline(always)]
|
|
#[instrument(level = "debug", skip(self), fields(src = ?self.src, dst = ?self.dst))]
|
|
pub(crate) fn answer(self) -> Answer<<C as QueryContext>::Ref> {
|
|
let assume_visibility = self.assume.safety;
|
|
let query_or_answer = self.map_layouts(|src, dst, scope, context| {
|
|
// Remove all `Def` nodes from `src`, without checking their visibility.
|
|
let src = src.prune(&|def| true);
|
|
|
|
trace!(?src, "pruned src");
|
|
|
|
// Remove all `Def` nodes from `dst`, additionally...
|
|
let dst = if assume_visibility {
|
|
// ...if visibility is assumed, don't check their visibility.
|
|
dst.prune(&|def| true)
|
|
} else {
|
|
// ...otherwise, prune away all unreachable paths through the `Dst` layout.
|
|
dst.prune(&|def| context.is_accessible_from(def, scope))
|
|
};
|
|
|
|
trace!(?dst, "pruned dst");
|
|
|
|
// Convert `src` from a tree-based representation to an NFA-based representation.
|
|
// If the conversion fails because `src` is uninhabited, conclude that the transmutation
|
|
// is acceptable, because instances of the `src` type do not exist.
|
|
let src = Nfa::from_tree(src).map_err(|Uninhabited| Answer::Yes)?;
|
|
|
|
// Convert `dst` from a tree-based representation to an NFA-based representation.
|
|
// If the conversion fails because `src` is uninhabited, conclude that the transmutation
|
|
// is unacceptable, because instances of the `dst` type do not exist.
|
|
let dst =
|
|
Nfa::from_tree(dst).map_err(|Uninhabited| Answer::No(Reason::DstIsPrivate))?;
|
|
|
|
Ok((src, dst))
|
|
});
|
|
|
|
match query_or_answer {
|
|
Ok(query) => query.answer(),
|
|
Err(answer) => answer,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<C> MaybeTransmutableQuery<Nfa<<C as QueryContext>::Ref>, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
/// Answers whether a `Nfa` is transmutable into another `Nfa`.
|
|
///
|
|
/// This method converts `src` and `dst` to DFAs, then computes an answer using those DFAs.
|
|
#[inline(always)]
|
|
#[instrument(level = "debug", skip(self), fields(src = ?self.src, dst = ?self.dst))]
|
|
pub(crate) fn answer(self) -> Answer<<C as QueryContext>::Ref> {
|
|
let query_or_answer = self
|
|
.map_layouts(|src, dst, scope, context| Ok((Dfa::from_nfa(src), Dfa::from_nfa(dst))));
|
|
|
|
match query_or_answer {
|
|
Ok(query) => query.answer(),
|
|
Err(answer) => answer,
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<C> MaybeTransmutableQuery<Dfa<<C as QueryContext>::Ref>, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
/// Answers whether a `Nfa` is transmutable into another `Nfa`.
|
|
///
|
|
/// This method converts `src` and `dst` to DFAs, then computes an answer using those DFAs.
|
|
pub(crate) fn answer(self) -> Answer<<C as QueryContext>::Ref> {
|
|
MaybeTransmutableQuery {
|
|
src: &self.src,
|
|
dst: &self.dst,
|
|
scope: self.scope,
|
|
assume: self.assume,
|
|
context: self.context,
|
|
}
|
|
.answer()
|
|
}
|
|
}
|
|
|
|
impl<'l, C> MaybeTransmutableQuery<&'l Dfa<<C as QueryContext>::Ref>, C>
|
|
where
|
|
C: QueryContext,
|
|
{
|
|
pub(crate) fn answer(&mut self) -> Answer<<C as QueryContext>::Ref> {
|
|
self.answer_memo(&mut Map::default(), self.src.start, self.dst.start)
|
|
}
|
|
|
|
#[inline(always)]
|
|
#[instrument(level = "debug", skip(self))]
|
|
fn answer_memo(
|
|
&self,
|
|
cache: &mut Map<(dfa::State, dfa::State), Answer<<C as QueryContext>::Ref>>,
|
|
src_state: dfa::State,
|
|
dst_state: dfa::State,
|
|
) -> Answer<<C as QueryContext>::Ref> {
|
|
if let Some(answer) = cache.get(&(src_state, dst_state)) {
|
|
answer.clone()
|
|
} else {
|
|
let answer = if dst_state == self.dst.accepting {
|
|
// truncation: `size_of(Src) >= size_of(Dst)`
|
|
Answer::Yes
|
|
} else if src_state == self.src.accepting {
|
|
// extension: `size_of(Src) >= size_of(Dst)`
|
|
if let Some(dst_state_prime) = self.dst.byte_from(dst_state, Byte::Uninit) {
|
|
self.answer_memo(cache, src_state, dst_state_prime)
|
|
} else {
|
|
Answer::No(Reason::DstIsTooBig)
|
|
}
|
|
} else {
|
|
let src_quantification = if self.assume.validity {
|
|
// if the compiler may assume that the programmer is doing additional validity checks,
|
|
// (e.g.: that `src != 3u8` when the destination type is `bool`)
|
|
// then there must exist at least one transition out of `src_state` such that the transmute is viable...
|
|
there_exists
|
|
} else {
|
|
// if the compiler cannot assume that the programmer is doing additional validity checks,
|
|
// then for all transitions out of `src_state`, such that the transmute is viable...
|
|
// then there must exist at least one transition out of `src_state` such that the transmute is viable...
|
|
for_all
|
|
};
|
|
|
|
src_quantification(
|
|
self.src.bytes_from(src_state).unwrap_or(&Map::default()),
|
|
|(&src_validity, &src_state_prime)| {
|
|
if let Some(dst_state_prime) = self.dst.byte_from(dst_state, src_validity) {
|
|
self.answer_memo(cache, src_state_prime, dst_state_prime)
|
|
} else if let Some(dst_state_prime) =
|
|
self.dst.byte_from(dst_state, Byte::Uninit)
|
|
{
|
|
self.answer_memo(cache, src_state_prime, dst_state_prime)
|
|
} else {
|
|
Answer::No(Reason::DstIsBitIncompatible)
|
|
}
|
|
},
|
|
)
|
|
};
|
|
cache.insert((src_state, dst_state), answer.clone());
|
|
answer
|
|
}
|
|
}
|
|
}
|
|
|
|
impl<R> Answer<R>
|
|
where
|
|
R: layout::Ref,
|
|
{
|
|
pub(crate) fn and(self, rhs: Self) -> Self {
|
|
match (self, rhs) {
|
|
(Self::No(reason), _) | (_, Self::No(reason)) => Self::No(reason),
|
|
(Self::Yes, Self::Yes) => Self::Yes,
|
|
(Self::IfAll(mut lhs), Self::IfAll(ref mut rhs)) => {
|
|
lhs.append(rhs);
|
|
Self::IfAll(lhs)
|
|
}
|
|
(constraint, Self::IfAll(mut constraints))
|
|
| (Self::IfAll(mut constraints), constraint) => {
|
|
constraints.push(constraint);
|
|
Self::IfAll(constraints)
|
|
}
|
|
(lhs, rhs) => Self::IfAll(vec![lhs, rhs]),
|
|
}
|
|
}
|
|
|
|
pub(crate) fn or(self, rhs: Self) -> Self {
|
|
match (self, rhs) {
|
|
(Self::Yes, _) | (_, Self::Yes) => Self::Yes,
|
|
(Self::No(lhr), Self::No(rhr)) => Self::No(lhr),
|
|
(Self::IfAny(mut lhs), Self::IfAny(ref mut rhs)) => {
|
|
lhs.append(rhs);
|
|
Self::IfAny(lhs)
|
|
}
|
|
(constraint, Self::IfAny(mut constraints))
|
|
| (Self::IfAny(mut constraints), constraint) => {
|
|
constraints.push(constraint);
|
|
Self::IfAny(constraints)
|
|
}
|
|
(lhs, rhs) => Self::IfAny(vec![lhs, rhs]),
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn for_all<R, I, F>(iter: I, f: F) -> Answer<R>
|
|
where
|
|
R: layout::Ref,
|
|
I: IntoIterator,
|
|
F: FnMut(<I as IntoIterator>::Item) -> Answer<R>,
|
|
{
|
|
use std::ops::ControlFlow::{Break, Continue};
|
|
let (Continue(result) | Break(result)) =
|
|
iter.into_iter().map(f).try_fold(Answer::Yes, |constraints, constraint| {
|
|
match constraint.and(constraints) {
|
|
Answer::No(reason) => Break(Answer::No(reason)),
|
|
maybe => Continue(maybe),
|
|
}
|
|
});
|
|
result
|
|
}
|
|
|
|
pub fn there_exists<R, I, F>(iter: I, f: F) -> Answer<R>
|
|
where
|
|
R: layout::Ref,
|
|
I: IntoIterator,
|
|
F: FnMut(<I as IntoIterator>::Item) -> Answer<R>,
|
|
{
|
|
use std::ops::ControlFlow::{Break, Continue};
|
|
let (Continue(result) | Break(result)) = iter.into_iter().map(f).try_fold(
|
|
Answer::No(Reason::DstIsBitIncompatible),
|
|
|constraints, constraint| match constraint.or(constraints) {
|
|
Answer::Yes => Break(Answer::Yes),
|
|
maybe => Continue(maybe),
|
|
},
|
|
);
|
|
result
|
|
}
|