mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
883bdb7fda
This is weird: `HandlerInner::emit` calls `HandlerInner::emit_diagnostic`, but only after doing a `treat-err-as-bug` check. Which is fine, *except* that there are multiple others paths for an `Error` or `Fatal` diagnostic to be passed to `HandlerInner::emit_diagnostic` without going through `HandlerInner::emit`, e.g. `Handler::span_err` call `Handler::emit_diag_at_span`, which calls `emit_diagnostic`. So that suggests that the coverage for `treat-err-as-bug` is incomplete. This commit removes `HandlerInner::emit` and moves the `treat-err-as-bug` check to `HandlerInner::emit_diagnostic`, so it cannot by bypassed. |
||
|---|---|---|
| .. | ||
| json | ||
| markdown | ||
| annotate_snippet_emitter_writer.rs | ||
| diagnostic_builder.rs | ||
| diagnostic_impls.rs | ||
| diagnostic.rs | ||
| emitter.rs | ||
| error.rs | ||
| json.rs | ||
| lib.rs | ||
| lock.rs | ||
| registry.rs | ||
| snippet.rs | ||
| styled_buffer.rs | ||
| tests.rs | ||
| translation.rs | ||