mirror of
https://github.com/rust-lang/rust.git
synced 2025-04-29 19:47:38 +00:00
ef1114a964
The one notable test change is `tests/ui/macros/trace_faulty_macros.rs`. This commit removes the complicated `Interpolated` handling in `expected_expression_found` that results in a longer error message. But I think the new, shorter message is actually an improvement. The original complaint was in #71039, when the error message started with "error: expected expression, found `1 + 1`". That was confusing because `1 + 1` is an expression. Other than that, the reporter said "the whole error message is not too bad if you ignore the first line". Subsequently, extra complexity and wording was added to the error message. But I don't think the extra wording actually helps all that much. In particular, it still says of the `1+1` that "this is expected to be expression". This repeats the problem from the original complaint! This commit removes the extra complexity, reverting to a simpler error message. This is primarily because the traversal is a pain without `Interpolated` tokens. Nonetheless, I think the error message is *improved*. It now starts with "expected expression, found `pat` metavariable", which is much clearer and the real problem. It also doesn't say anything specific about `1+1`, which is good, because the `1+1` isn't really relevant to the error -- it's the `$e:pat` that's important.
53 lines
1.7 KiB
Rust
53 lines
1.7 KiB
Rust
// Can't put mut in non-ident pattern
|
|
|
|
//@ edition:2018
|
|
|
|
#![feature(box_patterns)]
|
|
#![allow(warnings)]
|
|
|
|
pub fn main() {
|
|
let mut _ = 0; //~ ERROR `mut` must be followed by a named binding
|
|
let mut (_, _) = (0, 0); //~ ERROR `mut` must be followed by a named binding
|
|
|
|
let mut (x @ y) = 0; //~ ERROR `mut` must be attached to each individual binding
|
|
|
|
let mut mut x = 0;
|
|
//~^ ERROR `mut` on a binding may not be repeated
|
|
//~| remove the additional `mut`s
|
|
|
|
let mut mut mut mut mut x = 0;
|
|
//~^ ERROR `mut` on a binding may not be repeated
|
|
//~| remove the additional `mut`s
|
|
|
|
struct Foo { x: isize }
|
|
let mut Foo { x: x } = Foo { x: 3 };
|
|
//~^ ERROR `mut` must be attached to each individual binding
|
|
//~| add `mut` to each binding
|
|
|
|
let mut Foo { x } = Foo { x: 3 };
|
|
//~^ ERROR `mut` must be attached to each individual binding
|
|
//~| add `mut` to each binding
|
|
|
|
struct r#yield(u8, u8);
|
|
let mut mut yield(become, await) = r#yield(0, 0);
|
|
//~^ ERROR `mut` on a binding may not be repeated
|
|
//~| ERROR `mut` must be followed by a named binding
|
|
//~| ERROR expected identifier, found reserved keyword `yield`
|
|
//~| ERROR expected identifier, found reserved keyword `become`
|
|
//~| ERROR expected identifier, found keyword `await`
|
|
|
|
struct W<T, U>(T, U);
|
|
struct B { f: Box<u8> }
|
|
let mut W(mut a, W(b, W(ref c, W(d, B { box f }))))
|
|
//~^ ERROR `mut` must be attached to each individual binding
|
|
= W(0, W(1, W(2, W(3, B { f: Box::new(4u8) }))));
|
|
|
|
// Make sure we don't accidentally allow `mut $p` where `$p:pat`.
|
|
macro_rules! foo {
|
|
($p:pat) => {
|
|
let mut $p = 0; //~ ERROR expected identifier, found metavariable
|
|
}
|
|
}
|
|
foo!(x);
|
|
}
|