mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-29 02:03:53 +00:00
b6c87c555f
This attempts to bring better error messages to invalid method calls, by applying some heuristics to identify common mistakes. The algorithm is inspired by Levenshtein distance and longest common sub-sequence. In essence, we treat the types of the function, and the types of the arguments you provided as two "words" and compute the edits to get from one to the other. We then modify that algorithm to detect 4 cases: - A function input is missing - An extra argument was provided - The type of an argument is straight up invalid - Two arguments have been swapped - A subset of the arguments have been shuffled (We detect the last two as separate cases so that we can detect two swaps, instead of 4 parameters permuted.) It helps to understand this argument by paying special attention to terminology: "inputs" refers to the inputs being *expected* by the function, and "arguments" refers to what has been provided at the call site. The basic sketch of the algorithm is as follows: - Construct a boolean grid, with a row for each argument, and a column for each input. The cell [i, j] is true if the i'th argument could satisfy the j'th input. - If we find an argument that could satisfy no inputs, provided for an input that can't be satisfied by any other argument, we consider this an "invalid type". - Extra arguments are those that can't satisfy any input, provided for an input that *could* be satisfied by another argument. - Missing inputs are inputs that can't be satisfied by any argument, where the provided argument could satisfy another input - Swapped / Permuted arguments are identified with a cycle detection algorithm. As each issue is found, we remove the relevant inputs / arguments and check for more issues. If we find no issues, we match up any "valid" arguments, and start again. Note that there's a lot of extra complexity: - We try to stay efficient on the happy path, only computing the diagonal until we find a problem, and then filling in the rest of the matrix. - Closure arguments are wrapped in a tuple and need to be unwrapped - We need to resolve closure types after the rest, to allow the most specific type constraints - We need to handle imported C functions that might be variadic in their inputs. I tried to document a lot of this in comments in the code and keep the naming clear. |
||
|---|---|---|
| .. | ||
| format-args-capture-issue-93378.rs | ||
| format-args-capture-issue-93378.stderr | ||
| format-args-capture-issue-94010.rs | ||
| format-args-capture-issue-94010.stderr | ||
| format-args-capture-macro-hygiene.rs | ||
| format-args-capture-macro-hygiene.stderr | ||
| format-args-capture-missing-variables.rs | ||
| format-args-capture-missing-variables.stderr | ||
| format-args-capture.rs | ||
| format-concat-span.rs | ||
| format-concat-span.stderr | ||
| format-string-error-2.rs | ||
| format-string-error-2.stderr | ||
| format-string-error.rs | ||
| format-string-error.stderr | ||
| format-with-yield-point.rs | ||
| ifmt-bad-arg.rs | ||
| ifmt-bad-arg.stderr | ||
| ifmt-bad-format-args.rs | ||
| ifmt-bad-format-args.stderr | ||
| ifmt-unimpl.rs | ||
| ifmt-unimpl.stderr | ||
| ifmt-unknown-trait.rs | ||
| ifmt-unknown-trait.stderr | ||
| incorrect-separator.rs | ||
| incorrect-separator.stderr | ||
| issue-86085.rs | ||
| issue-86085.stderr | ||
| issue-89173.rs | ||
| issue-89173.stderr | ||
| issue-91556.rs | ||
| issue-91556.stderr | ||
| send-sync.rs | ||
| send-sync.stderr | ||