mirror of
https://github.com/rust-lang/rust.git
synced 2025-02-21 11:23:03 +00:00
7fb81229d3
Fix `VecDeque::shrink_to` UB when `handle_alloc_error` unwinds. Fixes #123369 For `VecDeque` it's relatively simple to restore the buffer into a consistent state so this PR does just that. Note that with its current implementation, `shrink_to` may change the internal arrangement of elements in the buffer, so e.g. `[D, <uninit>, A, B, C]` will become `[<uninit>, A, B, C, D]` and `[<uninit>, <uninit>, A, B, C]` may become `[B, C, <uninit>, <uninit>, A]` if `shrink_to` unwinds. This shouldn't be an issue though as we don't make any guarantees about the stability of the internal buffer arrangement (and this case is impossible to hit on stable anyways). This PR also includes a test with code adapted from #123369 which fails without the new `shrink_to` code. Does this suffice or do we maybe need more exhaustive tests like in #108475? cc `@Amanieu` `@rustbot` label +T-libs |
||
|---|---|---|
| .. | ||
| arc.rs | ||
| autotraits.rs | ||
| borrow.rs | ||
| boxed.rs | ||
| btree_set_hash.rs | ||
| c_str.rs | ||
| const_fns.rs | ||
| cow_str.rs | ||
| fmt.rs | ||
| heap.rs | ||
| lib.rs | ||
| linked_list.rs | ||
| rc.rs | ||
| slice.rs | ||
| str.rs | ||
| string.rs | ||
| task.rs | ||
| thin_box.rs | ||
| vec_deque_alloc_error.rs | ||
| vec_deque.rs | ||
| vec.rs | ||