nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-24 07:44:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
7fb36f2d3b
rust/tests/ui/pattern
History
Matthias Krüger 7fb36f2d3b
Rollup merge of #120214 - Nadrieril:fix-120210, r=pnkfelix 
match lowering: consistently lower bindings deepest-first

Currently when lowering match expressions to MIR, we do a funny little dance with the order of bindings. I attempt to explain it in the third commit: we handle refutable (i.e. needing a test) patterns differently than irrefutable ones. This leads to inconsistencies, as reported in https://github.com/rust-lang/rust/issues/120210. The reason we need a dance at all is for situations like:

```rust
fn foo1(x: NonCopyStruct) {
    let y @ NonCopyStruct { copy_field: z } = x;
    // the above should turn into
    let z = x.copy_field;
    let y = x;
}
```

Here the `y ```````@```````` binding will move out of `x`, so we need to copy the field first.

I believe that the inconsistency came about when we fixed https://github.com/rust-lang/rust/issues/69971, and didn't notice that the fix didn't extend to refutable patterns. My guess then is that ordering bindings by "deepest-first, otherwise source order" is a sound choice. This PR implements that (at least I hope, match lowering is hard to follow 🥲).

Fixes https://github.com/rust-lang/rust/issues/120210

r? ```````@oli-obk``````` since you merged the original fix to https://github.com/rust-lang/rust/issues/69971
cc ```````@matthewjasper```````
2024-02-08 09:06:33 +01:00
..
auxiliary
bindings-after-at Put new bindings first in refutable cases too 2024-01-25 02:56:02 +01:00
move-ref-patterns Show number in error message even for one error 2023-11-24 19:15:52 +01:00
usefulness update the tracking issue for structural match violations 2024-02-05 20:36:11 +01:00
byte-string-inference.rs Revert "Structurally resolve correctly in check_pat_lit" 2023-06-24 18:41:27 +00:00
for-loop-bad-item.rs
for-loop-bad-item.stderr Modify primary span label for E0308 2023-01-30 20:12:19 +00:00
ignore-all-the-things.rs
incorrect-placement-of-pattern-modifiers.fixed Account for ref and mut in the wrong place for pattern ident renaming 2023-10-30 00:15:49 +00:00
incorrect-placement-of-pattern-modifiers.rs Account for ref and mut in the wrong place for pattern ident renaming 2023-10-30 00:15:49 +00:00
incorrect-placement-of-pattern-modifiers.stderr Account for ref and mut in the wrong place for pattern ident renaming 2023-10-30 00:15:49 +00:00
integer-range-binding.rs
issue-6449.rs
issue-8351-1.rs
issue-8351-2.rs
issue-10392.rs
issue-11577.rs
issue-12582.rs
issue-14221.rs Change bindings_with_variant_name to deny-by-default 2023-01-20 02:26:12 -05:00
issue-14221.stderr Change bindings_with_variant_name to deny-by-default 2023-01-20 02:26:12 -05:00
issue-15080.rs
issue-17718-patterns.rs
issue-17718-patterns.stderr
issue-22546.rs Update tests 2024-02-07 10:42:01 +08:00
issue-22546.stderr Update tests 2024-02-07 10:42:01 +08:00
issue-27320.rs
issue-52240.rs
issue-52240.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-66270-pat-struct-parser-recovery.rs
issue-66270-pat-struct-parser-recovery.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-67037-pat-tup-scrut-ty-diff-less-fields.rs
issue-67037-pat-tup-scrut-ty-diff-less-fields.stderr Modify primary span label for E0308 2023-01-30 20:12:19 +00:00
issue-67776-match-same-name-enum-variant-refs.rs Change bindings_with_variant_name to deny-by-default 2023-01-20 02:26:12 -05:00
issue-67776-match-same-name-enum-variant-refs.stderr Change bindings_with_variant_name to deny-by-default 2023-01-20 02:26:12 -05:00
issue-68393-let-pat-assoc-constant.rs
issue-68393-let-pat-assoc-constant.stderr Perform match checking on THIR. 2023-04-03 15:59:21 +00:00
issue-72565.rs Avoid emitting the non_exhaustive error if other errors already occurred 2023-10-11 12:49:57 +00:00
issue-72565.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-72574-1.rs
issue-72574-1.stderr
issue-72574-2.rs
issue-72574-2.stderr
issue-74539.rs
issue-74539.stderr
issue-74702.rs
issue-74702.stderr
issue-74954.rs
issue-80186-mut-binding-help-suggestion.rs
issue-80186-mut-binding-help-suggestion.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-88074-pat-range-type-inference-err.rs
issue-88074-pat-range-type-inference-err.stderr
issue-88074-pat-range-type-inference.rs
issue-92074-macro-ice.rs
issue-92074-macro-ice.stderr
issue-94866.rs Move tests 2023-05-24 19:35:59 -03:00
issue-94866.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-95878.rs
issue-95878.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-106552.rs
issue-106552.stderr Perform match checking on THIR. 2023-04-03 15:59:21 +00:00
issue-106862.fixed error-msg: impl better suggestion for E0532 2023-03-15 22:19:54 +13:00
issue-106862.rs error-msg: impl better suggestion for E0532 2023-03-15 22:19:54 +13:00
issue-106862.stderr error-msg: impl better suggestion for E0532 2023-03-15 22:19:54 +13:00
issue-110508.rs add regression test 2023-07-01 02:28:15 -04:00
issue-114896.rs fixes #114896 2023-09-07 11:07:33 +08:00
issue-114896.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
issue-115599.rs remove StructuralEq trait 2024-01-24 07:56:23 +01:00
issue-115599.stderr remove StructuralEq trait 2024-01-24 07:56:23 +01:00
issue-117626.rs add test for #117626 2023-12-29 01:13:54 +08:00
non-constant-in-const-path.rs
non-constant-in-const-path.stderr
non-structural-match-types.rs #![feature(inline_const_pat)] is no longer incomplete 2024-02-01 10:27:54 +00:00
non-structural-match-types.stderr #![feature(inline_const_pat)] is no longer incomplete 2024-02-01 10:27:54 +00:00
pat-shadow-in-nested-binding.rs
pat-shadow-in-nested-binding.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
pat-struct-field-expr-has-type.rs
pat-struct-field-expr-has-type.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
pat-tuple-bad-type.rs
pat-tuple-bad-type.stderr
pat-tuple-field-count-cross.rs
pat-tuple-field-count-cross.stderr resolve: Remove struct_field_names_untracked 2023-03-13 17:31:55 +04:00
pat-tuple-overfield.rs
pat-tuple-overfield.stderr
pat-tuple-underfield.rs
pat-tuple-underfield.stderr
pat-type-err-formal-param.rs
pat-type-err-formal-param.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
pat-type-err-let-stmt.rs
pat-type-err-let-stmt.stderr Modify primary span label for E0308 2023-01-30 20:12:19 +00:00
patkind-litrange-no-expr.rs
patkind-litrange-no-expr.stderr Add a note to duplicate diagnostics 2023-10-05 01:04:41 +00:00
pattern-bad-ref-box-order.fixed Suggest swapping the order of ref and box 2023-11-27 21:38:19 +09:00
pattern-bad-ref-box-order.rs Suggest swapping the order of ref and box 2023-11-27 21:38:19 +09:00
pattern-bad-ref-box-order.stderr Suggest swapping the order of ref and box 2023-11-27 21:38:19 +09:00
pattern-binding-disambiguation.rs
pattern-binding-disambiguation.stderr
pattern-error-continue.rs Modify primary span label for E0308 2023-01-30 20:12:19 +00:00
pattern-error-continue.stderr refactor(resolve): clean up the early error return caused by non-call 2023-05-10 22:35:01 +08:00
pattern-ident-path-generics.rs
pattern-ident-path-generics.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
pattern-tyvar-2.rs
pattern-tyvar-2.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
pattern-tyvar.rs
pattern-tyvar.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
range-pattern-meant-to-be-slice-rest-pattern.rs Suggest [tail @ ..] on [..tail] and [...tail] where tail is unresolved 2024-02-04 22:16:21 +01:00
range-pattern-meant-to-be-slice-rest-pattern.stderr Suggest [tail @ ..] on [..tail] and [...tail] where tail is unresolved 2024-02-04 22:16:21 +01:00
rest-pat-semantic-disallowed.rs
rest-pat-semantic-disallowed.stderr
rest-pat-syntactic.rs
rest-pat-syntactic.stderr Bless tests 2024-01-13 12:46:58 -05:00
size-and-align.rs
slice-array-infer.rs add more tests 2023-07-17 22:06:32 +00:00
slice-pattern-refutable.rs address review 2023-07-17 22:06:32 +00:00
slice-pattern-refutable.stderr address review 2023-07-17 22:06:32 +00:00
slice-patterns-ambiguity.rs add tests for refutable patterns 2023-07-17 22:02:09 +00:00
slice-patterns-ambiguity.stderr add tests for refutable patterns 2023-07-17 22:02:09 +00:00
slice-patterns-irrefutable.rs address review 2023-07-28 11:20:11 +00:00
slice-patterns-irrefutable.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00
slice-patterns-nested.rs add test for nested pattern 2023-07-17 22:06:32 +00:00
suggest-adding-appropriate-missing-pattern-excluding-comments.fixed Perform match checking on THIR. 2023-04-03 15:59:21 +00:00
suggest-adding-appropriate-missing-pattern-excluding-comments.rs
suggest-adding-appropriate-missing-pattern-excluding-comments.stderr Show number in error message even for one error 2023-11-24 19:15:52 +01:00