mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-23 15:23:46 +00:00
98cfed7b97
When encountering a move error, look for implementations of `Clone` for the moved type. If there is one, check if all its obligations are met. If they are, we suggest cloning without caveats. If they aren't, we suggest cloning while mentioning the unmet obligations, potentially suggesting `#[derive(Clone)]` when appropriate. ``` error[E0507]: cannot move out of a shared reference --> $DIR/suggest-clone-when-some-obligation-is-unmet.rs:20:28 | LL | let mut copy: Vec<U> = map.clone().into_values().collect(); | ^^^^^^^^^^^ ------------- value moved due to this method call | | | move occurs because value has type `HashMap<T, U, Hash128_1>`, which does not implement the `Copy` trait | note: `HashMap::<K, V, S>::into_values` takes ownership of the receiver `self`, which moves value --> $SRC_DIR/std/src/collections/hash/map.rs:LL:COL help: you could `clone` the value and consume it, if the `Hash128_1: Clone` trait bound could be satisfied | LL | let mut copy: Vec<U> = <HashMap<T, U, Hash128_1> as Clone>::clone(&map.clone()).into_values().collect(); | ++++++++++++++++++++++++++++++++++++++++++++ + help: consider annotating `Hash128_1` with `#[derive(Clone)]` | LL + #[derive(Clone)] LL | pub struct Hash128_1; | ``` Fix #109429.
28 lines
624 B
Rust
28 lines
624 B
Rust
// run-rustfix
|
|
// Issue #109429
|
|
use std::collections::hash_map::DefaultHasher;
|
|
use std::collections::HashMap;
|
|
use std::hash::BuildHasher;
|
|
use std::hash::Hash;
|
|
|
|
pub struct Hash128_1;
|
|
|
|
impl BuildHasher for Hash128_1 {
|
|
type Hasher = DefaultHasher;
|
|
fn build_hasher(&self) -> DefaultHasher { DefaultHasher::default() }
|
|
}
|
|
|
|
#[allow(unused)]
|
|
pub fn hashmap_copy<T, U>(
|
|
map: &HashMap<T, U, Hash128_1>,
|
|
) where T: Hash + Clone, U: Clone
|
|
{
|
|
let mut copy: Vec<U> = map.clone().into_values().collect(); //~ ERROR
|
|
}
|
|
|
|
pub fn make_map() -> HashMap<String, i64, Hash128_1>
|
|
{
|
|
HashMap::with_hasher(Hash128_1)
|
|
}
|
|
fn main() {}
|