Esteban Küber 7d4d09eeeb Shorten span of panic failures in const context ... Previously, we included a redundant prefix on the panic message and a postfix of the location of the panic. The prefix didn't carry any additional information beyond "something failed", and the location of the panic is redundant with the diagnostic's span, which gets printed out even if its code is not shown. ``` error[E0080]: evaluation of constant value failed --> $DIR/assert-type-intrinsics.rs:11:9 | LL | MaybeUninit::<!>::uninit().assume_init(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ evaluation panicked: aborted execution: attempted to instantiate uninhabited type `!` ``` ``` error[E0080]: evaluation of `Fail::<i32>::C` failed --> $DIR/collect-in-dead-closure.rs:9:19 | LL | const C: () = panic!(); | ^^^^^^^^ evaluation panicked: explicit panic | = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ``` ``` error[E0080]: evaluation of constant value failed --> $DIR/uninhabited.rs:41:9 | LL | assert!(false); | ^^^^^^^^^^^^^^ evaluation panicked: assertion failed: false | = note: this error originates in the macro `assert` (in Nightly builds, run with -Z macro-backtrace for more info) ``` --- When the primary span for a const error is the same as the first frame in the const error report, skip it. ``` error[E0080]: evaluation of constant value failed --> $DIR/issue-88434-removal-index-should-be-less.rs:3:24 | LL | const _CONST: &[u8] = &f(&[], |_| {}); | ^^^^^^^^^^^^^^ evaluation panicked: explicit panic | note: inside `f::<{closure@$DIR/issue-88434-removal-index-should-be-less.rs:3:31: 3:34}>` --> $DIR/issue-88434-removal-index-should-be-less.rs:10:5 | LL | panic!() | ^^^^^^^^ the failure occurred here = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ``` instead of ``` error[E0080]: evaluation of constant value failed --> $DIR/issue-88434-removal-index-should-be-less.rs:10:5 | LL | panic!() | ^^^^^^^^ explicit panic | note: inside `f::<{closure@$DIR/issue-88434-removal-index-should-be-less.rs:3:31: 3:34}>` --> $DIR/issue-88434-removal-index-should-be-less.rs:10:5 | LL | panic!() | ^^^^^^^^ note: inside `_CONST` --> $DIR/issue-88434-removal-index-should-be-less.rs:3:24 | LL | const _CONST: &[u8] = &f(&[], |_| {}); | ^^^^^^^^^^^^^^ = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ``` --- Revert order of constant evaluation errors Point at the code the user wrote first and std functions last. ``` error[E0080]: evaluation of constant value failed --> $DIR/const-errs-dont-conflict-103369.rs:5:25 | LL | impl ConstGenericTrait<{my_fn(1)}> for () {} | ^^^^^^^^ evaluation panicked: Some error occurred | note: called from `my_fn` --> $DIR/const-errs-dont-conflict-103369.rs:10:5 | LL | panic!("Some error occurred"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ``` instead of ``` error[E0080]: evaluation of constant value failed --> $DIR/const-errs-dont-conflict-103369.rs:10:5 | LL | panic!("Some error occurred"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Some error occurred | note: called from `<() as ConstGenericTrait<{my_fn(1)}>>::{constant#0}` --> $DIR/const-errs-dont-conflict-103369.rs:5:25 | LL | impl ConstGenericTrait<{my_fn(1)}> for () {} | ^^^^^^^^ = note: this error originates in the macro `$crate::panic::panic_2015` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ```		2025-02-28 16:28:41 +00:00
..
auxiliary	Move default-field-values tests into a subdirectory	2024-12-14 18:05:19 +00:00
do-not-ice-on-invalid-lifetime.rs	Do not ICE on default_field_value const with lifetimes	2025-01-18 23:40:34 +00:00
do-not-ice-on-invalid-lifetime.stderr	Do not ICE on default_field_value const with lifetimes	2025-01-18 23:40:34 +00:00
empty-struct.rs	Disallow A { .. } if A has no fields	2025-01-18 21:05:09 +00:00
empty-struct.stderr	Disallow A { .. } if A has no fields	2025-01-18 21:05:09 +00:00
failures.rs	Move default-field-values tests into a subdirectory	2024-12-14 18:05:19 +00:00
failures.stderr	Move default-field-values tests into a subdirectory	2024-12-14 18:05:19 +00:00
invalid-const.rs	Move default-field-values tests into a subdirectory	2024-12-14 18:05:19 +00:00
invalid-const.stderr	Shorten span of panic failures in const context	2025-02-28 16:28:41 +00:00
non-exhaustive-ctor.disabled.stderr	More sophisticated span trimming	2025-02-21 00:41:17 +00:00
non-exhaustive-ctor.enabled.fixed	Detect missing fields with default values and suggest ..	2025-01-21 21:26:37 +00:00
non-exhaustive-ctor.enabled.stderr	More sophisticated span trimming	2025-02-21 00:41:17 +00:00
non-exhaustive-ctor.rs	Detect missing fields with default values and suggest ..	2025-01-21 21:26:37 +00:00
support.rs	Move default-field-values tests into a subdirectory	2024-12-14 18:05:19 +00:00
use-normalized-ty-for-default-struct-value.rs	Make sure to use normalized ty for unevaluated const for default struct value	2024-12-14 18:05:19 +00:00
visibility.rs	Emit a single privacy error for multiple fields on the same struct expression	2025-01-18 20:33:15 +00:00
visibility.stderr	Emit a single privacy error for multiple fields on the same struct expression	2025-01-18 20:33:15 +00:00