mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-23 07:14:28 +00:00
2bdc9a046a
Considering the following code
```rust
fn foo() -> u8 {
async fn async_fn() -> u8 { 22 }
async_fn()
}
fn main() {}
```
the error generated before this commit from the compiler is
```
➜ rust git:(macros/async_fn_suggestion) ✗ rustc test.rs --edition 2021
error[E0308]: mismatched types
--> test.rs:4:5
|
1 | fn foo() -> u8 {
| -- expected `u8` because of return type
...
4 | async_fn()
| ^^^^^^^^^^ expected `u8`, found opaque type
|
= note: expected type `u8`
found opaque type `impl Future<Output = u8>`
help: consider `await`ing on the `Future`
|
4 | async_fn().await
| ++++++
error: aborting due to previous error
```
In this case the error is nor perfect, and can confuse the user
that do not know that the opaque type is the future.
So this commit will propose (and conclude the work start in
https://github.com/rust-lang/rust/issues/80658)
to change the string `opaque type` to `future` when applicable
and also remove the Expected vs Received note by adding a more
specific one regarding the async function that return a future type.
So the new error emitted by the compiler is
```
error[E0308]: mismatched types
--> test.rs:4:5
|
1 | fn foo() -> u8 {
| -- expected `u8` because of return type
...
4 | async_fn()
| ^^^^^^^^^^ expected `u8`, found future
|
note: calling an async function returns a future
--> test.rs:4:5
|
4 | async_fn()
| ^^^^^^^^^^
help: consider `await`ing on the `Future`
|
4 | async_fn().await
| ++++++
error: aborting due to previous error
```
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
27 lines
731 B
Plaintext
27 lines
731 B
Plaintext
error[E0308]: mismatched types
|
|
--> $DIR/dont-suggest-missing-await.rs:14:18
|
|
|
|
|
LL | take_u32(x)
|
|
| -------- ^ expected `u32`, found future
|
|
| |
|
|
| arguments to this function are incorrect
|
|
|
|
|
note: calling an async function returns a future
|
|
--> $DIR/dont-suggest-missing-await.rs:14:18
|
|
|
|
|
LL | take_u32(x)
|
|
| ^
|
|
note: function defined here
|
|
--> $DIR/dont-suggest-missing-await.rs:5:4
|
|
|
|
|
LL | fn take_u32(x: u32) {}
|
|
| ^^^^^^^^ ------
|
|
help: consider `await`ing on the `Future`
|
|
|
|
|
LL | take_u32(x.await)
|
|
| ++++++
|
|
|
|
error: aborting due to previous error
|
|
|
|
For more information about this error, try `rustc --explain E0308`.
|