León Orell Valerian Liehr 7b7a7fc891 Rollup merge of #122564 - Bryanskiy:delegation-fixes, r=compiler-errors ... Delegation: fix ICE on duplicated associative items Currently, functions delegation is only supported for delegation items with early resolved paths e.g. free functions and trait methods. During name resolution, information about function signatures is collected, including the number of parameters and whether there are self arguments. This information is then used when lowering from a delegation item into a regular function(`rustc_ast_lowering/src/delegation.rs`). The signature is usually inherited from path resolution id(`path_id`). However, in the case of trait impls `path_id` and `item_id` may be different: ```rust trait Trait { fn foo(&self) -> u32 { 0 } } struct S; mod to_reuse { use crate::S; pub fn foo(_: &S) -> u32 { 0 } } impl Trait for S { reuse to_reuse::foo { self } //~^ The signature should be inherited from item id instead of resolution id } ``` Let's now consider an example from [issue](https://github.com/rust-lang/rust/issues/119920). Due to duplicated associative elements partial resolution for one of them will not be recorded: 9023f908cf/compiler/rustc_resolve/src/late.rs (L3153-L3162) Which leads to an incorrect `is_in_trait_impl` 9023f908cf/compiler/rustc_ast_lowering/src/item.rs (L981-L986) Which leads to an incorrect id for signature inheritance 9023f908cf/compiler/rustc_ast_lowering/src/delegation.rs (L99-L105) Which lead to an ICE from original issue. This patch fixes wrong `is_in_trait_impl` calculation. fixes https://github.com/rust-lang/rust/issues/119920		2024-03-16 23:28:48 +01:00
..
src	Rollup merge of #122564 - Bryanskiy:delegation-fixes, r=compiler-errors	2024-03-16 23:28:48 +01:00
Cargo.toml	Clean up rustc_*/Cargo.toml.	2023-10-30 08:46:02 +11:00
messages.ftl	Add asm label support to AST and HIR	2024-02-24 18:49:39 +00:00