mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-05 19:58:32 +00:00
78d29ad8d6
Sometimes move errors are because of a misplaced `continue`, but we didn't
surface that anywhere. Now when there are more than one set of nested loops
we show them out and point at the `continue` and `break` expressions within
that might need to go elsewhere.
```
error[E0382]: use of moved value: `foo`
--> $DIR/nested-loop-moved-value-wrong-continue.rs:46:18
|
LL | for foo in foos {
| ---
| |
| this reinitialization might get skipped
| move occurs because `foo` has type `String`, which does not implement the `Copy` trait
...
LL | for bar in &bars {
| ---------------- inside of this loop
...
LL | baz.push(foo);
| --- value moved here, in previous iteration of loop
...
LL | qux.push(foo);
| ^^^ value used here after move
|
note: verify that your loop breaking logic is correct
--> $DIR/nested-loop-moved-value-wrong-continue.rs:41:17
|
LL | for foo in foos {
| ---------------
...
LL | for bar in &bars {
| ----------------
...
LL | continue;
| ^^^^^^^^ this `continue` advances the loop at line 33
help: consider moving the expression out of the loop so it is only moved once
|
LL ~ let mut value = baz.push(foo);
LL ~ for bar in &bars {
LL |
...
LL | if foo == *bar {
LL ~ value;
|
help: consider cloning the value if the performance cost is acceptable
|
LL | baz.push(foo.clone());
| ++++++++
```
Fix #92531.
|
||
|---|---|---|
| .. | ||
| constraints | ||
| diagnostics | ||
| polonius | ||
| region_infer | ||
| type_check | ||
| util | ||
| borrow_set.rs | ||
| borrowck_errors.rs | ||
| consumers.rs | ||
| dataflow.rs | ||
| def_use.rs | ||
| facts.rs | ||
| lib.rs | ||
| location.rs | ||
| member_constraints.rs | ||
| nll.rs | ||
| path_utils.rs | ||
| place_ext.rs | ||
| places_conflict.rs | ||
| prefixes.rs | ||
| renumber.rs | ||
| session_diagnostics.rs | ||
| universal_regions.rs | ||
| used_muts.rs | ||