nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-04-28 02:57:37 +00:00
Code Issues Packages Projects Releases Wiki Activity
78403e86d5
rust/compiler
History
Matthias Krüger 74f5e1f140
Rollup merge of #118983 - Urgau:invalid_ref_casting-bigger-layout, r=oli-obk 
Warn on references casting to bigger memory layout

This PR extends the [`invalid_reference_casting`](https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#invalid-reference-casting) lint (*deny-by-default*) which currently lint on `&T -> &mut T` casting to also lint on `&(mut) A -> &(mut) B` where `size_of::<B>() > size_of::<A>()` (bigger memory layout requirement).

The goal is to detect such cases:

```rust
let u8_ref: &u8 = &0u8;
let u64_ref: &u64 = unsafe { &*(u8_ref as *const u8 as *const u64) };
//~^ ERROR casting references to a bigger memory layout is undefined behavior

let mat3 = Mat3 { a: Vec3(0i32, 0, 0), b: Vec3(0, 0, 0), c: Vec3(0, 0, 0) };
let mat3 = unsafe { &*(&mat3 as *const _ as *const [[i64; 3]; 3]) };
//~^ ERROR casting references to a bigger memory layout is undefined behavior
```

This is added to help people who write unsafe code, especially when people have matrix struct that they cast to simple array of arrays.

EDIT: One caveat, due to the [`&Header`](https://github.com/rust-lang/unsafe-code-guidelines/issues/256) uncertainty the lint only fires when it can find the underline allocation.

~~I have manually tested all the new expressions that warn against Miri, and they all report immediate UB.~~

r? ``@est31``
2024-02-12 23:18:52 +01:00
..
rustc
rustc_abi Fix rustc_abi build on stable 2024-01-16 21:15:31 +01:00
rustc_arena Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_ast Add #[derive(Clone, Copy)] to anonymous adts 2024-02-12 12:47:32 +08:00
rustc_ast_lowering Lowering field access for anonymous adts 2024-02-12 12:47:30 +08:00
rustc_ast_passes check uniqueness of nested fields 2024-02-12 12:47:29 +08:00
rustc_ast_pretty Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_attr Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_baked_icu_data
rustc_borrowck Rollup merge of #120917 - chenyukang:yukang-dead-parameters, r=compiler-errors 2024-02-12 18:04:08 +01:00
rustc_builtin_macros Add #[derive(Clone, Copy)] to anonymous adts 2024-02-12 12:47:32 +08:00
rustc_codegen_cranelift Auto merge of #120843 - matthiaskrgr:rollup-med37z5, r=matthiaskrgr 2024-02-09 15:34:48 +00:00
rustc_codegen_gcc Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_codegen_llvm Remove unnecessary #![feature(min_specialization)] 2024-02-10 12:26:14 +11:00
rustc_codegen_ssa Rollup merge of #120865 - saethlin:missing-o-files, r=nnethercote 2024-02-10 13:12:31 +01:00
rustc_const_eval Rollup merge of #120933 - RalfJung:const-check-misc, r=oli-obk 2024-02-12 18:04:09 +01:00
rustc_data_structures Rollup merge of #120846 - petrochenkov:jobs, r=oli-obk 2024-02-10 00:58:38 +01:00
rustc_driver
rustc_driver_impl Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_error_codes unstably allow constants to refer to statics and read from immutable statics 2024-02-10 16:12:55 +01:00
rustc_error_messages Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_errors Rollup merge of #120833 - nnethercote:more-internal-emit_diagnostics-cleanups, r=oli-obk 2024-02-12 18:04:07 +01:00
rustc_expand Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_feature Tweak delayed bug mentions. 2024-02-12 18:39:20 +11:00
rustc_fluent_macro Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_fs_util Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_graphviz Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_hir Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_hir_analysis Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_hir_pretty Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_hir_typeck Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_incremental Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_index Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_index_macros Step all bootstrap cfgs forward 2024-02-08 07:44:34 -05:00
rustc_infer Tweak delayed bug mentions. 2024-02-12 18:39:20 +11:00
rustc_interface Tweak delayed bug mentions. 2024-02-12 18:39:20 +11:00
rustc_lexer Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_lint Introduce small cache to avoid recomputing the same value twice 2024-02-12 19:40:17 +01:00
rustc_lint_defs Remove unnecessary #![feature(min_specialization)] 2024-02-10 12:26:14 +11:00
rustc_llvm Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_log Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_macros Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_metadata Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_middle Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_mir_build Lowering field access for anonymous adts 2024-02-12 12:47:30 +08:00
rustc_mir_dataflow Remove unnecessary min_specialization after bootstrap 2024-02-10 18:15:11 +11:00
rustc_mir_transform Rollup merge of #120944 - compiler-errors:inliner-abi, r=oli-obk 2024-02-12 18:04:10 +01:00
rustc_monomorphize Rollup merge of #120773 - Enselic:copy-vs-move, r=oli-obk 2024-02-11 01:37:55 +01:00
rustc_next_trait_solver Add CoroutineClosure to TyKind, AggregateKind, UpvarArgs 2024-02-06 02:22:58 +00:00
rustc_parse Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_parse_format Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_passes Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_pattern_analysis Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_privacy Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_query_impl Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_query_system Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_resolve Improve some codes according to the reviews 2024-02-12 12:47:32 +08:00
rustc_serialize Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_session Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
rustc_smir Add a new debug_assertions instrinsic (compiler) 2024-02-08 11:49:08 -05:00
rustc_span Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_symbol_mangling Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_target Remove unnecessary min_specialization after bootstrap 2024-02-10 18:15:11 +11:00
rustc_trait_selection Auto merge of #120980 - matthiaskrgr:rollup-dsjsqql, r=matthiaskrgr 2024-02-12 17:06:22 +00:00
rustc_traits Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_transmute Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_ty_utils Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_type_ir Rollup merge of #120693 - nnethercote:invert-diagnostic-lints, r=davidtwco 2024-02-09 14:41:50 +01:00
stable_mir Add a new debug_assertions instrinsic (compiler) 2024-02-08 11:49:08 -05:00