mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-27 17:24:06 +00:00
35f6eee51a
Use root obligation on E0277 for some cases When encountering trait bound errors that satisfy some heuristics that tell us that the relevant trait for the user comes from the root obligation and not the current obligation, we use the root predicate for the main message. This allows to talk about "X doesn't implement Pattern<'_>" over the most specific case that just happened to fail, like "char doesn't implement Fn(&mut char)" in `tests/ui/traits/suggest-dereferences/root-obligation.rs` The heuristics are: - the type of the leaf predicate is (roughly) the same as the type from the root predicate, as a proxy for "we care about the root" - the leaf trait and the root trait are different, so as to avoid talking about `&mut T: Trait` and instead remain talking about `T: Trait` instead - the root trait is not `Unsize`, as to avoid talking about it in `tests/ui/coercion/coerce-issue-49593-box-never.rs`. ``` error[E0277]: the trait bound `&char: Pattern<'_>` is not satisfied --> $DIR/root-obligation.rs:6:38 | LL | .filter(|c| "aeiou".contains(c)) | -------- ^ the trait `Fn<(char,)>` is not implemented for `&char`, which is required by `&char: Pattern<'_>` | | | required by a bound introduced by this call | = note: required for `&char` to implement `FnOnce<(char,)>` = note: required for `&char` to implement `Pattern<'_>` note: required by a bound in `core::str::<impl str>::contains` --> $SRC_DIR/core/src/str/mod.rs:LL:COL help: consider dereferencing here | LL | .filter(|c| "aeiou".contains(*c)) | + ``` Fix #79359, fix #119983, fix #118779, cc #118415 (the suggestion needs to change), cc #121398 (doesn't fix the underlying issue). |
||
|---|---|---|
| .. | ||
| auxiliary | ||
| issues | ||
| assign-to-method.rs | ||
| assign-to-method.stderr | ||
| call_method_unknown_pointee.rs | ||
| call_method_unknown_pointee.stderr | ||
| disambiguate-associated-function-first-arg.rs | ||
| disambiguate-associated-function-first-arg.stderr | ||
| disambiguate-multiple-blanket-impl.rs | ||
| disambiguate-multiple-blanket-impl.stderr | ||
| disambiguate-multiple-impl.rs | ||
| disambiguate-multiple-impl.stderr | ||
| disambiguate-multiple-trait-2.rs | ||
| disambiguate-multiple-trait-2.stderr | ||
| disambiguate-multiple-trait.rs | ||
| disambiguate-multiple-trait.stderr | ||
| field-method-suggestion-using-return-ty.rs | ||
| field-method-suggestion-using-return-ty.stderr | ||
| inherent-bound-in-probe.rs | ||
| inherent-bound-in-probe.stderr | ||
| issue-3707.rs | ||
| issue-3707.stderr | ||
| issue-7950.rs | ||
| issue-7950.stderr | ||
| issue-19521.rs | ||
| issue-19521.stderr | ||
| method-ambig-one-trait-unknown-int-type.rs | ||
| method-ambig-one-trait-unknown-int-type.stderr | ||
| method-ambig-two-traits-cross-crate.rs | ||
| method-ambig-two-traits-cross-crate.stderr | ||
| method-ambig-two-traits-from-bounds.rs | ||
| method-ambig-two-traits-from-bounds.stderr | ||
| method-ambig-two-traits-from-impls2.rs | ||
| method-ambig-two-traits-from-impls2.stderr | ||
| method-ambig-two-traits-from-impls.rs | ||
| method-ambig-two-traits-from-impls.stderr | ||
| method-ambig-two-traits-with-default-method.rs | ||
| method-ambig-two-traits-with-default-method.stderr | ||
| method-ambiguity-no-rcvr.rs | ||
| method-ambiguity-no-rcvr.stderr | ||
| method-argument-inference-associated-type.rs | ||
| method-call-err-msg.rs | ||
| method-call-err-msg.stderr | ||
| method-call-lifetime-args-fail.rs | ||
| method-call-lifetime-args-fail.stderr | ||
| method-call-lifetime-args-lint-fail.rs | ||
| method-call-lifetime-args-lint-fail.stderr | ||
| method-call-lifetime-args-lint.rs | ||
| method-call-lifetime-args-lint.stderr | ||
| method-call-lifetime-args-subst-index.rs | ||
| method-call-lifetime-args-unresolved.rs | ||
| method-call-lifetime-args-unresolved.stderr | ||
| method-call-lifetime-args.rs | ||
| method-call-lifetime-args.stderr | ||
| method-call-type-binding.rs | ||
| method-call-type-binding.stderr | ||
| method-deref-to-same-trait-object-with-separate-params.rs | ||
| method-deref-to-same-trait-object-with-separate-params.stderr | ||
| method-early-bound-lifetimes-on-self.rs | ||
| method-lookup-order.rs | ||
| method-macro-backtrace.rs | ||
| method-macro-backtrace.stderr | ||
| method-missing-call.rs | ||
| method-missing-call.stderr | ||
| method-mut-self-modifies-mut-slice-lvalue.rs | ||
| method-normalize-bounds-issue-20604.rs | ||
| method-not-found-but-doc-alias.rs | ||
| method-not-found-but-doc-alias.stderr | ||
| method-not-found-generic-arg-elision.rs | ||
| method-not-found-generic-arg-elision.stderr | ||
| method-on-ambiguous-numeric-type.rs | ||
| method-on-ambiguous-numeric-type.stderr | ||
| method-path-in-pattern.rs | ||
| method-path-in-pattern.stderr | ||
| method-probe-no-guessing-dyn-trait.rs | ||
| method-projection.rs | ||
| method-recursive-blanket-impl.rs | ||
| method-recursive-blanket-impl.stderr | ||
| method-resolvable-path-in-pattern.rs | ||
| method-resolvable-path-in-pattern.stderr | ||
| method-self-arg-1.rs | ||
| method-self-arg-1.stderr | ||
| method-self-arg-2.rs | ||
| method-self-arg-2.stderr | ||
| method-self-arg-aux1.rs | ||
| method-self-arg-aux2.rs | ||
| method-self-arg-trait.rs | ||
| method-self-arg.rs | ||
| method-trait-object-with-hrtb.rs | ||
| method-two-trait-defer-resolution-1.rs | ||
| method-two-trait-defer-resolution-2.rs | ||
| method-two-trait-defer-resolution-2.stderr | ||
| method-two-traits-distinguished-via-where-clause.rs | ||
| method-two-traits-distinguished-via-where-clause.stderr | ||
| method-where-clause.rs | ||
| suggest-method-on-call-with-macro-rcvr.rs | ||
| suggest-method-on-call-with-macro-rcvr.stderr | ||