mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
b8c207435c
Replace a number of FxHashMaps/Sets with stable-iteration-order alternatives This PR replaces almost all of the remaining `FxHashMap`s in query results with either `FxIndexMap` or `UnordMap`. The only case that is missing is the `EffectiveVisibilities` struct which turned out to not be straightforward to transform. Once that is done too, we can remove the `HashStable` implementation from `HashMap`. The first commit adds the `StableCompare` trait which is a companion trait to `StableOrd`. Some types like `Symbol` can be compared in a cross-session stable way, but their `Ord` implementation is not stable. In such cases, a `StableCompare` implementation can be provided to offer a lightweight way for stable sorting. The more heavyweight option is to sort via `ToStableHashKey`, but then sorting needs to have access to a stable hashing context and `ToStableHashKey` can also be expensive as in the case of `Symbol` where it has to allocate a `String`. The rest of the commits are rather mechanical and don't overlap, so they are best reviewed individually. Part of [MCP 533](https://github.com/rust-lang/compiler-team/issues/533). |
||
|---|---|---|
| .. | ||
| compare_impl_item | ||
| check.rs | ||
| compare_impl_item.rs | ||
| dropck.rs | ||
| entry.rs | ||
| intrinsic.rs | ||
| intrinsicck.rs | ||
| mod.rs | ||
| region.rs | ||
| wfcheck.rs | ||