mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-27 09:14:20 +00:00
b6657a8ad4
HIR typeck tries to figure out which casts are trivial by doing them as coercions and seeing whether this works. Since HIR typeck is oblivious of lifetimes, this doesn't work for pointer casts that only change the lifetime of the pointee, which are, as borrowck will tell you, not trivial. This change makes it so that raw pointer casts are never considered trivial. This also incidentally fixes the "trivial cast" lint false positive on the same code. Unfortunately, "trivial cast" lints are now never emitted on raw pointer casts, even if they truly are trivial. This could be fixed by also doing the lint in borrowck for raw pointers specifically.
27 lines
694 B
Diff
27 lines
694 B
Diff
- // MIR for `roundtrip` before InstSimplify
|
|
+ // MIR for `roundtrip` after InstSimplify
|
|
|
|
fn roundtrip(_1: *const u8) -> *const u8 {
|
|
debug x => _1;
|
|
let mut _0: *const u8;
|
|
let mut _2: *const u8;
|
|
let mut _3: *mut u8;
|
|
let mut _4: *const u8;
|
|
|
|
bb0: {
|
|
StorageLive(_2);
|
|
StorageLive(_3);
|
|
StorageLive(_4);
|
|
_4 = _1;
|
|
_3 = move _4 as *mut u8 (PtrToPtr);
|
|
_2 = move _3 as *const u8 (PointerCoercion(MutToConstPointer));
|
|
StorageDead(_4);
|
|
StorageDead(_3);
|
|
- _0 = move _2 as *const u8 (PtrToPtr);
|
|
+ _0 = move _2;
|
|
StorageDead(_2);
|
|
return;
|
|
}
|
|
}
|
|
|