mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-26 00:34:06 +00:00
72b172bdf6
Currently `emit_stashed_diagnostic` is called from four(!) different places: `print_error_count`, `DiagCtxtInner::drop`, `abort_if_errors`, and `compile_status`. And `flush_delayed` is called from two different places: `DiagCtxtInner::drop` and `Queries`. This is pretty gross! Each one should really be called from a single place, but there's a bunch of entanglements. This commit cleans up this mess. Specifically, it: - Removes all the existing calls to `emit_stashed_diagnostic`, and adds a single new call in `finish_diagnostics`. - Removes the early `flush_delayed` call in `codegen_and_build_linker`, replacing it with a simple early return if delayed bugs are present. - Changes `DiagCtxtInner::drop` and `DiagCtxtInner::flush_delayed` so they both assert that the stashed diagnostics are empty (i.e. processed beforehand). - Changes `interface::run_compiler` so that any errors emitted during `finish_diagnostics` (i.e. late-emitted stashed diagnostics) are counted and cannot be overlooked. This requires adding `ErrorGuaranteed` return values to several functions. - Removes the `stashed_err_count` call in `analysis`. This is possible now that we don't have to worry about calling `flush_delayed` early from `codegen_and_build_linker` when stashed diagnostics are pending. - Changes the `span_bug` case in `handle_tuple_field_pattern_match` to a `delayed_span_bug`, because it now can be reached due to the removal of the `stashed_err_count` call in `analysis`. - Slightly changes the expected output of three tests. If no errors are emitted but there are delayed bugs, the error count is no longer printed. This is because delayed bugs are now always printed after the error count is printed (or not printed, if the error count is zero). There is a lot going on in this commit. It's hard to break into smaller pieces because the existing code is very tangled. It took me a long time and a lot of effort to understand how the different pieces interact, and I think the new code is a lot simpler and easier to understand. |
||
|---|---|---|
| .. | ||
| auxiliary | ||
| need_type_info | ||
| ambiguous_type_parameter.rs | ||
| ambiguous_type_parameter.stderr | ||
| array-len-mismatch.rs | ||
| array-len-mismatch.stderr | ||
| cannot-infer-async.rs | ||
| cannot-infer-async.stderr | ||
| cannot-infer-closure-circular.rs | ||
| cannot-infer-closure-circular.stderr | ||
| cannot-infer-closure.rs | ||
| cannot-infer-closure.stderr | ||
| cannot-infer-partial-try-return.rs | ||
| cannot-infer-partial-try-return.stderr | ||
| char-as-str-multi.rs | ||
| char-as-str-multi.stderr | ||
| char-as-str-single.fixed | ||
| char-as-str-single.rs | ||
| char-as-str-single.stderr | ||
| deref-suggestion.rs | ||
| deref-suggestion.stderr | ||
| erase-type-params-in-label.rs | ||
| erase-type-params-in-label.stderr | ||
| infer-binary-operand-behind-reference.rs | ||
| inference_unstable_featured.rs | ||
| inference_unstable_featured.stderr | ||
| inference_unstable_forced.rs | ||
| inference_unstable_forced.stderr | ||
| inference_unstable.rs | ||
| inference_unstable.stderr | ||
| inference-variable-behind-raw-pointer.rs | ||
| inference-variable-behind-raw-pointer.stderr | ||
| issue-12028.rs | ||
| issue-12028.stderr | ||
| issue-28935.rs | ||
| issue-36053.rs | ||
| issue-70082.rs | ||
| issue-70082.stderr | ||
| issue-70703.rs | ||
| issue-71309.rs | ||
| issue-71309.stderr | ||
| issue-71584.rs | ||
| issue-71584.stderr | ||
| issue-71732.rs | ||
| issue-71732.stderr | ||
| issue-72616.rs | ||
| issue-72616.stderr | ||
| issue-72690.rs | ||
| issue-72690.stderr | ||
| issue-80409.no-compat.stderr | ||
| issue-80409.rs | ||
| issue-80816.rs | ||
| issue-80816.stderr | ||
| issue-81522.rs | ||
| issue-83606.rs | ||
| issue-83606.stderr | ||
| issue-86094-suggest-add-return-to-coerce-ret-ty.rs | ||
| issue-86094-suggest-add-return-to-coerce-ret-ty.stderr | ||
| issue-86162-1.rs | ||
| issue-86162-1.stderr | ||
| issue-86162-2.rs | ||
| issue-86162-2.stderr | ||
| issue-103587.rs | ||
| issue-103587.stderr | ||
| issue-104649.rs | ||
| issue-104649.stderr | ||
| issue-107090.rs | ||
| issue-107090.stderr | ||
| issue-113354.fixed | ||
| issue-113354.rs | ||
| issue-113354.stderr | ||
| lub-glb-with-unbound-infer-var.rs | ||
| multiple-impl-apply.rs | ||
| multiple-impl-apply.stderr | ||
| newlambdas-ret-infer2.rs | ||
| newlambdas-ret-infer.rs | ||
| question-mark-type-infer.rs | ||
| question-mark-type-infer.stderr | ||
| range-type-infer.rs | ||
| simple-infer.rs | ||
| str-as-char.fixed | ||
| str-as-char.rs | ||
| str-as-char.stderr | ||
| tutorial-suffix-inference-test.rs | ||
| tutorial-suffix-inference-test.stderr | ||
| type-infer-generalize-ty-var.rs | ||