mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-25 16:24:46 +00:00
a4f323ce9c
Suggest creating unary tuples when types don't match a trait
When you want to have a variadic function, a common workaround to implement this is to create a trait and then implement that trait for various tuples. For example in `pyo3` there exists
```rust
/// Calls the object with only positional arguments.
pub fn call1(&self, args: impl IntoPy<Py<PyTuple>>) -> PyResult<&PyAny> {
...
}
```
with various impls like
```rust
impl<A: IntoPy<PyObject> IntoPy<Py<PyAny>> for (A,)
impl<A: IntoPy<PyObject, B: IntoPy<PyObject> IntoPy<Py<PyAny>> for (A, B)
... etc
```
This means that if you want to call the method with a single item you have to create a unary tuple, like `(x,)`, rather than just `x`.
This PR implements a suggestion to do that, if applicable.
|
||
|---|---|---|
| .. | ||
| auxiliary | ||
| do_not_recommend | ||
| on_unimplemented | ||
| can_use_the_diagnostic_name_in_other_places.rs | ||
| deny_malformed_attribute.rs | ||
| deny_malformed_attribute.stderr | ||
| existing_proc_macros.rs | ||
| malformed_foreign_on_unimplemented.rs | ||
| malformed_foreign_on_unimplemented.stderr | ||
| non_existing_attributes_accepted.rs | ||
| non_existing_attributes_accepted.stderr | ||
| requires_path.rs | ||
| requires_path.stderr | ||
| suggest_typos.rs | ||
| suggest_typos.stderr | ||