mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-28 01:34:21 +00:00
0534655d9b
Check pattern refutability on THIR The current `check_match` query is based on HIR, but partially re-lowers HIR into THIR. This PR proposed to use the results of the `thir_body` query to check matches, instead of re-building THIR. Most of the diagnostic changes are spans getting shorter, or commas/semicolons not getting removed. This PR degrades the diagnostic for confusing constants in patterns (`let A = foo()` where `A` resolves to a `const A` somewhere): it does not point ot the definition of `const A` any more.
218 lines
9.5 KiB
Plaintext
218 lines
9.5 KiB
Plaintext
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:102:9
|
|
|
|
|
LL | VariantNonExhaustive::Bar { x, .. } => {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `y` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `VariantNonExhaustive` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:99:12
|
|
|
|
|
LL | #[warn(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:107:9
|
|
|
|
|
LL | let FunctionalRecord { first_field, second_field, .. } = FunctionalRecord::default();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `third_field` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `FunctionalRecord` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:106:12
|
|
|
|
|
LL | #[warn(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:115:29
|
|
|
|
|
LL | let NestedStruct { bar: NormalStruct { first_field, .. }, .. } = NestedStruct::default();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `second_field` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `NormalStruct` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:114:12
|
|
|
|
|
LL | #[warn(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:115:9
|
|
|
|
|
LL | let NestedStruct { bar: NormalStruct { first_field, .. }, .. } = NestedStruct::default();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `foo` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `NestedStruct` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
|
|
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:173:9
|
|
|
|
|
LL | let OnlyUnstableStruct { unstable, .. } = OnlyUnstableStruct::new();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `unstable2` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `OnlyUnstableStruct` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:172:12
|
|
|
|
|
LL | #[warn(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
warning: some fields are not explicitly listed
|
|
--> $DIR/omitted-patterns.rs:181:9
|
|
|
|
|
LL | let UnstableStruct { stable, stable2, .. } = UnstableStruct::default();
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ field `unstable` not listed
|
|
|
|
|
= help: ensure that all fields are mentioned explicitly by adding the suggested fields
|
|
= note: the pattern is of type `UnstableStruct` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:180:12
|
|
|
|
|
LL | #[warn(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:58:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NonExhaustiveEnum::Struct { .. }` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:57:16
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:65:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NonExhaustiveEnum::Tuple(_)` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:64:16
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:75:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NonExhaustiveEnum::Unit` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:74:16
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:92:32
|
|
|
|
|
LL | NestedNonExhaustive::A(_) => {}
|
|
| ^ patterns `NonExhaustiveEnum::Tuple(_)` and `NonExhaustiveEnum::Struct { .. }` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:89:12
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:94:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NestedNonExhaustive::C` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NestedNonExhaustive` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:132:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NonExhaustiveSingleVariant::A(_)` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveSingleVariant` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:130:12
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:144:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `UnstableEnum::Unstable` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `UnstableEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:143:16
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:168:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `OnlyUnstableEnum::Unstable2` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `OnlyUnstableEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:165:12
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error[E0005]: refutable pattern in local binding
|
|
--> $DIR/omitted-patterns.rs:194:9
|
|
|
|
|
LL | let local_refutable @ NonExhaustiveEnum::Unit = NonExhaustiveEnum::Unit;
|
|
| ^^^^^^^^^^^^^^^ pattern `_` not covered
|
|
|
|
|
= note: `let` bindings require an "irrefutable pattern", like a `struct` or an `enum` with only one variant
|
|
= note: for more information, visit https://doc.rust-lang.org/book/ch18-02-refutability.html
|
|
= note: the matched value is of type `NonExhaustiveEnum`
|
|
help: you might want to use `let else` to handle the variant that isn't matched
|
|
|
|
|
LL | let local_refutable @ NonExhaustiveEnum::Unit = NonExhaustiveEnum::Unit else { todo!() };
|
|
| ++++++++++++++++
|
|
|
|
error: some variants are not matched explicitly
|
|
--> $DIR/omitted-patterns.rs:202:9
|
|
|
|
|
LL | _ => {}
|
|
| ^ pattern `NonExhaustiveEnum::Struct { .. }` not covered
|
|
|
|
|
= help: ensure that all variants are matched explicitly by adding the suggested match arms
|
|
= note: the matched value is of type `NonExhaustiveEnum` and the `non_exhaustive_omitted_patterns` attribute was found
|
|
note: the lint level is defined here
|
|
--> $DIR/omitted-patterns.rs:198:12
|
|
|
|
|
LL | #[deny(non_exhaustive_omitted_patterns)]
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
error: aborting due to 10 previous errors; 6 warnings emitted
|
|
|
|
For more information about this error, try `rustc --explain E0005`.
|