Matthias Krüger 6c8001b85c Rollup merge of #96008 - fmease:warn-on-useless-doc-hidden-on-assoc-impl-items, r=lcnr ... Warn on unused `#[doc(hidden)]` attributes on trait impl items [Zulip conversation](https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/.E2.9C.94.20Validy.20checks.20for.20.60.23.5Bdoc.28hidden.29.5D.60). Whether an associated item in a trait impl is shown or hidden in the documentation entirely depends on the corresponding item in the trait declaration. Rustdoc completely ignores `#[doc(hidden)]` attributes on impl items. No error or warning is emitted: ```rust pub trait Tr { fn f(); } pub struct Ty; impl Tr for Ty { #[doc(hidden)] fn f() {} } // ^^^^^^^^^^^^^^ ignored by rustdoc and currently // no error or warning issued ``` This may lead users to the wrong belief that the attribute has an effect. In fact, several such cases are found in the standard library (I've removed all of them in this PR). There does not seem to exist any incentive to allow this in the future either: Impl'ing a trait for a type means the type *fully* conforms to its API. Users can add `#[doc(hidden)]` to the whole impl if they want to hide the implementation or add the attribute to the corresponding associated item in the trait declaration to hide the specific item. Hiding an implementation of an associated item does not make much sense: The associated item can still be found on the trait page. This PR emits the warn-by-default lint `unused_attribute` for this case with a future-incompat warning. `@rustbot` label T-compiler T-rustdoc A-lint		2022-05-09 18:45:36 +02:00
..
rustc	Propagate parallel_compiler feature through rustc crates. Turned off feature gives change of builded crates: 238 -> 224.	2022-03-28 08:41:12 +03:00
rustc_apfloat	Addressed comments by @compiler-errors and @bjorn3	2022-03-30 17:04:46 -04:00
rustc_arena	mark FIXMES for all the places found that are probably offset_from	2022-03-29 20:18:28 -04:00
rustc_ast	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_ast_lowering	Auto merge of #96770 - flip1995:fix-trait-type-in-bounds, r=cjgillot	2022-05-08 14:10:12 +00:00
rustc_ast_passes	Feature-gate do yeet inside cfgs too	2022-04-30 18:10:01 -07:00
rustc_ast_pretty	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_attr	Use native duplicate attribute check	2022-04-14 21:19:48 -04:00
rustc_borrowck	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_builtin_macros	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_codegen_cranelift	Merge commit 'f2cdd4a78d89c009342197cf5844a21f8aa813df' into sync_cg_clif-2022-04-22	2022-04-22 21:11:38 +02:00
rustc_codegen_gcc	Merge new_metadata into codegen_allocator	2022-04-30 21:20:08 +02:00
rustc_codegen_llvm	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_codegen_ssa	Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister	2022-05-05 12:26:38 +00:00
rustc_const_eval	Auto merge of #96815 - SparrowLii:promote_const, r=oli-obk	2022-05-09 11:49:09 +00:00
rustc_data_structures	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_driver	errors: lazily load fallback fluent bundle	2022-04-13 02:44:59 +01:00
rustc_error_codes	Auto merge of #95960 - jhpratt:remove-rustc_deprecated, r=compiler-errors	2022-05-09 04:47:30 +00:00
rustc_error_messages	typeck: port "explicit generic args w/ impl trait"	2022-05-06 03:46:12 +01:00
rustc_errors	Fixed typo in docs and correct doc links	2022-05-08 17:24:15 +02:00
rustc_expand	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_feature	Auto merge of #95960 - jhpratt:remove-rustc_deprecated, r=compiler-errors	2022-05-09 04:47:30 +00:00
rustc_fs_util
rustc_graphviz
rustc_hir	Auto merge of #96770 - flip1995:fix-trait-type-in-bounds, r=cjgillot	2022-05-08 14:10:12 +00:00
rustc_hir_pretty	Store all generic bounds as where predicates.	2022-04-30 13:55:13 +02:00
rustc_incremental	fix most compiler/ doctests	2022-05-02 17:40:30 -07:00
rustc_index	Add element iterator for ChunkedBitSet	2022-04-30 16:40:49 +02:00
rustc_infer	Auto merge of #96155 - jackh726:param-heuristics-followup, r=estebank	2022-05-08 04:05:36 +00:00
rustc_interface	Move lint expectation checking into a separate query (RFC 2383)	2022-05-08 14:37:14 +02:00
rustc_lexer	Reduce max hash in raw strings from u16 to u8	2022-03-23 22:13:55 +01:00
rustc_lint	Auto merge of #95542 - xFrednet:rfc-2383-expect-query, r=wesleywiser	2022-05-09 00:02:55 +00:00
rustc_lint_defs	Auto merge of #95960 - jhpratt:remove-rustc_deprecated, r=compiler-errors	2022-05-09 04:47:30 +00:00
rustc_llvm	RustWrapper: explicitly don't handle DXILPointerTyID	2022-04-28 13:53:52 -04:00
rustc_log
rustc_macros	macros: allow Vec fields in diagnostic derive	2022-05-06 03:43:30 +01:00
rustc_metadata	use def_span and def_kind queries instead of calling tcx.hir() methods	2022-05-06 12:11:05 -04:00
rustc_middle	Auto merge of #95960 - jhpratt:remove-rustc_deprecated, r=compiler-errors	2022-05-09 04:47:30 +00:00
rustc_mir_build	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_mir_dataflow	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_mir_transform	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_monomorphize	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_parse	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_parse_format	Make rustc_parse_format compile on stable	2022-05-03 11:26:58 +02:00
rustc_passes	Warn on unused doc(hidden) on trait impl items	2022-05-08 22:53:14 +02:00
rustc_plugin_impl
rustc_privacy	rustc: Panic by default in DefIdTree::parent	2022-05-02 01:56:50 +03:00
rustc_query_impl	Move lint expectation checking into a separate query (RFC 2383)	2022-05-08 14:37:14 +02:00
rustc_query_system	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_resolve	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_save_analysis	rustc: Panic by default in DefIdTree::parent	2022-05-02 01:56:50 +03:00
rustc_serialize	Remove unused macro rules	2022-04-18 23:28:06 +02:00
rustc_session	sess: add create_{err,warning}	2022-05-06 03:44:41 +01:00
rustc_span	Auto merge of #96094 - Elliot-Roberts:fix_doctests, r=compiler-errors	2022-05-07 06:30:29 +00:00
rustc_symbol_mangling	Auto merge of #95655 - kckeiks:create-hir-crate-items-query, r=cjgillot	2022-04-17 08:06:53 +00:00
rustc_target	make Size and Align debug-printing a bit more compact	2022-05-06 10:57:03 +02:00
rustc_trait_selection	Rollup merge of #96617 - ken-matsui:fix-incorrect-syntax-suggestion-with-pub-async-fn, r=cjgillot	2022-05-08 21:31:16 +02:00
rustc_traits	Remove opaque type obligation and just register opaque types as they are encountered.	2022-03-28 16:57:45 +00:00
rustc_ty_utils	Avoid accessing HIR from MIR queries.	2022-04-10 13:08:36 +02:00
rustc_type_ir	fix most compiler/ doctests	2022-05-02 17:40:30 -07:00
rustc_typeck	Auto merge of #96155 - jackh726:param-heuristics-followup, r=estebank	2022-05-08 04:05:36 +00:00