mirror of
https://github.com/rust-lang/rust.git
synced 2025-02-26 13:54:06 +00:00
67a9f20c91
`cloned` requires that the elements of the iterator must be references. This change determines if that is the case by examining the type of the closure argument and suggesting `.cloned` only if it is a reference. When the closure argument is not a reference, it suggests removing the `map` call instead. A minor problem with this change is that the new check sometimes overlaps with the `clone_on_copy` lint. Fixes #498
24 lines
723 B
Rust
24 lines
723 B
Rust
// run-rustfix
|
|
#![warn(clippy::all, clippy::pedantic)]
|
|
#![allow(clippy::iter_cloned_collect)]
|
|
#![allow(clippy::clone_on_copy)]
|
|
#![allow(clippy::missing_docs_in_private_items)]
|
|
|
|
fn main() {
|
|
let _: Vec<i8> = vec![5_i8; 6].iter().map(|x| *x).collect();
|
|
let _: Vec<String> = vec![String::new()].iter().map(|x| x.clone()).collect();
|
|
let _: Vec<u32> = vec![42, 43].iter().map(|&x| x).collect();
|
|
let _: Option<u64> = Some(Box::new(16)).map(|b| *b);
|
|
|
|
// Don't lint these
|
|
let v = vec![5_i8; 6];
|
|
let a = 0;
|
|
let b = &a;
|
|
let _ = v.iter().map(|_x| *b);
|
|
let _ = v.iter().map(|_x| a.clone());
|
|
let _ = v.iter().map(|&_x| a);
|
|
|
|
// Issue #496
|
|
let _ = std::env::args().map(|v| v.clone());
|
|
}
|