mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-23 23:34:48 +00:00
65d1f83d2c
Clippy helpfully warns about code like this, telling you that you
probably meant "write_all":
fn say_hi<W:Write>(w: &mut W) {
w.write(b"hello").unwrap();
}
This patch attempts to extend the lint so it also covers this
case:
async fn say_hi<W:AsyncWrite>(w: &mut W) {
w.write(b"hello").await.unwrap();
}
(I've run into this second case several times in my own programming,
and so have my coworkers, so unless we're especially accident-prone
in this area, it's probably worth addressing?)
This patch covers the Async{Read,Write}Ext traits in futures-rs,
and in tokio, since both are quite widely used.
changelog: [`unused_io_amount`] now supports AsyncReadExt and AsyncWriteExt.
66 lines
1.8 KiB
TOML
66 lines
1.8 KiB
TOML
[package]
|
|
name = "clippy"
|
|
version = "0.1.59"
|
|
description = "A bunch of helpful lints to avoid common pitfalls in Rust"
|
|
repository = "https://github.com/rust-lang/rust-clippy"
|
|
readme = "README.md"
|
|
license = "MIT OR Apache-2.0"
|
|
keywords = ["clippy", "lint", "plugin"]
|
|
categories = ["development-tools", "development-tools::cargo-plugins"]
|
|
build = "build.rs"
|
|
edition = "2021"
|
|
publish = false
|
|
|
|
[[bin]]
|
|
name = "cargo-clippy"
|
|
test = false
|
|
path = "src/main.rs"
|
|
|
|
[[bin]]
|
|
name = "clippy-driver"
|
|
path = "src/driver.rs"
|
|
|
|
[dependencies]
|
|
clippy_lints = { version = "0.1", path = "clippy_lints" }
|
|
semver = "1.0"
|
|
rustc_tools_util = { version = "0.2", path = "rustc_tools_util" }
|
|
tempfile = { version = "3.2", optional = true }
|
|
|
|
[dev-dependencies]
|
|
cargo_metadata = "0.14"
|
|
compiletest_rs = { version = "0.7.1", features = ["tmp"] }
|
|
tester = "0.9"
|
|
regex = "1.5"
|
|
# This is used by the `collect-metadata` alias.
|
|
filetime = "0.2"
|
|
|
|
# A noop dependency that changes in the Rust repository, it's a bit of a hack.
|
|
# See the `src/tools/rustc-workspace-hack/README.md` file in `rust-lang/rust`
|
|
# for more information.
|
|
rustc-workspace-hack = "1.0"
|
|
|
|
# UI test dependencies
|
|
clippy_utils = { path = "clippy_utils" }
|
|
derive-new = "0.5"
|
|
if_chain = "1.0"
|
|
itertools = "0.10"
|
|
quote = "1.0"
|
|
serde = { version = "1.0", features = ["derive"] }
|
|
syn = { version = "1.0", features = ["full"] }
|
|
futures = "0.3"
|
|
parking_lot = "0.11.2"
|
|
tokio = { version = "1", features = ["io-util"] }
|
|
|
|
[build-dependencies]
|
|
rustc_tools_util = { version = "0.2", path = "rustc_tools_util" }
|
|
|
|
[features]
|
|
deny-warnings = ["clippy_lints/deny-warnings"]
|
|
integration = ["tempfile"]
|
|
internal-lints = ["clippy_lints/internal-lints"]
|
|
metadata-collector-lint = ["internal-lints", "clippy_lints/metadata-collector-lint"]
|
|
|
|
[package.metadata.rust-analyzer]
|
|
# This package uses #[feature(rustc_private)]
|
|
rustc_private = true
|