mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-08 16:07:43 +00:00
5019bb608a
Silence follow-up errors directly based on error types and regions
During type_of, we used to just return an error type if there were any errors encountered. This is problematic, because it means a struct declared as `struct Foo<'static>` will end up not finding any inherent or trait impls because those impl blocks' `Self` type will be `{type error}` instead of `Foo<'re_error>`. Now it's the latter, silencing nonsensical follow-up errors about `Foo` not having any methods.
Unfortunately that now allows for new follow-up errors, because borrowck treats `'re_error` as `'static`, causing nonsensical errors about non-error lifetimes not outliving `'static`. So what I also did was to just strip all outlives bounds that borrowck found, thus never letting it check them. There are probably more nuanced ways to do this, but I worried there would be other nonsensical errors if some outlives bounds were missing. Also from the test changes, it looked like an improvement everywhere.
|
||
|---|---|---|
| .. | ||
| check | ||
| coherence | ||
| collect | ||
| errors | ||
| hir_ty_lowering | ||
| impl_wf_check | ||
| outlives | ||
| structured_errors | ||
| variance | ||
| autoderef.rs | ||
| bounds.rs | ||
| check_unused.rs | ||
| collect.rs | ||
| constrained_generic_params.rs | ||
| errors.rs | ||
| hir_wf_check.rs | ||
| impl_wf_check.rs | ||
| lib.rs | ||
| structured_errors.rs | ||