mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-03 12:13:43 +00:00
8fa1ed8f12
ptr::copy and ptr::swap are doing untyped copies The consensus in https://github.com/rust-lang/rust/issues/63159 seemed to be that these operations should be "untyped", i.e., they should treat the data as raw bytes, should work when these bytes violate the validity invariant of `T`, and should exactly preserve the initialization state of the bytes that are being copied. This is already somewhat implied by the description of "copying/swapping size*N bytes" (rather than "N instances of `T`"). The implementations mostly already work that way (well, for LLVM's intrinsics the documentation is not precise enough to say what exactly happens to poison, but if this ever gets clarified to something that would *not* perfectly preserve poison, then I strongly assume there will be some way to make a copy that *does* perfectly preserve poison). However, I had to adjust `swap_nonoverlapping`; after ``@scottmcm's`` [recent changes](https://github.com/rust-lang/rust/pull/94212), that one (sometimes) made a typed copy. (Note that `mem::swap`, which works on mutable references, is unchanged. It is documented as "swapping the values at two mutable locations", which to me strongly indicates that it is indeed typed. It is also safe and can rely on `&mut T` pointing to a valid `T` as part of its safety invariant.) On top of adding a test (that will be run by Miri), this PR then also adjusts the documentation to indeed stably promise the untyped semantics. I assume this means the PR has to go through t-libs (and maybe t-lang?) FCP. Fixes https://github.com/rust-lang/rust/issues/63159 |
||
|---|---|---|
| .. | ||
| fmt | ||
| hash | ||
| iter | ||
| num | ||
| ops | ||
| alloc.rs | ||
| any.rs | ||
| array.rs | ||
| ascii.rs | ||
| asserting.rs | ||
| atomic.rs | ||
| bool.rs | ||
| cell.rs | ||
| char.rs | ||
| clone.rs | ||
| cmp.rs | ||
| const_ptr.rs | ||
| convert.rs | ||
| future.rs | ||
| intrinsics.rs | ||
| lazy.rs | ||
| lib.rs | ||
| macros.rs | ||
| manually_drop.rs | ||
| mem.rs | ||
| nonzero.rs | ||
| ops.rs | ||
| option.rs | ||
| pattern.rs | ||
| pin_macro.rs | ||
| pin.rs | ||
| ptr.rs | ||
| result.rs | ||
| simd.rs | ||
| slice.rs | ||
| str_lossy.rs | ||
| str.rs | ||
| task.rs | ||
| time.rs | ||
| tuple.rs | ||
| unicode.rs | ||
| waker.rs | ||