rust/tests/ui-fulldeps/session-diagnostic
Nicholas Nethercote 781111ef35 Use Cow in {D,Subd}iagnosticMessage.
Each of `{D,Subd}iagnosticMessage::{Str,Eager}` has a comment:
```
// FIXME(davidtwco): can a `Cow<'static, str>` be used here?
```
This commit answers that question in the affirmative. It's not the most
compelling change ever, but it might be worth merging.

This requires changing the `impl<'a> From<&'a str>` impls to `impl
From<&'static str>`, which involves a bunch of knock-on changes that
require/result in call sites being a little more precise about exactly
what kind of string they use to create errors, and not just `&str`. This
will result in fewer unnecessary allocations, though this will not have
any notable perf effects given that these are error paths.

Note that I was lazy within Clippy, using `to_string` in a few places to
preserve the existing string imprecision. I could have used `impl
Into<{D,Subd}iagnosticMessage>` in various places as is done in the
compiler, but that would have required changes to *many* call sites
(mostly changing `&format("...")` to `format!("...")`) which didn't seem
worthwhile.
2023-05-29 09:23:43 +10:00
..
diagnostic-derive-doc-comment-field.rs Make spans a bit better 2023-05-08 03:34:46 +00:00
diagnostic-derive-doc-comment-field.stderr Use Cow in {D,Subd}iagnosticMessage. 2023-05-29 09:23:43 +10:00
diagnostic-derive.rs Make spans a bit better 2023-05-08 03:34:46 +00:00
diagnostic-derive.stderr Make spans a bit better 2023-05-08 03:34:46 +00:00
enforce_slug_naming.rs Move /src/test to /tests 2023-01-11 09:32:08 +00:00
enforce_slug_naming.stderr Move /src/test to /tests 2023-01-11 09:32:08 +00:00
example.ftl errors: generate typed identifiers in each crate 2023-02-22 09:15:53 +00:00
subdiagnostic-derive.rs Add rustc_fluent_macro to decouple fluent from rustc_macros 2023-04-18 18:56:22 +00:00
subdiagnostic-derive.stderr Add rustc_fluent_macro to decouple fluent from rustc_macros 2023-04-18 18:56:22 +00:00