mirror of
https://github.com/rust-lang/rust.git
synced 2024-10-31 22:41:50 +00:00
925f7fad57
`tokenstream::Spacing` appears on all `TokenTree::Token` instances, both punct and non-punct. Its current usage: - `Joint` means "can join with the next token *and* that token is a punct". - `Alone` means "cannot join with the next token *or* can join with the next token but that token is not a punct". The fact that `Alone` is used for two different cases is awkward. This commit augments `tokenstream::Spacing` with a new variant `JointHidden`, resulting in: - `Joint` means "can join with the next token *and* that token is a punct". - `JointHidden` means "can join with the next token *and* that token is a not a punct". - `Alone` means "cannot join with the next token". This *drastically* improves the output of `print_tts`. For example, this: ``` stringify!(let a: Vec<u32> = vec![];) ``` currently produces this string: ``` let a : Vec < u32 > = vec! [] ; ``` With this PR, it now produces this string: ``` let a: Vec<u32> = vec![] ; ``` (The space after the `]` is because `TokenTree::Delimited` currently doesn't have spacing information. The subsequent commit fixes this.) The new `print_tts` doesn't replicate original code perfectly. E.g. multiple space characters will be condensed into a single space character. But it's much improved. `print_tts` still produces the old, uglier output for code produced by proc macros. Because we have to translate the generated code from `proc_macro::Spacing` to the more expressive `token::Spacing`, which results in too much `proc_macro::Along` usage and no `proc_macro::JointHidden` usage. So `space_between` still exists and is used by `print_tts` in conjunction with the `Spacing` field. This change will also help with the removal of `Token::Interpolated`. Currently interpolated tokens are pretty-printed nicely via AST pretty printing. `Token::Interpolated` removal will mean they get printed with `print_tts`. Without this change, that would result in much uglier output for code produced by decl macro expansions. With this change, AST pretty printing and `print_tts` produce similar results. The commit also tweaks the comments on `proc_macro::Spacing`. In particular, it refers to "compound tokens" rather than "multi-char operators" because lifetimes aren't operators.
152 lines
5.0 KiB
Plaintext
152 lines
5.0 KiB
Plaintext
PRINT-ATTR INPUT (DISPLAY): struct S1 { #[cfg(all())] #[allow()] field_true: u8, }
|
|
PRINT-ATTR DEEP-RE-COLLECTED (DISPLAY): struct S1 { #[cfg(all())] #[allow()] field_true : u8, }
|
|
PRINT-ATTR INPUT (DEBUG): TokenStream [
|
|
Ident {
|
|
ident: "struct",
|
|
span: $DIR/cfg-eval.rs:17:1: 17:7 (#0),
|
|
},
|
|
Ident {
|
|
ident: "S1",
|
|
span: $DIR/cfg-eval.rs:17:8: 17:10 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Brace,
|
|
stream: TokenStream [
|
|
Punct {
|
|
ch: '#',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:20:5: 20:6 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Bracket,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "cfg",
|
|
span: $DIR/cfg-eval.rs:20:7: 20:10 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "all",
|
|
span: $DIR/cfg-eval.rs:20:11: 20:14 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [],
|
|
span: $DIR/cfg-eval.rs:20:14: 20:24 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:20:10: 20:25 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:20:6: 20:26 (#0),
|
|
},
|
|
Punct {
|
|
ch: '#',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:22:5: 22:6 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Bracket,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "allow",
|
|
span: $DIR/cfg-eval.rs:22:31: 22:36 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [],
|
|
span: $DIR/cfg-eval.rs:22:36: 22:38 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:22:5: 22:6 (#0),
|
|
},
|
|
Ident {
|
|
ident: "field_true",
|
|
span: $DIR/cfg-eval.rs:23:5: 23:15 (#0),
|
|
},
|
|
Punct {
|
|
ch: ':',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:23:15: 23:16 (#0),
|
|
},
|
|
Ident {
|
|
ident: "u8",
|
|
span: $DIR/cfg-eval.rs:23:17: 23:19 (#0),
|
|
},
|
|
Punct {
|
|
ch: ',',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:23:19: 23:20 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:17:11: 24:2 (#0),
|
|
},
|
|
]
|
|
PRINT-ATTR INPUT (DISPLAY): #[rustc_dummy] (#[cfg(all())] 1,)
|
|
PRINT-ATTR INPUT (DEBUG): TokenStream [
|
|
Punct {
|
|
ch: '#',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:35:39: 35:40 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Bracket,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "rustc_dummy",
|
|
span: $DIR/cfg-eval.rs:35:62: 35:73 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:35:39: 35:40 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [
|
|
Punct {
|
|
ch: '#',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:36:23: 36:24 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Bracket,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "cfg",
|
|
span: $DIR/cfg-eval.rs:36:25: 36:28 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [
|
|
Ident {
|
|
ident: "all",
|
|
span: $DIR/cfg-eval.rs:36:29: 36:32 (#0),
|
|
},
|
|
Group {
|
|
delimiter: Parenthesis,
|
|
stream: TokenStream [],
|
|
span: $DIR/cfg-eval.rs:36:32: 36:42 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:36:28: 36:43 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:36:24: 36:44 (#0),
|
|
},
|
|
Literal {
|
|
kind: Integer,
|
|
symbol: "1",
|
|
suffix: None,
|
|
span: $DIR/cfg-eval.rs:36:45: 36:46 (#0),
|
|
},
|
|
Punct {
|
|
ch: ',',
|
|
spacing: Alone,
|
|
span: $DIR/cfg-eval.rs:36:46: 36:47 (#0),
|
|
},
|
|
],
|
|
span: $DIR/cfg-eval.rs:36:5: 36:48 (#0),
|
|
},
|
|
]
|