rust/compiler
Matthias Krüger 48c9864a05
Rollup merge of #128843 - veera-sivarajan:small-cleanup, r=davidtwco
Minor Refactor: Remove a Redundant Conditional Check

The existing code checks `where_bounds.is_empty()` twice when
it can be combined into one. Now, after combining, the refactored code reads
better and feels straightforward.

The diff doesn't make it clear. So, the current code looks like this:
``` rust
    if !where_bounds.is_empty() {
        err.help(format!(
            "consider introducing a new type parameter `T` and adding `where` constraints:\
             \n    where\n        T: {qself_str},\n{}",
            where_bounds.join(",\n"),
        ));
    }
    let reported = err.emit();
    if !where_bounds.is_empty() {
        return Err(reported);
    }
```
The proposed changes:
``` rust
    if !where_bounds.is_empty() {
        err.help(format!(
            "consider introducing a new type parameter `T` and adding `where` constraints:\
             \n    where\n        T: {qself_str},\n{}",
            where_bounds.join(",\n"),
        ));
        let reported = err.emit();
        return Err(reported);
    }
    err.emit();

```
2024-08-21 18:15:01 +02:00
..
rustc Link std statically in rustc_driver 2024-08-11 04:16:53 +02:00
rustc_abi interpret: simplify pointer arithmetic logic 2024-08-01 14:25:19 +02:00
rustc_arena Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_ast Use more slice patterns inside the compiler 2024-08-07 13:37:52 +02:00
rustc_ast_ir Use dep: for crate dependencies 2024-07-15 12:40:10 -04:00
rustc_ast_lowering Use FnSig instead of raw FnDecl for ForeignItemKind::Fn 2024-08-16 14:10:06 -04:00
rustc_ast_passes Auto merge of #127672 - compiler-errors:precise-capturing, r=spastorino 2024-08-20 10:42:55 +00:00
rustc_ast_pretty Use more slice patterns inside the compiler 2024-08-07 13:37:52 +02:00
rustc_attr Rollup merge of #128886 - GrigorenkoPV:untranslatable-diagnostic, r=nnethercote 2024-08-12 17:09:17 +02:00
rustc_baked_icu_data
rustc_borrowck rename AddressOf -> RawBorrow inside the compiler 2024-08-18 19:46:53 +02:00
rustc_builtin_macros Auto merge of #128771 - carbotaniuman:stabilize_unsafe_attr, r=nnethercote 2024-08-17 22:48:42 +00:00
rustc_codegen_cranelift rename AddressOf -> RawBorrow inside the compiler 2024-08-18 19:46:53 +02:00
rustc_codegen_gcc stabilize raw_ref_op 2024-08-18 19:46:53 +02:00
rustc_codegen_llvm Rollup merge of #128627 - khuey:DUMMY_SP-line-no, r=nnethercote 2024-08-21 18:15:01 +02:00
rustc_codegen_ssa Auto merge of #128722 - tgross35:new-resolver-root, r=Mark-Simulacrum 2024-08-19 09:50:33 +00:00
rustc_const_eval ctfe: make CompileTimeInterpCx type alias public 2024-08-20 14:58:10 +02:00
rustc_data_structures Update indexmap and use IndexMap::append 2024-08-13 16:16:57 -07:00
rustc_driver
rustc_driver_impl Rollup merge of #128762 - fmease:use-more-slice-pats, r=compiler-errors 2024-08-11 07:51:51 +02:00
rustc_error_codes stabilize raw_ref_op 2024-08-18 19:46:53 +02:00
rustc_error_messages Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_errors Update annotate-snippets to 0.11 2024-08-19 20:22:07 +00:00
rustc_expand Auto merge of #128771 - carbotaniuman:stabilize_unsafe_attr, r=nnethercote 2024-08-17 22:48:42 +00:00
rustc_feature Auto merge of #127672 - compiler-errors:precise-capturing, r=spastorino 2024-08-20 10:42:55 +00:00
rustc_fluent_macro Update annotate-snippets to 0.11 2024-08-19 20:22:07 +00:00
rustc_fs_util Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_graphviz Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_hir Auto merge of #127672 - compiler-errors:precise-capturing, r=spastorino 2024-08-20 10:42:55 +00:00
rustc_hir_analysis Rollup merge of #128843 - veera-sivarajan:small-cleanup, r=davidtwco 2024-08-21 18:15:01 +02:00
rustc_hir_pretty Use FnSig instead of raw FnDecl for ForeignItemKind::Fn 2024-08-16 14:10:06 -04:00
rustc_hir_typeck Rollup merge of #129223 - wafarm:fix-129215, r=compiler-errors 2024-08-19 20:14:57 +02:00
rustc_incremental Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_index Add and use IndexVec::append 2024-08-13 13:40:05 -07:00
rustc_index_macros Remove usage of specialization from newtype_index! 2024-06-30 16:42:53 +00:00
rustc_infer Auto merge of #128812 - nnethercote:shrink-TyKind-FnPtr, r=compiler-errors 2024-08-14 00:56:53 +00:00
rustc_interface Stabilize std:🧵:Builder::spawn_unchecked 2024-08-16 10:43:47 -07:00
rustc_lexer Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_lint lint on tail expr drop order change in Edition 2024 2024-08-21 01:05:21 +08:00
rustc_lint_defs Auto merge of #128771 - carbotaniuman:stabilize_unsafe_attr, r=nnethercote 2024-08-17 22:48:42 +00:00
rustc_llvm Auto merge of #128936 - bjorn3:fix_thin_archive_reading, r=jieyouxu 2024-08-15 14:13:52 +00:00
rustc_log Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_macros Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_metadata Rollup merge of #128886 - GrigorenkoPV:untranslatable-diagnostic, r=nnethercote 2024-08-12 17:09:17 +02:00
rustc_middle fix link in mir/mod 2024-08-21 00:14:04 +09:00
rustc_mir_build fix: simple typo in compiler directory 2024-08-20 20:50:32 +08:00
rustc_mir_dataflow rename AddressOf -> RawBorrow inside the compiler 2024-08-18 19:46:53 +02:00
rustc_mir_transform Rollup merge of #128628 - khuey:simply-cfg-erase-source-info, r=nnethercote 2024-08-18 23:41:47 -05:00
rustc_monomorphize Don't generate functions with the rustc_intrinsic_must_be_overridden attribute 2024-08-19 06:26:52 +08:00
rustc_next_trait_solver Rollup merge of #128828 - lcnr:search-graph-11, r=compiler-errors 2024-08-14 21:43:07 +08:00
rustc_parse Auto merge of #127672 - compiler-errors:precise-capturing, r=spastorino 2024-08-20 10:42:55 +00:00
rustc_parse_format Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_passes Fix wording of misapplied must_not_suspend error 2024-08-18 20:32:04 +03:00
rustc_pattern_analysis Rollup merge of #128965 - Zalathar:no-pat, r=Nadrieril 2024-08-15 18:44:16 -07:00
rustc_privacy Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_query_impl Prevent double panic in query system, improve diagnostics 2024-08-19 17:42:42 +02:00
rustc_query_system fix: simple typo in compiler directory 2024-08-20 20:50:32 +08:00
rustc_resolve Rollup merge of #129270 - compiler-errors:inner-generics-shadowing, r=petrochenkov 2024-08-20 22:21:57 +02:00
rustc_sanitizers Shrink TyKind::FnPtr. 2024-08-09 14:33:25 +10:00
rustc_serialize Reformat use declarations. 2024-07-29 08:26:52 +10:00
rustc_session Rollup merge of #128348 - dingxiangfei2009:allow-shadow-call-stack-sanitizer, r=tmandry 2024-08-15 19:32:35 +02:00
rustc_smir rename AddressOf -> RawBorrow inside the compiler 2024-08-18 19:46:53 +02:00
rustc_span #[deprecated_safe_2024]: Also use the // TODO: hint in the compiler error 2024-08-13 11:32:47 +02:00
rustc_symbol_mangling Shrink TyKind::FnPtr. 2024-08-09 14:33:25 +10:00
rustc_target Auto merge of #125854 - beetrees:zst-arg-abi, r=estebank 2024-08-18 22:15:41 +00:00
rustc_trait_selection Auto merge of #127672 - compiler-errors:precise-capturing, r=spastorino 2024-08-20 10:42:55 +00:00
rustc_traits Remove redundant type ops 2024-08-14 14:18:17 -04:00
rustc_transmute safe transmute: forbid reference lifetime extension 2024-08-18 18:31:06 +00:00
rustc_ty_utils Rollup merge of #127679 - RalfJung:raw_ref_op, r=jieyouxu 2024-08-18 23:41:46 -05:00
rustc_type_ir Rollup merge of #128828 - lcnr:search-graph-11, r=compiler-errors 2024-08-14 21:43:07 +08:00
rustc_type_ir_macros Reformat use declarations. 2024-07-29 08:26:52 +10:00
stable_mir Reformat use declarations. 2024-07-29 08:26:52 +10:00