rust/compiler
Matthias Krüger 726709bca4
Rollup merge of #116960 - lqd:applied-member-constraints-scope, r=matthewjasper
Location-insensitive polonius: consider a loan escaping if an SCC has member constraints applied only

The location-insensitive analysis considered loans to escape if there were member constraints, which makes *some* sense for scopes and matches the scopes that NLL computes on all the tests.

However, polonius and NLLs differ on the fuzzed case #116657, where an SCC has member constraints but no applied ones (and is kinda surprising). The existing UI tests with member constraints impacting scopes all have some constraint applied.

This PR changes the location-insensitive analysis to consider a loan to escape if there are applied member constraints, and for extra paranoia/insurance via fuzzing and crater: actually checks the constraint's min choice is indeed a universal region as we expect. (This could be turned into a `debug_assert` and early return as a slight optimization after these periods of verification)

The 4 UI tests where member constraints are meaningful for computing scopes still pass obviously, and this also fixes #116657.

r? `@matthewjasper`
2023-10-23 16:23:52 +02:00
..
rustc Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things 2023-09-25 14:38:27 +00:00
rustc_abi s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_arena rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_ast Uplift movability and mutability, the simple way 2023-10-19 16:42:58 +00:00
rustc_ast_lowering Rename CoroutineKind::Gen to ::Coroutine 2023-10-20 21:14:01 +00:00
rustc_ast_passes s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_ast_pretty Auto merge of #116822 - notriddle:notriddle/rust-logo, r=fmease 2023-10-17 04:41:20 +00:00
rustc_attr docs: add Rust logo to more compiler crates 2023-10-16 15:38:08 -07:00
rustc_baked_icu_data docs: add Rust logo to more compiler crates 2023-10-16 15:38:08 -07:00
rustc_borrowck Rollup merge of #116960 - lqd:applied-member-constraints-scope, r=matthewjasper 2023-10-23 16:23:52 +02:00
rustc_builtin_macros Auto merge of #115324 - francorbacho:master, r=davidtwco 2023-10-23 00:51:35 +00:00
rustc_codegen_cranelift Merge commit 'c07d1e2f88cb3b1a0604ae8f18b478c1aeb7a7fa' into sync_cg_clif-2023-10-21 2023-10-21 19:54:51 +00:00
rustc_codegen_gcc s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_codegen_llvm coverage: Emit the filenames section before encoding per-function mappings 2023-10-22 23:17:15 +11:00
rustc_codegen_ssa Rename CoroutineKind::Gen to ::Coroutine 2023-10-20 21:14:01 +00:00
rustc_const_eval Ensure that eval_to_allocation_raw isn't called on static items from miri 2023-10-23 08:35:27 +00:00
rustc_data_structures Auto merge of #116849 - oli-obk:error_shenanigans, r=cjgillot 2023-10-23 09:59:40 +00:00
rustc_driver docs: add Rust logo to more compiler crates 2023-10-16 15:38:08 -07:00
rustc_driver_impl Auto merge of #116814 - estebank:windows-ice-path, r=petrochenkov 2023-10-18 07:45:56 +00:00
rustc_error_codes Replace all uses of generator in markdown documentation with coroutine 2023-10-20 21:14:02 +00:00
rustc_error_messages docs: add Rust logo to more compiler crates 2023-10-16 15:38:08 -07:00
rustc_errors Auto merge of #116962 - estebank:issue-63835, r=oli-obk 2023-10-20 10:52:24 +00:00
rustc_expand Mention the syntax for use on mod foo; if foo doesn't exist 2023-10-21 15:56:01 +00:00
rustc_feature Re-add generators as a removed feature and point to the new feature name 2023-10-20 21:14:02 +00:00
rustc_fluent_macro Use v0.0.0 in compiler crates 2023-10-18 21:55:15 +00:00
rustc_fs_util
rustc_graphviz rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_hir Rename CoroutineKind::Gen to ::Coroutine 2023-10-20 21:14:01 +00:00
rustc_hir_analysis Auto merge of #116849 - oli-obk:error_shenanigans, r=cjgillot 2023-10-23 09:59:40 +00:00
rustc_hir_pretty Fiddle with State functions. 2023-10-11 10:46:55 +11:00
rustc_hir_typeck Rollup merge of #106601 - estebank:match-semi, r=cjgillot 2023-10-21 13:58:33 +02:00
rustc_incremental Auto merge of #115964 - bjorn3:cgu_reuse_tracker_global_state, r=cjgillot 2023-10-13 00:09:30 +00:00
rustc_index Preserve DebugInfo in DeadStoreElimination. 2023-10-06 15:46:11 +00:00
rustc_infer Rollup merge of #106601 - estebank:match-semi, r=cjgillot 2023-10-21 13:58:33 +02:00
rustc_interface s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_lexer Use v0.0.0 in compiler crates 2023-10-18 21:55:15 +00:00
rustc_lint s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_lint_defs Auto merge of #116734 - Nadrieril:lint-per-column, r=cjgillot 2023-10-21 11:04:19 +00:00
rustc_llvm rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_log use env variable to control thread ids in rustc_log 2023-10-10 09:39:47 +08:00
rustc_macros Allow ensure queries to return Result<(), ErrorGuaranteed> 2023-10-23 08:20:29 +00:00
rustc_metadata s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_middle Auto merge of #116849 - oli-obk:error_shenanigans, r=cjgillot 2023-10-23 09:59:40 +00:00
rustc_mir_build Fix #117033 2023-10-21 23:04:17 +02:00
rustc_mir_dataflow s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_mir_transform Rollup merge of #116974 - Zalathar:signature-spans, r=oli-obk,cjgillot 2023-10-21 10:08:17 +02:00
rustc_monomorphize coverage: Change query codegened_and_inlined_items to a plain function 2023-10-21 12:20:05 +11:00
rustc_parse s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_parse_format rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_passes s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_plugin_impl rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_privacy s/Generator/Coroutine/ 2023-10-20 21:10:38 +00:00
rustc_query_impl rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_query_system fix broken link: update incremental compilation url 2023-10-22 07:20:36 -07:00
rustc_resolve Rollup merge of #116961 - estebank:issue-60164, r=oli-obk 2023-10-21 10:08:16 +02:00
rustc_serialize rustdoc: remove rust logo from non-Rust crates 2023-10-08 20:17:53 -07:00
rustc_session Rollup merge of #116960 - lqd:applied-member-constraints-scope, r=matthewjasper 2023-10-23 16:23:52 +02:00
rustc_smir Rollup merge of #116964 - celinval:smir-mono-body, r=oli-obk 2023-10-21 10:08:17 +02:00
rustc_span Auto merge of #116849 - oli-obk:error_shenanigans, r=cjgillot 2023-10-23 09:59:40 +00:00
rustc_symbol_mangling s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_target add target csky-unknown-linux-gnuabiv2hf 2023-10-22 21:20:30 +08:00
rustc_trait_selection fix spans for removing .await on for expressions 2023-10-21 13:18:00 +02:00
rustc_traits Detect cycle errors hidden by opaques during monomorphization 2023-09-13 17:35:44 +00:00
rustc_transmute Use v0.0.0 in compiler crates 2023-10-18 21:55:15 +00:00
rustc_ty_utils s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
rustc_type_ir s/generator/coroutine/ 2023-10-20 21:14:01 +00:00
stable_mir Rollup merge of #116964 - celinval:smir-mono-body, r=oli-obk 2023-10-21 10:08:17 +02:00