mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
43ad753adb
Relax SeqCst ordering in standard library. Every single SeqCst in the standard library is unnecessary. In all cases, Relaxed or Release+Acquire was sufficient. As I [wrote](https://marabos.nl/atomics/memory-ordering.html#common-misconceptions) in my book on atomics: > [..] when reading code, SeqCst basically tells the reader: "this operation depends on the total order of every single SeqCst operation in the program," which is an incredibly far-reaching claim. The same code would likely be easier to review and verify if it used weaker memory ordering instead, if possible. For example, Release effectively tells the reader: "this relates to an acquire operation on the same variable," which involves far fewer considerations when forming an understanding of the code. > > It is advisable to see SeqCst as a warning sign. Seeing it in the wild often means that either something complicated is going on, or simply that the author did not take the time to analyze their memory ordering related assumptions, both of which are reasons for extra scrutiny. r? ````@Amanieu```` ````@joboet```` |
||
|---|---|---|
| .. | ||
| alloc | ||
| boxed | ||
| collections | ||
| ffi | ||
| raw_vec | ||
| rc | ||
| slice | ||
| sync | ||
| testing | ||
| vec | ||
| alloc.rs | ||
| borrow.rs | ||
| boxed.rs | ||
| fmt.rs | ||
| lib.rs | ||
| macros.rs | ||
| raw_vec.rs | ||
| rc.rs | ||
| slice.rs | ||
| str.rs | ||
| string.rs | ||
| sync.rs | ||
| task.rs | ||
| tests.rs | ||