mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-02 04:57:35 +00:00

Error codes are integers, but `String` is used everywhere to represent them. Gross! This commit introduces `ErrCode`, an integral newtype for error codes, replacing `String`. It also introduces a constant for every error code, e.g. `E0123`, and removes the `error_code!` macro. The constants are imported wherever used with `use rustc_errors::codes::*`. With the old code, we have three different ways to specify an error code at a use point: ``` error_code!(E0123) // macro call struct_span_code_err!(dcx, span, E0123, "msg"); // bare ident arg to macro call \#[diag(name, code = "E0123")] // string struct Diag; ``` With the new code, they all use the `E0123` constant. ``` E0123 // constant struct_span_code_err!(dcx, span, E0123, "msg"); // constant \#[diag(name, code = E0123)] // constant struct Diag; ``` The commit also changes the structure of the error code definitions: - `rustc_error_codes` now just defines a higher-order macro listing the used error codes and nothing else. - Because that's now the only thing in the `rustc_error_codes` crate, I moved it into the `lib.rs` file and removed the `error_codes.rs` file. - `rustc_errors` uses that macro to define everything, e.g. the error code constants and the `DIAGNOSTIC_TABLES`. This is in its new `codes.rs` file.
446 lines
16 KiB
Rust
446 lines
16 KiB
Rust
use crate::diagnostic::IntoDiagnosticArg;
|
|
use crate::{DiagCtxt, Level, MultiSpan, StashKey};
|
|
use crate::{
|
|
Diagnostic, DiagnosticMessage, DiagnosticStyledString, ErrCode, ErrorGuaranteed, ExplicitBug,
|
|
SubdiagnosticMessage,
|
|
};
|
|
use rustc_lint_defs::Applicability;
|
|
use rustc_span::source_map::Spanned;
|
|
|
|
use rustc_span::Span;
|
|
use std::borrow::Cow;
|
|
use std::fmt::{self, Debug};
|
|
use std::marker::PhantomData;
|
|
use std::ops::{Deref, DerefMut};
|
|
use std::panic;
|
|
use std::thread::panicking;
|
|
|
|
/// Trait implemented by error types. This is rarely implemented manually. Instead, use
|
|
/// `#[derive(Diagnostic)]` -- see [rustc_macros::Diagnostic].
|
|
#[rustc_diagnostic_item = "IntoDiagnostic"]
|
|
pub trait IntoDiagnostic<'a, G: EmissionGuarantee = ErrorGuaranteed> {
|
|
/// Write out as a diagnostic out of `DiagCtxt`.
|
|
#[must_use]
|
|
fn into_diagnostic(self, dcx: &'a DiagCtxt, level: Level) -> DiagnosticBuilder<'a, G>;
|
|
}
|
|
|
|
impl<'a, T, G> IntoDiagnostic<'a, G> for Spanned<T>
|
|
where
|
|
T: IntoDiagnostic<'a, G>,
|
|
G: EmissionGuarantee,
|
|
{
|
|
fn into_diagnostic(self, dcx: &'a DiagCtxt, level: Level) -> DiagnosticBuilder<'a, G> {
|
|
self.node.into_diagnostic(dcx, level).with_span(self.span)
|
|
}
|
|
}
|
|
|
|
/// Used for emitting structured error messages and other diagnostic information.
|
|
/// Each constructed `DiagnosticBuilder` must be consumed by a function such as
|
|
/// `emit`, `cancel`, `delay_as_bug`, or `into_diagnostic`. A panic occurrs if a
|
|
/// `DiagnosticBuilder` is dropped without being consumed by one of these
|
|
/// functions.
|
|
///
|
|
/// If there is some state in a downstream crate you would like to
|
|
/// access in the methods of `DiagnosticBuilder` here, consider
|
|
/// extending `DiagCtxtFlags`.
|
|
#[must_use]
|
|
pub struct DiagnosticBuilder<'a, G: EmissionGuarantee = ErrorGuaranteed> {
|
|
pub dcx: &'a DiagCtxt,
|
|
|
|
/// Why the `Option`? It is always `Some` until the `DiagnosticBuilder` is
|
|
/// consumed via `emit`, `cancel`, etc. At that point it is consumed and
|
|
/// replaced with `None`. Then `drop` checks that it is `None`; if not, it
|
|
/// panics because a diagnostic was built but not used.
|
|
///
|
|
/// Why the Box? `Diagnostic` is a large type, and `DiagnosticBuilder` is
|
|
/// often used as a return value, especially within the frequently-used
|
|
/// `PResult` type. In theory, return value optimization (RVO) should avoid
|
|
/// unnecessary copying. In practice, it does not (at the time of writing).
|
|
diag: Option<Box<Diagnostic>>,
|
|
|
|
_marker: PhantomData<G>,
|
|
}
|
|
|
|
// Cloning a `DiagnosticBuilder` is a recipe for a diagnostic being emitted
|
|
// twice, which would be bad.
|
|
impl<G> !Clone for DiagnosticBuilder<'_, G> {}
|
|
|
|
rustc_data_structures::static_assert_size!(
|
|
DiagnosticBuilder<'_, ()>,
|
|
2 * std::mem::size_of::<usize>()
|
|
);
|
|
|
|
/// Trait for types that `DiagnosticBuilder::emit` can return as a "guarantee"
|
|
/// (or "proof") token that the emission happened.
|
|
pub trait EmissionGuarantee: Sized {
|
|
/// This exists so that bugs and fatal errors can both result in `!` (an
|
|
/// abort) when emitted, but have different aborting behaviour.
|
|
type EmitResult = Self;
|
|
|
|
/// Implementation of `DiagnosticBuilder::emit`, fully controlled by each
|
|
/// `impl` of `EmissionGuarantee`, to make it impossible to create a value
|
|
/// of `Self::EmitResult` without actually performing the emission.
|
|
#[track_caller]
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult;
|
|
}
|
|
|
|
impl<'a, G: EmissionGuarantee> DiagnosticBuilder<'a, G> {
|
|
/// Takes the diagnostic. For use by methods that consume the
|
|
/// DiagnosticBuilder: `emit`, `cancel`, etc. Afterwards, `drop` is the
|
|
/// only code that will be run on `self`.
|
|
fn take_diag(&mut self) -> Diagnostic {
|
|
Box::into_inner(self.diag.take().unwrap())
|
|
}
|
|
|
|
/// Most `emit_producing_guarantee` functions use this as a starting point.
|
|
fn emit_producing_nothing(mut self) {
|
|
let diag = self.take_diag();
|
|
self.dcx.emit_diagnostic(diag);
|
|
}
|
|
|
|
/// `ErrorGuaranteed::emit_producing_guarantee` uses this.
|
|
// FIXME(eddyb) make `ErrorGuaranteed` impossible to create outside `.emit()`.
|
|
fn emit_producing_error_guaranteed(mut self) -> ErrorGuaranteed {
|
|
let diag = self.take_diag();
|
|
|
|
// Only allow a guarantee if the `level` wasn't switched to a
|
|
// non-error. The field isn't `pub`, but the whole `Diagnostic` can be
|
|
// overwritten with a new one, thanks to `DerefMut`.
|
|
assert!(
|
|
diag.is_error(),
|
|
"emitted non-error ({:?}) diagnostic from `DiagnosticBuilder<ErrorGuaranteed>`",
|
|
diag.level,
|
|
);
|
|
|
|
let guar = self.dcx.emit_diagnostic(diag);
|
|
guar.unwrap()
|
|
}
|
|
}
|
|
|
|
impl EmissionGuarantee for ErrorGuaranteed {
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult {
|
|
db.emit_producing_error_guaranteed()
|
|
}
|
|
}
|
|
|
|
impl EmissionGuarantee for () {
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult {
|
|
db.emit_producing_nothing();
|
|
}
|
|
}
|
|
|
|
/// Marker type which enables implementation of `create_bug` and `emit_bug` functions for
|
|
/// bug diagnostics.
|
|
#[derive(Copy, Clone)]
|
|
pub struct BugAbort;
|
|
|
|
impl EmissionGuarantee for BugAbort {
|
|
type EmitResult = !;
|
|
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult {
|
|
db.emit_producing_nothing();
|
|
panic::panic_any(ExplicitBug);
|
|
}
|
|
}
|
|
|
|
/// Marker type which enables implementation of `create_fatal` and `emit_fatal` functions for
|
|
/// fatal diagnostics.
|
|
#[derive(Copy, Clone)]
|
|
pub struct FatalAbort;
|
|
|
|
impl EmissionGuarantee for FatalAbort {
|
|
type EmitResult = !;
|
|
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult {
|
|
db.emit_producing_nothing();
|
|
crate::FatalError.raise()
|
|
}
|
|
}
|
|
|
|
impl EmissionGuarantee for rustc_span::fatal_error::FatalError {
|
|
fn emit_producing_guarantee(db: DiagnosticBuilder<'_, Self>) -> Self::EmitResult {
|
|
db.emit_producing_nothing();
|
|
rustc_span::fatal_error::FatalError
|
|
}
|
|
}
|
|
|
|
/// `DiagnosticBuilder` impls `DerefMut`, which allows access to the fields and
|
|
/// methods of the embedded `Diagnostic`. However, that doesn't allow method
|
|
/// chaining at the `DiagnosticBuilder` level. Each use of this macro defines
|
|
/// two builder methods at that level, both of which wrap the equivalent method
|
|
/// in `Diagnostic`.
|
|
/// - A `&mut self -> &mut Self` method, with the same name as the underlying
|
|
/// `Diagnostic` method. It is mostly to modify existing diagnostics, either
|
|
/// in a standalone fashion, e.g. `err.code(code)`, or in a chained fashion
|
|
/// to make multiple modifications, e.g. `err.code(code).span(span)`.
|
|
/// - A `self -> Self` method, which has a `with_` prefix added.
|
|
/// It is mostly used in a chained fashion when producing a new diagnostic,
|
|
/// e.g. `let err = struct_err(msg).with_code(code)`, or when emitting a new
|
|
/// diagnostic , e.g. `struct_err(msg).with_code(code).emit()`.
|
|
///
|
|
/// Although the latter method can be used to modify an existing diagnostic,
|
|
/// e.g. `err = err.with_code(code)`, this should be avoided because the former
|
|
/// method gives shorter code, e.g. `err.code(code)`.
|
|
macro_rules! forward {
|
|
(
|
|
($f:ident, $with_f:ident)($($name:ident: $ty:ty),* $(,)?)
|
|
) => {
|
|
#[doc = concat!("See [`Diagnostic::", stringify!($f), "()`].")]
|
|
pub fn $f(&mut self, $($name: $ty),*) -> &mut Self {
|
|
self.diag.as_mut().unwrap().$f($($name),*);
|
|
self
|
|
}
|
|
#[doc = concat!("See [`Diagnostic::", stringify!($f), "()`].")]
|
|
pub fn $with_f(mut self, $($name: $ty),*) -> Self {
|
|
self.diag.as_mut().unwrap().$f($($name),*);
|
|
self
|
|
}
|
|
};
|
|
}
|
|
|
|
impl<G: EmissionGuarantee> Deref for DiagnosticBuilder<'_, G> {
|
|
type Target = Diagnostic;
|
|
|
|
fn deref(&self) -> &Diagnostic {
|
|
self.diag.as_ref().unwrap()
|
|
}
|
|
}
|
|
|
|
impl<G: EmissionGuarantee> DerefMut for DiagnosticBuilder<'_, G> {
|
|
fn deref_mut(&mut self) -> &mut Diagnostic {
|
|
self.diag.as_mut().unwrap()
|
|
}
|
|
}
|
|
|
|
impl<'a, G: EmissionGuarantee> DiagnosticBuilder<'a, G> {
|
|
#[rustc_lint_diagnostics]
|
|
#[track_caller]
|
|
pub fn new<M: Into<DiagnosticMessage>>(dcx: &'a DiagCtxt, level: Level, message: M) -> Self {
|
|
Self::new_diagnostic(dcx, Diagnostic::new(level, message))
|
|
}
|
|
|
|
/// Creates a new `DiagnosticBuilder` with an already constructed
|
|
/// diagnostic.
|
|
#[track_caller]
|
|
pub(crate) fn new_diagnostic(dcx: &'a DiagCtxt, diag: Diagnostic) -> Self {
|
|
debug!("Created new diagnostic");
|
|
Self { dcx, diag: Some(Box::new(diag)), _marker: PhantomData }
|
|
}
|
|
|
|
/// Emit and consume the diagnostic.
|
|
#[track_caller]
|
|
pub fn emit(self) -> G::EmitResult {
|
|
G::emit_producing_guarantee(self)
|
|
}
|
|
|
|
/// Emit the diagnostic unless `delay` is true,
|
|
/// in which case the emission will be delayed as a bug.
|
|
///
|
|
/// See `emit` and `delay_as_bug` for details.
|
|
#[track_caller]
|
|
pub fn emit_unless(mut self, delay: bool) -> G::EmitResult {
|
|
if delay {
|
|
self.downgrade_to_delayed_bug();
|
|
}
|
|
self.emit()
|
|
}
|
|
|
|
/// Cancel and consume the diagnostic. (A diagnostic must either be emitted or
|
|
/// cancelled or it will panic when dropped).
|
|
pub fn cancel(mut self) {
|
|
self.diag = None;
|
|
drop(self);
|
|
}
|
|
|
|
/// Stashes diagnostic for possible later improvement in a different,
|
|
/// later stage of the compiler. The diagnostic can be accessed with
|
|
/// the provided `span` and `key` through [`DiagCtxt::steal_diagnostic()`].
|
|
pub fn stash(self, span: Span, key: StashKey) {
|
|
self.dcx.stash_diagnostic(span, key, self.into_diagnostic());
|
|
}
|
|
|
|
/// Converts the builder to a `Diagnostic` for later emission.
|
|
pub fn into_diagnostic(mut self) -> Diagnostic {
|
|
self.take_diag()
|
|
}
|
|
|
|
/// Delay emission of this diagnostic as a bug.
|
|
///
|
|
/// This can be useful in contexts where an error indicates a bug but
|
|
/// typically this only happens when other compilation errors have already
|
|
/// happened. In those cases this can be used to defer emission of this
|
|
/// diagnostic as a bug in the compiler only if no other errors have been
|
|
/// emitted.
|
|
///
|
|
/// In the meantime, though, callsites are required to deal with the "bug"
|
|
/// locally in whichever way makes the most sense.
|
|
#[track_caller]
|
|
pub fn delay_as_bug(mut self) -> G::EmitResult {
|
|
self.downgrade_to_delayed_bug();
|
|
self.emit()
|
|
}
|
|
|
|
forward!((span_label, with_span_label)(
|
|
span: Span,
|
|
label: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((span_labels, with_span_labels)(
|
|
spans: impl IntoIterator<Item = Span>,
|
|
label: &str,
|
|
));
|
|
forward!((note_expected_found, with_note_expected_found)(
|
|
expected_label: &dyn fmt::Display,
|
|
expected: DiagnosticStyledString,
|
|
found_label: &dyn fmt::Display,
|
|
found: DiagnosticStyledString,
|
|
));
|
|
forward!((note_expected_found_extra, with_note_expected_found_extra)(
|
|
expected_label: &dyn fmt::Display,
|
|
expected: DiagnosticStyledString,
|
|
found_label: &dyn fmt::Display,
|
|
found: DiagnosticStyledString,
|
|
expected_extra: &dyn fmt::Display,
|
|
found_extra: &dyn fmt::Display,
|
|
));
|
|
forward!((note, with_note)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((note_once, with_note_once)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((span_note, with_span_note)(
|
|
sp: impl Into<MultiSpan>,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((span_note_once, with_span_note_once)(
|
|
sp: impl Into<MultiSpan>,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((warn, with_warn)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((span_warn, with_span_warn)(
|
|
sp: impl Into<MultiSpan>,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((help, with_help)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((help_once, with_help_once)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((span_help, with_span_help_once)(
|
|
sp: impl Into<MultiSpan>,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
));
|
|
forward!((multipart_suggestion, with_multipart_suggestion)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: Vec<(Span, String)>,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((multipart_suggestion_verbose, with_multipart_suggestion_verbose)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: Vec<(Span, String)>,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((tool_only_multipart_suggestion, with_tool_only_multipart_suggestion)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: Vec<(Span, String)>,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((span_suggestion, with_span_suggestion)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: impl ToString,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((span_suggestions, with_span_suggestions)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestions: impl IntoIterator<Item = String>,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((multipart_suggestions, with_multipart_suggestions)(
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestions: impl IntoIterator<Item = Vec<(Span, String)>>,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((span_suggestion_short, with_span_suggestion_short)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: impl ToString,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((span_suggestion_verbose, with_span_suggestion_verbose)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: impl ToString,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((span_suggestion_hidden, with_span_suggestion_hidden)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: impl ToString,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((tool_only_span_suggestion, with_tool_only_span_suggestion)(
|
|
sp: Span,
|
|
msg: impl Into<SubdiagnosticMessage>,
|
|
suggestion: impl ToString,
|
|
applicability: Applicability,
|
|
));
|
|
forward!((primary_message, with_primary_message)(
|
|
msg: impl Into<DiagnosticMessage>,
|
|
));
|
|
forward!((span, with_span)(
|
|
sp: impl Into<MultiSpan>,
|
|
));
|
|
forward!((is_lint, with_is_lint)(
|
|
name: String, has_future_breakage: bool,
|
|
));
|
|
forward!((code, with_code)(
|
|
code: ErrCode,
|
|
));
|
|
forward!((arg, with_arg)(
|
|
name: impl Into<Cow<'static, str>>, arg: impl IntoDiagnosticArg,
|
|
));
|
|
forward!((subdiagnostic, with_subdiagnostic)(
|
|
subdiagnostic: impl crate::AddToDiagnostic,
|
|
));
|
|
forward!((eager_subdiagnostic, with_eager_subdiagnostic)(
|
|
dcx: &DiagCtxt,
|
|
subdiagnostic: impl crate::AddToDiagnostic,
|
|
));
|
|
}
|
|
|
|
impl<G: EmissionGuarantee> Debug for DiagnosticBuilder<'_, G> {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
self.diag.fmt(f)
|
|
}
|
|
}
|
|
|
|
/// Destructor bomb: every `DiagnosticBuilder` must be consumed (emitted,
|
|
/// cancelled, etc.) or we emit a bug.
|
|
impl<G: EmissionGuarantee> Drop for DiagnosticBuilder<'_, G> {
|
|
fn drop(&mut self) {
|
|
match self.diag.take() {
|
|
Some(diag) if !panicking() => {
|
|
self.dcx.emit_diagnostic(Diagnostic::new(
|
|
Level::Bug,
|
|
DiagnosticMessage::from("the following error was constructed but not emitted"),
|
|
));
|
|
self.dcx.emit_diagnostic(*diag);
|
|
panic!("error was constructed but not emitted");
|
|
}
|
|
_ => {}
|
|
}
|
|
}
|
|
}
|
|
|
|
#[macro_export]
|
|
macro_rules! struct_span_code_err {
|
|
($dcx:expr, $span:expr, $code:expr, $($message:tt)*) => ({
|
|
$dcx.struct_span_err($span, format!($($message)*)).with_code($code)
|
|
})
|
|
}
|