rust/compiler
Aaron Hill 40c6d838cd
Don't cache results of coinductive cycle
Fixes #96319

The logic around handling co-inductive cycles in the evaluation cache
is confusing and error prone. Fortunately, a perf run showed that it
doesn't actually appear to improve performance, so we can simplify
this code (and eliminate a source of ICEs) by just skipping caching
the evaluation results for co-inductive cycle participants.

This commit makes no changes to any of the other logic around
co-inductive cycle handling. Thus, while this commit could
potentially expose latent bugs that were being hidden by
caching, it should not introduce any new bugs.
2022-05-05 14:01:35 -04:00
..
rustc Propagate parallel_compiler feature through rustc crates. Turned off feature gives change of builded crates: 238 -> 224. 2022-03-28 08:41:12 +03:00
rustc_apfloat Addressed comments by @compiler-errors and @bjorn3 2022-03-30 17:04:46 -04:00
rustc_arena mark FIXMES for all the places found that are probably offset_from 2022-03-29 20:18:28 -04:00
rustc_ast Auto merge of #96546 - nnethercote:overhaul-MacArgs, r=petrochenkov 2022-05-04 21:16:28 +00:00
rustc_ast_lowering Auto merge of #96546 - nnethercote:overhaul-MacArgs, r=petrochenkov 2022-05-04 21:16:28 +00:00
rustc_ast_passes Feature-gate do yeet inside cfgs too 2022-04-30 18:10:01 -07:00
rustc_ast_pretty Rollup merge of #96628 - joshtriplett:stabilize-then-some, r=m-ou-se 2022-05-05 10:20:35 +09:00
rustc_attr Rollup merge of #94948 - jhpratt:rustc_deprecated, r=Dylan-DPC 2022-03-20 09:14:59 +01:00
rustc_borrowck Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_builtin_macros Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister 2022-05-05 12:26:38 +00:00
rustc_codegen_cranelift Merge commit 'f2cdd4a78d89c009342197cf5844a21f8aa813df' into sync_cg_clif-2022-04-22 2022-04-22 21:11:38 +02:00
rustc_codegen_gcc Merge new_metadata into codegen_allocator 2022-04-30 21:20:08 +02:00
rustc_codegen_llvm Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_codegen_ssa Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister 2022-05-05 12:26:38 +00:00
rustc_const_eval Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_data_structures Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_driver errors: lazily load fallback fluent bundle 2022-04-13 02:44:59 +01:00
rustc_error_codes Remove ``` `ignore``` from E0705 test 2022-04-30 10:48:38 -05:00
rustc_error_messages macros: subdiagnostic derive 2022-04-29 02:05:20 +01:00
rustc_errors macros: subdiagnostic derive 2022-04-29 02:05:20 +01:00
rustc_expand Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister 2022-05-05 12:26:38 +00:00
rustc_feature Add support for a new attribute #[debugger_visualizer] to support embedding debugger visualizers into a generated PDB. 2022-05-03 10:53:54 -07:00
rustc_fs_util
rustc_graphviz eplace usages of vec![].into_iter with [].into_iter 2022-01-09 14:09:25 +11:00
rustc_hir Auto merge of #95380 - compiler-errors:unit-destructure-assign, r=nikomatsakis 2022-05-03 22:29:58 +00:00
rustc_hir_pretty Store all generic bounds as where predicates. 2022-04-30 13:55:13 +02:00
rustc_incremental Rollup merge of #95434 - cjgillot:dump-dep-kind, r=oli-obk 2022-04-21 20:55:18 +02:00
rustc_index Add element iterator for ChunkedBitSet 2022-04-30 16:40:49 +02:00
rustc_infer Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_interface Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_lexer Reduce max hash in raw strings from u16 to u8 2022-03-23 22:13:55 +01:00
rustc_lint Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_lint_defs Plumb through rustc_lint_defs::Level as enum rather than string. 2022-04-27 10:04:25 -07:00
rustc_llvm RustWrapper: explicitly don't handle DXILPointerTyID 2022-04-28 13:53:52 -04:00
rustc_log Make rustc_log doc test runnable 2022-01-03 22:31:56 -08:00
rustc_macros macros: add interop between diagnostic derives 2022-04-29 02:12:10 +01:00
rustc_metadata Add support for a new attribute #[debugger_visualizer] to support embedding debugger visualizers into a generated PDB. 2022-05-03 10:53:54 -07:00
rustc_middle Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister 2022-05-05 12:26:38 +00:00
rustc_mir_build Rollup merge of #96628 - joshtriplett:stabilize-then-some, r=m-ou-se 2022-05-05 10:20:35 +09:00
rustc_mir_dataflow Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_mir_transform re-name stuff 2022-05-01 15:38:22 +03:00
rustc_monomorphize Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_parse Auto merge of #96546 - nnethercote:overhaul-MacArgs, r=petrochenkov 2022-05-04 21:16:28 +00:00
rustc_parse_format Make rustc_parse_format compile on stable 2022-05-03 11:26:58 +02:00
rustc_passes Cleanup broken doc links. 2022-05-04 17:17:57 -07:00
rustc_plugin_impl
rustc_privacy rustc: Panic by default in DefIdTree::parent 2022-05-02 01:56:50 +03:00
rustc_query_impl Enable tracing for all queryies 2022-05-04 16:15:26 +00:00
rustc_query_system Rollup merge of #96697 - oli-obk:trace_queries, r=michaelwoerister 2022-05-05 10:20:38 +09:00
rustc_resolve Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_save_analysis rustc: Panic by default in DefIdTree::parent 2022-05-02 01:56:50 +03:00
rustc_serialize Remove unused macro rules 2022-04-18 23:28:06 +02:00
rustc_session Rollup merge of #96433 - petrochenkov:delim, r=nnethercote 2022-04-28 20:13:02 +02:00
rustc_span Auto merge of #91779 - ridwanabdillahi:natvis, r=michaelwoerister 2022-05-05 12:26:38 +00:00
rustc_symbol_mangling Auto merge of #95655 - kckeiks:create-hir-crate-items-query, r=cjgillot 2022-04-17 08:06:53 +00:00
rustc_target Stabilize bool::then_some 2022-05-04 13:22:08 +02:00
rustc_trait_selection Don't cache results of coinductive cycle 2022-05-05 14:01:35 -04:00
rustc_traits Remove opaque type obligation and just register opaque types as they are encountered. 2022-03-28 16:57:45 +00:00
rustc_ty_utils Avoid accessing HIR from MIR queries. 2022-04-10 13:08:36 +02:00
rustc_type_ir Revert "Auto merge of #93893 - oli-obk:sad_revert, r=oli-obk" 2022-03-28 16:27:14 +00:00
rustc_typeck Stabilize bool::then_some 2022-05-04 13:22:08 +02:00