mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-12 18:07:40 +00:00
7b21c18fe4
Automatically taint InferCtxt when errors are emitted r? `@nnethercote` Basically `InferCtxt::dcx` now returns a `DiagCtxt` that refers back to the `Cell<Option<ErrorGuaranteed>>` of the `InferCtxt` and thus when invoking `Diag::emit`, and the diagnostic is an error, we taint the `InferCtxt` directly. That change on its own has no effect at all, because `InferCtxt` already tracks whether errors have been emitted by recording the global error count when it gets opened, and checking at the end whether the count changed. So I removed that error count check, which had a bit of fallout that I immediately fixed by invoking `InferCtxt::dcx` instead of `TyCtxt::dcx` in a bunch of places. The remaining new errors are because an error was reported in another query, and never bubbled up. I think they are minor enough for this to be ok, and sometimes it actually improves diagnostics, by not silencing useful diagnostics anymore. fixes #126485 (cc `@olafes)` There are more improvements we can do (like tainting in hir ty lowering), but I would rather do that in follow up PRs, because it requires some refactorings. |
||
|---|---|---|
| .. | ||
| framework | ||
| impls | ||
| move_paths | ||
| debuginfo.rs | ||
| drop_flag_effects.rs | ||
| elaborate_drops.rs | ||
| errors.rs | ||
| lib.rs | ||
| points.rs | ||
| rustc_peek.rs | ||
| storage.rs | ||
| un_derefer.rs | ||
| value_analysis.rs | ||