mirror of
https://github.com/rust-lang/rust.git
synced 2025-02-10 05:53:10 +00:00
36f5d122b8
This commit takes a first pass at stabilizing `std::thread`: * It removes the `detach` method in favor of two constructors -- `spawn` for detached threads, `scoped` for "scoped" (i.e., must-join) threads. This addresses some of the surprise/frustrating debug sessions with the previous API, in which `spawn` produced a guard that on destruction joined the thread (unless `detach` was called). The reason to have the division in part is that `Send` will soon not imply `'static`, which means that `scoped` thread creation can take a closure over *shared stack data* of the parent thread. On the other hand, this means that the parent must not pop the relevant stack frames while the child thread is running. The `JoinGuard` is used to prevent this from happening by joining on drop (if you have not already explicitly `join`ed.) The APIs around `scoped` are future-proofed for the `Send` changes by taking an additional lifetime parameter. With the current definition of `Send`, this is forced to be `'static`, but when `Send` changes these APIs will gain their full flexibility immediately. Threads that are `spawn`ed, on the other hand, are detached from the start and do not yield an RAII guard. The hope is that, by making `scoped` an explicit opt-in with a very suggestive name, it will be drastically less likely to be caught by a surprising deadlock due to an implicit join at the end of a scope. * The module itself is marked stable. * Existing methods other than `spawn` and `scoped` are marked stable. The migration path is: ```rust Thread::spawn(f).detached() ``` becomes ```rust Thread::spawn(f) ``` while ```rust let res = Thread::spawn(f); res.join() ``` becomes ```rust let res = Thread::scoped(f); res.join() ``` [breaking-change] |
||
|---|---|---|
| .. | ||
| compiler-rt@62a4ca6055 | ||
| compiletest | ||
| doc | ||
| driver | ||
| etc | ||
| grammar | ||
| jemalloc@b001609960 | ||
| liballoc | ||
| libarena | ||
| libbacktrace | ||
| libcollections | ||
| libcore | ||
| libcoretest | ||
| libflate | ||
| libfmt_macros | ||
| libgetopts | ||
| libgraphviz | ||
| liblibc | ||
| liblog | ||
| librand | ||
| librbml | ||
| libregex | ||
| librustc | ||
| librustc_back | ||
| librustc_borrowck | ||
| librustc_driver | ||
| librustc_llvm | ||
| librustc_resolve | ||
| librustc_trans | ||
| librustc_typeck | ||
| librustdoc | ||
| libserialize | ||
| libstd | ||
| libsyntax | ||
| libterm | ||
| libtest | ||
| libunicode | ||
| llvm@ec1fdb3b9d | ||
| rt | ||
| rust-installer@3a37981744 | ||
| rustllvm | ||
| test | ||
| snapshots.txt | ||