mirror of
https://github.com/rust-lang/rust.git
synced 2025-04-29 03:27:44 +00:00
781111ef35
Each of `{D,Subd}iagnosticMessage::{Str,Eager}` has a comment:
```
// FIXME(davidtwco): can a `Cow<'static, str>` be used here?
```
This commit answers that question in the affirmative. It's not the most
compelling change ever, but it might be worth merging.
This requires changing the `impl<'a> From<&'a str>` impls to `impl
From<&'static str>`, which involves a bunch of knock-on changes that
require/result in call sites being a little more precise about exactly
what kind of string they use to create errors, and not just `&str`. This
will result in fewer unnecessary allocations, though this will not have
any notable perf effects given that these are error paths.
Note that I was lazy within Clippy, using `to_string` in a few places to
preserve the existing string imprecision. I could have used `impl
Into<{D,Subd}iagnosticMessage>` in various places as is done in the
compiler, but that would have required changes to *many* call sites
(mostly changing `&format("...")` to `format!("...")`) which didn't seem
worthwhile.
|
||
|---|---|---|
| .. | ||
| json | ||
| annotate_snippet_emitter_writer.rs | ||
| diagnostic_builder.rs | ||
| diagnostic_impls.rs | ||
| diagnostic.rs | ||
| emitter.rs | ||
| error.rs | ||
| json.rs | ||
| lib.rs | ||
| lock.rs | ||
| registry.rs | ||
| snippet.rs | ||
| styled_buffer.rs | ||
| tests.rs | ||
| translation.rs | ||