mirror of
https://github.com/rust-lang/rust.git
synced 2025-05-14 02:49:40 +00:00
01fbc5ae78
Pass on null handle values to child process Fixes #101645 In Windows, stdio handles are (semantically speaking) `Option<Handle>` where `Handle` is a non-zero value. When spawning a process with `Stdio::Inherit`, Rust currently turns zero values into `-1` values. This has the unfortunate effect of breaking console subprocesses (which typically need stdio) that are spawned from gui applications (that lack stdio by default) because the console process won't be assigned handles from the newly created console (as they usually would in that situation). Worse, `-1` is actually [a valid handle](https://doc.rust-lang.org/std/os/windows/io/struct.OwnedHandle.html) which means "the current process". So if a console process, for example, waits on stdin and it has a `-1` value then the process will end up waiting on itself. This PR fixes it by propagating the nulls instead of converting them to `-1`. While I think the current behaviour is a mistake, changing it (however justified) is an API change so I think this PR should at least have some input from t-libs-api. So choosing at random... r? `@joshtriplett` |
||
|---|---|---|
| .. | ||
| alloc | ||
| args | ||
| c | ||
| handle | ||
| locks | ||
| os | ||
| path | ||
| process | ||
| thread_local_key | ||
| alloc.rs | ||
| args.rs | ||
| c.rs | ||
| cmath.rs | ||
| compat.rs | ||
| env.rs | ||
| fs.rs | ||
| handle.rs | ||
| io.rs | ||
| memchr.rs | ||
| mod.rs | ||
| net.rs | ||
| os_str.rs | ||
| os.rs | ||
| path.rs | ||
| pipe.rs | ||
| process.rs | ||
| rand.rs | ||
| stack_overflow_uwp.rs | ||
| stack_overflow.rs | ||
| stdio.rs | ||
| thread_local_dtor.rs | ||
| thread_local_key.rs | ||
| thread_parker.rs | ||
| thread.rs | ||
| time.rs | ||