Nicholas Nethercote 2d91c6d1bf Remove DiagnosticBuilderState. ... Currently it's used for two dynamic checks: - When a diagnostic is emitted, has it been emitted before? - When a diagnostic is dropped, has it been emitted/cancelled? The first check is no longer need, because `emit` is consuming, so it's impossible to emit a `DiagnosticBuilder` twice. The second check is still needed. This commit replaces `DiagnosticBuilderState` with a simpler `Option<Box<Diagnostic>>`, which is enough for the second check: functions like `emit` and `cancel` can take the `Diagnostic` and then `drop` can check that the `Diagnostic` was taken. The `DiagCtxt` reference from `DiagnosticBuilderState` is now stored as its own field, removing the need for the `dcx` method. As well as making the code shorter and simpler, the commit removes: - One (deprecated) `ErrorGuaranteed::unchecked_claim_error_was_emitted` call. - Two `FIXME(eddyb)` comments that are no longer relevant. - The use of a dummy `Diagnostic` in `into_diagnostic`. Nice!		2024-01-08 16:18:54 +11:00
..
src	Remove DiagnosticBuilderState.	2024-01-08 16:18:54 +11:00
Cargo.toml	Clean up rustc_*/Cargo.toml.	2023-10-30 08:46:02 +11:00
messages.ftl	Implement diagnostic translation for expected lifetime parameter message	2023-07-07 15:56:01 +09:00