Nicholas Nethercote 2c2c7f13a6 Remove Handler::emit_diag_at_span. ... Compare `Handler::warn` and `Handler::span_warn`. Conceptually they are almost identical. But their implementations are weirdly different. `warn`: - calls `DiagnosticBuilder::<()>::new(self, Warning(None), msg)`, then `emit()` - which calls `G::diagnostic_builder_emit_producing_guarantee(self)` - which calls `handler.emit_diagnostic(&mut db.inner.diagnostic)` `span_warn`: - calls `self.emit_diag_at_span(Diagnostic::new(Warning(None), msg), span)` - which calls `self.emit_diagnostic(diag.set_span(sp))` I.e. they both end up at `emit_diagnostic`, but take very different routes to get there. This commit changes `span_*` and similar ones to not use `emit_diag_at_span`. Instead they just call `struct_span_*` + `emit`. Some nice side-effects of this: - `span_fatal` and `span_fatal_with_code` don't need `FatalError.raise()`, because `emit` does that. - `span_err` and `span_err_with_code` doesn't need `unwrap`. - `struct_span_note`'s `span` arg type is changed from `Span` to `impl Into<MultiSpan>` like all the other functions.		2023-12-15 09:48:00 +11:00
..
src	Remove Handler::emit_diag_at_span.	2023-12-15 09:48:00 +11:00
Cargo.toml	Clean up rustc_*/Cargo.toml.	2023-10-30 08:46:02 +11:00
messages.ftl	Implement diagnostic translation for expected lifetime parameter message	2023-07-07 15:56:01 +09:00