mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-20 03:27:30 +00:00
df247968f2
`ast::Item` has an `ident` field. - It's always non-empty for these item kinds: `ExternCrate`, `Static`, `Const`, `Fn`, `Mod`, `TyAlias`, `Enum`, `Struct`, `Union`, `Trait`, `TraitAlias`, `MacroDef`, `Delegation`. - It's always empty for these item kinds: `Use`, `ForeignMod`, `GlobalAsm`, `Impl`, `MacCall`, `DelegationMac`. There is a similar story for `AssocItemKind` and `ForeignItemKind`. Some sites that handle items check for an empty ident, some don't. This is a very C-like way of doing things, but this is Rust, we have sum types, we can do this properly and never forget to check for the exceptional case and never YOLO possibly empty identifiers (or possibly dummy spans) around and hope that things will work out. The commit is large but it's mostly obvious plumbing work. Some notable things. - `ast::Item` got 8 bytes bigger. This could be avoided by boxing the fields within some of the `ast::ItemKind` variants (specifically: `Struct`, `Union`, `Enum`). I might do that in a follow-up; this commit is big enough already. - For the visitors: `FnKind` no longer needs an `ident` field because the `Fn` within how has one. - In the parser, the `ItemInfo` typedef is no longer needed. It was used in various places to return an `Ident` alongside an `ItemKind`, but now the `Ident` (if present) is within the `ItemKind`. - In a few places I renamed identifier variables called `name` (or `foo_name`) as `ident` (or `foo_ident`), to better match the type, and because `name` is normally used for `Symbol`s. It's confusing to see something like `foo_name.name`. |
||
|---|---|---|
| .. | ||
| early | ||
| nonstandard_style | ||
| types | ||
| async_closures.rs | ||
| async_fn_in_trait.rs | ||
| builtin.rs | ||
| context.rs | ||
| dangling.rs | ||
| default_could_be_derived.rs | ||
| deref_into_dyn_supertrait.rs | ||
| drop_forget_useless.rs | ||
| early.rs | ||
| enum_intrinsics_non_enums.rs | ||
| errors.rs | ||
| expect.rs | ||
| for_loops_over_fallibles.rs | ||
| foreign_modules.rs | ||
| hidden_unicode_codepoints.rs | ||
| if_let_rescope.rs | ||
| impl_trait_overcaptures.rs | ||
| internal.rs | ||
| invalid_from_utf8.rs | ||
| late.rs | ||
| let_underscore.rs | ||
| levels.rs | ||
| lib.rs | ||
| lints.rs | ||
| macro_expr_fragment_specifier_2024_migration.rs | ||
| map_unit_fn.rs | ||
| multiple_supertrait_upcastable.rs | ||
| non_ascii_idents.rs | ||
| non_fmt_panic.rs | ||
| non_local_def.rs | ||
| nonstandard_style.rs | ||
| noop_method_call.rs | ||
| opaque_hidden_inferred_bound.rs | ||
| pass_by_value.rs | ||
| passes.rs | ||
| precedence.rs | ||
| ptr_nulls.rs | ||
| redundant_semicolon.rs | ||
| reference_casting.rs | ||
| shadowed_into_iter.rs | ||
| static_mut_refs.rs | ||
| tests.rs | ||
| traits.rs | ||
| types.rs | ||
| unit_bindings.rs | ||
| unqualified_local_imports.rs | ||
| unused.rs | ||
| utils.rs | ||