mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-16 02:24:35 +00:00
77 lines
3.1 KiB
Plaintext
77 lines
3.1 KiB
Plaintext
error: use Vec::sort here instead
|
|
--> $DIR/unnecessary_sort_by.rs:15:5
|
|
|
|
|
LL | vec.sort_by(|a, b| a.cmp(b));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort()`
|
|
|
|
|
= note: `-D clippy::unnecessary-sort-by` implied by `-D warnings`
|
|
|
|
error: use Vec::sort here instead
|
|
--> $DIR/unnecessary_sort_by.rs:16:5
|
|
|
|
|
LL | vec.sort_unstable_by(|a, b| a.cmp(b));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable()`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:17:5
|
|
|
|
|
LL | vec.sort_by(|a, b| (a + 5).abs().cmp(&(b + 5).abs()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|a| (a + 5).abs())`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:18:5
|
|
|
|
|
LL | vec.sort_unstable_by(|a, b| id(-a).cmp(&id(-b)));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|a| id(-a))`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:21:5
|
|
|
|
|
LL | vec.sort_by(|a, b| (b + 5).abs().cmp(&(a + 5).abs()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|b| Reverse((b + 5).abs()))`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:22:5
|
|
|
|
|
LL | vec.sort_unstable_by(|a, b| id(-b).cmp(&id(-a)));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|b| Reverse(id(-b)))`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:32:5
|
|
|
|
|
LL | vec.sort_by(|a, b| (***a).abs().cmp(&(***b).abs()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_by_key(|a| (***a).abs())`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:33:5
|
|
|
|
|
LL | vec.sort_unstable_by(|a, b| (***a).abs().cmp(&(***b).abs()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.sort_unstable_by_key(|a| (***a).abs())`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:93:9
|
|
|
|
|
LL | args.sort_by(|a, b| a.name().cmp(&b.name()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_by_key(|a| a.name())`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:94:9
|
|
|
|
|
LL | args.sort_unstable_by(|a, b| a.name().cmp(&b.name()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_unstable_by_key(|a| a.name())`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:96:9
|
|
|
|
|
LL | args.sort_by(|a, b| b.name().cmp(&a.name()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_by_key(|b| Reverse(b.name()))`
|
|
|
|
error: use Vec::sort_by_key here instead
|
|
--> $DIR/unnecessary_sort_by.rs:97:9
|
|
|
|
|
LL | args.sort_unstable_by(|a, b| b.name().cmp(&a.name()));
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.sort_unstable_by_key(|b| Reverse(b.name()))`
|
|
|
|
error: aborting due to 12 previous errors
|
|
|