mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-26 00:34:06 +00:00
8d1958f0d2
struct Concrete(u32);
impl Concrete {
fn m(self: &Box<Self>) -> &u32 {
&self.0
}
}
resulted in a confusing error.
impl Concrete {
fn n(self: &Box<&Self>) -> &u32 {
&self.0
}
}
resulted in no error or warning, despite apparent ambiguity over the elided
lifetime.
This commit changes two aspects of the behavior.
Previously, when examining the self type, we considered lifetimes only if they
were immediately adjacent to Self. We now consider lifetimes anywhere in the
self type.
Secondly, if more than one lifetime is discovered in the self type, we
disregard it as a possible lifetime elision candidate.
This is a compatibility break, and in fact has required some changes to tests
which assumed the earlier behavior.
Fixes https://github.com/rust-lang/rust/issues/117715
123 lines
5.6 KiB
Plaintext
123 lines
5.6 KiB
Plaintext
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:26:9
|
|
|
|
|
LL | fn ref_self(&self, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn ref_self<'a>(&self, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:33:9
|
|
|
|
|
LL | fn ref_Self(self: &Self, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn ref_Self<'a>(self: &Self, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:38:9
|
|
|
|
|
LL | fn box_ref_Self(self: Box<&Self>, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn box_ref_Self<'a>(self: Box<&Self>, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:43:9
|
|
|
|
|
LL | fn pin_ref_Self(self: Pin<&Self>, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn pin_ref_Self<'a>(self: Pin<&Self>, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:48:9
|
|
|
|
|
LL | fn box_box_ref_Self(self: Box<Box<&Self>>, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn box_box_ref_Self<'a>(self: Box<Box<&Self>>, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:53:9
|
|
|
|
|
LL | fn box_pin_ref_Self(self: Box<Pin<&Self>>, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn box_pin_ref_Self<'a>(self: Box<Pin<&Self>>, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:58:9
|
|
|
|
|
LL | fn wrap_ref_Self_Self(self: Wrap<&Self, Self>, f: &u8) -> &u8 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn wrap_ref_Self_Self<'a>(self: Wrap<&Self, Self>, f: &'a u8) -> &'a u8 {
|
|
| ++++ ++ ++
|
|
|
|
error: lifetime may not live long enough
|
|
--> $DIR/ref-self.rs:63:9
|
|
|
|
|
LL | fn ref_box_Self(self: &Box<Self>, f: &u32) -> &u32 {
|
|
| - - let's call the lifetime of this reference `'1`
|
|
| |
|
|
| let's call the lifetime of this reference `'2`
|
|
LL | f
|
|
| ^ method was supposed to return data with lifetime `'2` but it is returning data with lifetime `'1`
|
|
|
|
|
help: consider introducing a named lifetime parameter and update trait if needed
|
|
|
|
|
LL | fn ref_box_Self<'a>(self: &Box<Self>, f: &'a u32) -> &'a u32 {
|
|
| ++++ ++ ++
|
|
|
|
error: aborting due to 8 previous errors
|
|
|