mirror of
https://github.com/rust-lang/rust.git
synced 2025-06-20 11:37:32 +00:00
d30af5e168
Remove braces when fixing a nested use tree into a single item [Back in 2019](https://github.com/rust-lang/rust/pull/56645) I added rustfix support for the `unused_imports` lint, to automatically remove them when running `cargo fix`. For the most part this worked great, but when removing all but one childs of a nested use tree it turned `use foo::{Unused, Used}` into `use foo::{Used}`. This is slightly annoying, because it then requires you to run `rustfmt` to get `use foo::Used`. This PR automatically removes braces and the surrouding whitespace when all but one child of a nested use tree are unused. To get it done I had to add the span of the nested use tree to the AST, and refactor a bit the code I wrote back then. A thing I noticed is, there doesn't seem to be any `//@ run-rustfix` test for fixing the `unused_imports` lint. I created a test in `tests/suggestions` (is that the right directory?) that for now tests just what I added in the PR. I can followup in a separate PR to add more tests for fixing `unused_lints`. This PR is best reviewed commit-by-commit. |
||
|---|---|---|
| .. | ||
| assert | ||
| deriving | ||
| format_foreign | ||
| alloc_error_handler.rs | ||
| asm.rs | ||
| assert.rs | ||
| cfg_accessible.rs | ||
| cfg_eval.rs | ||
| cfg.rs | ||
| cmdline_attrs.rs | ||
| compile_error.rs | ||
| concat_bytes.rs | ||
| concat_idents.rs | ||
| concat.rs | ||
| derive.rs | ||
| edition_panic.rs | ||
| env.rs | ||
| errors.rs | ||
| format_foreign.rs | ||
| format.rs | ||
| global_allocator.rs | ||
| lib.rs | ||
| log_syntax.rs | ||
| pattern_type.rs | ||
| proc_macro_harness.rs | ||
| source_util.rs | ||
| standard_library_imports.rs | ||
| test_harness.rs | ||
| test.rs | ||
| trace_macros.rs | ||
| util.rs | ||