mirror of
https://github.com/rust-lang/rust.git
synced 2025-04-30 20:17:50 +00:00
0e7f91b75e
compile-time evaluation: detect writes through immutable pointers This has two motivations: - it unblocks https://github.com/rust-lang/rust/pull/116745 (and therefore takes a big step towards `const_mut_refs` stabilization), because we can now detect if the memory that we find in `const` can be interned as "immutable" - it would detect the UB that was uncovered in https://github.com/rust-lang/rust/pull/117905, which was caused by accidental stabilization of `copy` functions in `const` that can only be called with UB When UB is detected, we emit a future-compat warn-by-default lint. This is not a breaking change, so completely in line with [the const-UB RFC](https://rust-lang.github.io/rfcs/3016-const-ub.html), meaning we don't need t-lang FCP here. I made the lint immediately show up for dependencies since it is nearly impossible to even trigger this lint without `const_mut_refs` -- the accidentally stabilized `copy` functions are the only way this can happen, so the crates that popped up in #117905 are the only causes of such UB (in the code that crater covers), and the three cases of UB that we know about have all been fixed in their respective crates already. The way this is implemented is by making use of the fact that our interpreter is already generic over the notion of provenance. For CTFE we now use the new `CtfeProvenance` type which is conceptually an `AllocId` plus a boolean `immutable` flag (but packed for a more efficient representation). This means we can mark a pointer as immutable when it is created as a shared reference. The flag will be propagated to all pointers derived from this one. We can then check the immutable flag on each write to reject writes through immutable pointers. I just hope perf works out. |
||
|---|---|---|
| .. | ||
| abi | ||
| debuginfo | ||
| driver | ||
| intrinsics | ||
| optimize | ||
| allocator.rs | ||
| analyze.rs | ||
| archive.rs | ||
| base.rs | ||
| cast.rs | ||
| codegen_i128.rs | ||
| common.rs | ||
| compiler_builtins.rs | ||
| concurrency_limiter.rs | ||
| config.rs | ||
| constant.rs | ||
| discriminant.rs | ||
| global_asm.rs | ||
| inline_asm.rs | ||
| lib.rs | ||
| linkage.rs | ||
| main_shim.rs | ||
| num.rs | ||
| pointer.rs | ||
| pretty_clif.rs | ||
| toolchain.rs | ||
| trap.rs | ||
| unsize.rs | ||
| value_and_place.rs | ||
| vtable.rs | ||