Jacob Pratt 229c91bc31 Rollup merge of #134143 - nyurik:err-nul, r=dtolnay ... Convert `struct FromBytesWithNulError` into enum This PR renames the former `kind` enum from `FromBytesWithNulErrorKind` to `FromBytesWithNulError`, and removes the original struct. See https://github.com/rust-lang/libs-team/issues/493 ## Possible Changes - TBD * [x] should the new `enum FromBytesWithNulError` derive `Copy`? * [ ] should there be any new/changed attributes? * [x] add some more tests ## Problem One of `CStr` constructors, `CStr::from_bytes_with_nul(bytes: &[u8])` handles 3 cases: 1. `bytes` has one NULL as the last value - creates CStr 2. `bytes` has no NULL - error 3. `bytes` has a NULL in some other position - error The 3rd case is error that may require lossy conversion, but the 2nd case can easily be handled by the user code. Unfortunately, this function returns an opaque `FromBytesWithNulError` error in both 2nd and 3rd case, so the user cannot detect just the 2nd case - having to re-implement the entire function and bring in the `memchr` dependency. ## Motivating examples or use cases In [this code](f86d7a8768/varnish-sys/src/vcl/ws.rs (L158)), my FFI code needs to copy user's `&[u8]` into a C-allocated memory blob in a NUL-terminated `CStr` format. My code must first validate if `&[u8]` has a trailing NUL (case 1), no NUL (adds one on the fly - case 2), or NUL in the middle (3rd case - error). I had to re-implement `from_bytes_with_nul` and add `memchr`dependency just to handle the 2nd case. r? `@Amanieu`		2025-01-15 04:08:11 -05:00
..
benches	Fix typos	2024-12-27 21:35:57 +08:00
src	Rollup merge of #134143 - nyurik:err-nul, r=dtolnay	2025-01-15 04:08:11 -05:00
tests	Add inherent versions of MaybeUninit methods for slices	2025-01-11 23:57:00 -05:00
Cargo.toml	Teach rust core about Xtensa VaListImpl and add a custom lowering of vaarg for xtensa.	2024-12-03 10:54:08 +00:00