rust/compiler
Matthias Krüger 1a4c93e3ed
Rollup merge of #121784 - Zalathar:if-or-converge, r=Nadrieril
Make the success arms of `if lhs || rhs` meet up in a separate block

Extracted from #118305, where this is necessary to avoid introducing a bug when injecting marker statements into the then/else arms.

---

In the previous code (#111752), the success block of `lhs` would jump directly to the success block of `rhs`. However, `rhs_success_block` could already contain statements that are specific to the RHS, and the direct goto causes them to be executed in the LHS success path as well.

This patch therefore creates a fresh block that the LHS and RHS success blocks can both jump to.

---

I think the reason we currently get away with this is that `rhs_success_block` usually doesn't contain anything other than StorageDead statements for locals used by the RHS, and those statements don't seem to cause problems in the LHS success path (which never makes those locals live).

But if we start adding meaningful statements for branch coverage (or MC/DC coverage), it's important to keep the LHS and RHS blocks separate.
2024-03-01 17:51:30 +01:00
..
rustc
rustc_abi Add f16 and f128 to rustc_type_ir::FloatTy and rustc_abi::Primitive 2024-02-28 12:58:32 -05:00
rustc_arena rename ptr::invalid -> ptr::without_provenance 2024-02-21 20:15:52 +01:00
rustc_ast AST: Refactor type alias where clauses 2024-02-29 17:18:40 +01:00
rustc_ast_ir Split rustc_type_ir to avoid rustc_ast from depending on it 2024-02-27 18:11:23 +00:00
rustc_ast_lowering AST: Refactor type alias where clauses 2024-02-29 17:18:40 +01:00
rustc_ast_passes Detect empty leading where-clauses on type aliases 2024-02-29 17:20:04 +01:00
rustc_ast_pretty AST: Refactor type alias where clauses 2024-02-29 17:18:40 +01:00
rustc_attr Rename DiagnosticBuilder as Diag. 2024-02-28 08:55:35 +11:00
rustc_baked_icu_data
rustc_borrowck Rollup merge of #120646 - clubby789:uninit-destructuring-sugg, r=michaelwoerister 2024-03-01 17:51:28 +01:00
rustc_builtin_macros AST: Refactor type alias where clauses 2024-02-29 17:18:40 +01:00
rustc_codegen_cranelift Add f16 and f128 to rustc_type_ir::FloatTy and rustc_abi::Primitive 2024-02-28 12:58:32 -05:00
rustc_codegen_gcc Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_codegen_llvm Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_codegen_ssa Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_const_eval Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_data_structures compiler: use addr_of! 2024-02-24 18:53:48 +03:00
rustc_driver
rustc_driver_impl Inline and remove HumanEmitter::stderr. 2024-02-29 17:50:23 +11:00
rustc_error_codes remove platform-intrinsics ABI; make SIMD intrinsics be regular intrinsics 2024-02-25 08:14:52 +01:00
rustc_error_messages errors: only eagerly translate subdiagnostics 2024-02-15 10:34:41 +00:00
rustc_errors Rollup merge of #121783 - nnethercote:emitter-cleanups, r=oli-obk 2024-02-29 17:08:38 +01:00
rustc_expand Rename DiagCtxt::with_emitter as DiagCtxt::new. 2024-02-29 16:30:12 +11:00
rustc_feature Rollup merge of #121740 - surechen:change_attribute_to_local_20240228, r=lcnr 2024-02-29 05:25:27 -05:00
rustc_fluent_macro Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_fs_util Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_graphviz Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_hir Rollup merge of #121681 - jswrenn:nix-visibility-analysis, r=compiler-errors 2024-02-29 20:50:03 +01:00
rustc_hir_analysis Auto merge of #118247 - spastorino:type-equality-subtyping, r=lcnr 2024-02-29 19:18:41 +00:00
rustc_hir_pretty Lower anonymous structs or unions to HIR 2024-02-12 12:47:23 +08:00
rustc_hir_typeck Get rid of some sub_exp and eq_exp 2024-03-01 01:20:49 +00:00
rustc_incremental Adjust the has_errors* methods. 2024-02-22 08:03:47 +11:00
rustc_index Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_index_macros Step all bootstrap cfgs forward 2024-02-08 07:44:34 -05:00
rustc_infer Rollup merge of #121416 - veera-sivarajan:bugfix-120785, r=nnethercote 2024-03-01 17:51:28 +01:00
rustc_interface Rename Diagnostic as DiagInner. 2024-02-28 08:33:25 +11:00
rustc_lexer Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_lint Rollup merge of #121580 - Suyashtnt:issue-121502-fix, r=michaelwoerister 2024-03-01 17:51:29 +01:00
rustc_lint_defs Detect empty leading where-clauses on type aliases 2024-02-29 17:20:04 +01:00
rustc_llvm Rollup merge of #121389 - klensy:llvm-warn-fix, r=nikic 2024-02-26 16:06:02 +01:00
rustc_log Invert diagnostic lints. 2024-02-06 13:12:33 +11:00
rustc_macros Rename DiagnosticBuilder as Diag. 2024-02-28 08:55:35 +11:00
rustc_metadata Rename DiagnosticArg{,Map,Name,Value} as DiagArg{,Map,Name,Value}. 2024-02-28 08:55:37 +11:00
rustc_middle Rollup merge of #121416 - veera-sivarajan:bugfix-120785, r=nnethercote 2024-03-01 17:51:28 +01:00
rustc_mir_build Rollup merge of #121784 - Zalathar:if-or-converge, r=Nadrieril 2024-03-01 17:51:30 +01:00
rustc_mir_dataflow Auto merge of #120500 - oli-obk:intrinsics2.0, r=WaffleLapkin 2024-02-16 09:53:01 +00:00
rustc_mir_transform Rollup merge of #121654 - compiler-errors:async-fn-for-fn-def, r=oli-obk 2024-02-29 14:33:50 +01:00
rustc_monomorphize Rename DiagnosticBuilder as Diag. 2024-02-28 08:55:35 +11:00
rustc_next_trait_solver always emit AliasRelate goals when relating aliases 2024-02-26 10:17:43 +01:00
rustc_parse Rollup merge of #121326 - fmease:detect-empty-leading-where-clauses-on-ty-aliases, r=compiler-errors 2024-02-29 20:50:02 +01:00
rustc_parse_format remove a couple of redundant clones 2024-02-17 12:46:18 +01:00
rustc_passes Rollup merge of #121669 - nnethercote:count-stashed-errs-again, r=estebank 2024-02-29 17:08:38 +01:00
rustc_pattern_analysis Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_privacy Mark some once-again-unreachable paths as unreachable. 2024-02-29 11:08:29 +11:00
rustc_query_impl Rename Diagnostic as DiagInner. 2024-02-28 08:33:25 +11:00
rustc_query_system Overhaul how stashed diagnostics work, again. 2024-02-29 11:08:27 +11:00
rustc_resolve Rollup merge of #121792 - GuillaumeGomez:improve-suggestion, r=michaelwoerister 2024-02-29 14:33:53 +01:00
rustc_serialize Replace NonZero::<_>::new with NonZero::new. 2024-02-15 08:09:42 +01:00
rustc_session Rollup merge of #121783 - nnethercote:emitter-cleanups, r=oli-obk 2024-02-29 17:08:38 +01:00
rustc_smir Add f16 and f128 to rustc_type_ir::FloatTy and rustc_abi::Primitive 2024-02-28 12:58:32 -05:00
rustc_span Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_symbol_mangling Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_target Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
rustc_trait_selection Auto merge of #121462 - compiler-errors:eq-and-sub, r=lcnr 2024-03-01 10:30:42 +00:00
rustc_traits Rename some normalization-related items 2024-02-20 17:30:49 +01:00
rustc_transmute safe transmute: revise safety analysis 2024-02-27 16:22:32 +00:00
rustc_ty_utils Add f16 and f128 to rustc_type_ir::FloatTy and rustc_abi::Primitive 2024-02-28 12:58:32 -05:00
rustc_type_ir Auto merge of #121728 - tgross35:f16-f128-step1-ty-updates, r=compiler-errors 2024-03-01 03:36:11 +00:00
stable_mir remove platform-intrinsics ABI; make SIMD intrinsics be regular intrinsics 2024-02-25 08:14:52 +01:00